)]}'
{"mistral/actions/openstack/actions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"9adca61c07f5fdc3d7c6bba1204a3b607f185081","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            # localhost IP address. Thus, we get a session for this case."},{"line_number":396,"context_line":"            sess \u003d keystone_utils.get_admin_session()"},{"line_number":397,"context_line":"            return cls._get_client_class()(session\u003dsess)"},{"line_number":398,"context_line":"        except Exception:"},{"line_number":399,"context_line":"            # If it\u0027s not possible to establish a keystone session, attempt to"},{"line_number":400,"context_line":"            # create a client without it. This should fall back to where the"},{"line_number":401,"context_line":"            # ironic-inspector client tries to get it\u0027s own version on the"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ef037cb6","line":398,"updated":"2016-08-04 12:15:24.000000000","message":"I think we should probably LOG.exception() this.","commit_id":"4c608d265d43d5c0487d46d21d04620043ab431a"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"800b56d932586d720fb151d34dbf9a1e02deccb4","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            # catalog if the ironic-inspector server is not listening on the"},{"line_number":395,"context_line":"            # localhost IP address. Thus, we get a session for this case."},{"line_number":396,"context_line":"            sess \u003d keystone_utils.get_admin_session()"},{"line_number":397,"context_line":"            return cls._get_client_class()(session\u003dsess)"},{"line_number":398,"context_line":"        except Exception as e:"},{"line_number":399,"context_line":"            LOG.warning(\"There was an error trying to create the \""},{"line_number":400,"context_line":"                        \"ironic-inspector client using a session: %s\" % str(e))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_2932895e","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":18},"updated":"2016-08-05 04:52:00.000000000","message":"Soft: please insert a blank line before \u0027return\u0027","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"800b56d932586d720fb151d34dbf9a1e02deccb4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            # create a client without it. This should fall back to where the"},{"line_number":405,"context_line":"            # ironic-inspector client tries to get it\u0027s own version on the"},{"line_number":406,"context_line":"            # default IP address."},{"line_number":407,"context_line":"            return cls._get_client_class()()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def _get_client(self):"},{"line_number":410,"context_line":"        ctx \u003d context.ctx()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_c9300d59","line":407,"range":{"start_line":407,"start_character":12,"end_line":407,"end_character":18},"updated":"2016-08-05 04:52:00.000000000","message":"Soft: please insert a blank line before \u0027return\u0027","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"800b56d932586d720fb151d34dbf9a1e02deccb4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        username\u003dCONF.keystone_authtoken.admin_user,"},{"line_number":143,"context_line":"        password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":144,"context_line":"        project_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":145,"context_line":"        # NOTE(jaosorior): Once mistral supports keystone v3 properly, we can"},{"line_number":146,"context_line":"        # fetch the following values from the configuration."},{"line_number":147,"context_line":"        user_domain_name\u003d\u0027Default\u0027,"},{"line_number":148,"context_line":"        project_domain_name\u003d\u0027Default\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_a9ef99af","line":145,"range":{"start_line":145,"start_character":61,"end_line":145,"end_character":69},"updated":"2016-08-05 04:52:00.000000000","message":"Could you explain pls what you mean by \"properly\" here? I\u0027m basically asking for our self-education purposes.\n\nThanks","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"5121201af74d634e988e16abb67306110d0202b1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        username\u003dCONF.keystone_authtoken.admin_user,"},{"line_number":143,"context_line":"        password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":144,"context_line":"        project_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":145,"context_line":"        # NOTE(jaosorior): Once mistral supports keystone v3 properly, we can"},{"line_number":146,"context_line":"        # fetch the following values from the configuration."},{"line_number":147,"context_line":"        user_domain_name\u003d\u0027Default\u0027,"},{"line_number":148,"context_line":"        project_domain_name\u003d\u0027Default\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_db21f09f","line":145,"range":{"start_line":145,"start_character":61,"end_line":145,"end_character":69},"in_reply_to":"bacf61ea_a9ef99af","updated":"2016-08-05 05:11:24.000000000","message":"So, at the moment everything is hardcoded to using v2. In mistral one could start switching the catalog checking and endpoint getting to  using v3 plugins. But it doesn\u0027t make much difference if v3-specific parameters are not supported. Such as the user/project domain. So that\u0027s needed. On the other hand, it\u0027s probably better to use version agnostic stuff, such as what I got from keystoneauth1.identity.generic since that auto-discover the version.","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"694daad7efa8d40473f92f283dd645d765aab255","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        username\u003dCONF.keystone_authtoken.admin_user,"},{"line_number":143,"context_line":"        password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":144,"context_line":"        project_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":145,"context_line":"        # NOTE(jaosorior): Once mistral supports keystone v3 properly, we can"},{"line_number":146,"context_line":"        # fetch the following values from the configuration."},{"line_number":147,"context_line":"        user_domain_name\u003d\u0027Default\u0027,"},{"line_number":148,"context_line":"        project_domain_name\u003d\u0027Default\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_5e1a0ec7","line":145,"range":{"start_line":145,"start_character":61,"end_line":145,"end_character":69},"in_reply_to":"bacf61ea_db21f09f","updated":"2016-08-05 06:24:56.000000000","message":"Ok, thanks.","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"800b56d932586d720fb151d34dbf9a1e02deccb4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        # fetch the following values from the configuration."},{"line_number":147,"context_line":"        user_domain_name\u003d\u0027Default\u0027,"},{"line_number":148,"context_line":"        project_domain_name\u003d\u0027Default\u0027)"},{"line_number":149,"context_line":"    return ks_session.Session(auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_c9092d97","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":10},"updated":"2016-08-05 04:52:00.000000000","message":"Soft: insert a blank before \u0027return\u0027 pls.","commit_id":"675556154c1233860588ac0b44f426e747e89a1c"}]}
