)]}'
{"mistral/engine/rpc_backend/kombu/kombu_client.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"ee79d20ed73625c422372a1a96a29a43cb894277","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                    message.properties[\u0027correlation_id\u0027]):"},{"line_number":108,"context_line":"                utils.set_thread_local(IS_RECEIVED, True)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                # TODO(ddeja): Decide if raising exception to kombu is best"},{"line_number":111,"context_line":"                # behaviour."},{"line_number":112,"context_line":"                if message.properties.get(\u0027type\u0027) \u003d\u003d \u0027error\u0027:"},{"line_number":113,"context_line":"                    utils.set_thread_local(TYPE, \u0027error\u0027)"},{"line_number":114,"context_line":"                utils.set_thread_local(RESULT, response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_249a8bb9","line":111,"range":{"start_line":110,"start_character":15,"end_line":111,"end_character":28},"updated":"2016-08-23 16:21:37.000000000","message":"soft: I guess it can be removed","commit_id":"3b86f3037c4c563f0fa2e11c2dbb5401aa046e43"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"953670b1ad8e810eb3f24cdfcbe662e21b9f8975","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                    message.properties[\u0027correlation_id\u0027]):"},{"line_number":108,"context_line":"                utils.set_thread_local(IS_RECEIVED, True)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                # TODO(ddeja): Decide if raising exception to kombu is best"},{"line_number":111,"context_line":"                # behaviour."},{"line_number":112,"context_line":"                if message.properties.get(\u0027type\u0027) \u003d\u003d \u0027error\u0027:"},{"line_number":113,"context_line":"                    utils.set_thread_local(TYPE, \u0027error\u0027)"},{"line_number":114,"context_line":"                utils.set_thread_local(RESULT, response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_5591ea51","line":111,"range":{"start_line":110,"start_character":15,"end_line":111,"end_character":28},"in_reply_to":"1ac06dbe_249a8bb9","updated":"2016-08-24 15:38:58.000000000","message":"Done","commit_id":"3b86f3037c4c563f0fa2e11c2dbb5401aa046e43"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"ee79d20ed73625c422372a1a96a29a43cb894277","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Start waiting for response."},{"line_number":166,"context_line":"        if async:"},{"line_number":167,"context_line":"            return"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self._wait_for_result()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e40eb3e3","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":17},"updated":"2016-08-23 16:21:37.000000000","message":"I have a little query, In case of async call, how will error information will be pass to upper layers ?","commit_id":"3b86f3037c4c563f0fa2e11c2dbb5401aa046e43"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"953670b1ad8e810eb3f24cdfcbe662e21b9f8975","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Start waiting for response."},{"line_number":166,"context_line":"        if async:"},{"line_number":167,"context_line":"            return"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self._wait_for_result()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_d8618faa","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":17},"in_reply_to":"1ac06dbe_e40eb3e3","updated":"2016-08-24 15:38:58.000000000","message":"When we are using sync_call, the client sends a message and waits for reply to that message. It threads are stoped etc. unitl that reply comes or timeout is hit. On unlikely event of some error on server side (and it must be some unexpected exception, error during running-action wouldn\u0027t result in this) it would reply with a traceback object, that needs to be raised.\n\nIn case of async_call in contrary, we are not waiting for the reply, we want to proceed further with code. The information about the error would be send back from server to client also using async_call.","commit_id":"3b86f3037c4c563f0fa2e11c2dbb5401aa046e43"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"2e6cc0d32e9bd4e9b43ac66e87cb440b487d329d","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self._clear_thread_local()"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if res_type \u003d\u003d \u0027error\u0027:"},{"line_number":176,"context_line":"            raise result"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        return result"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_6aa14fa3","line":176,"range":{"start_line":175,"start_character":8,"end_line":176,"end_character":24},"updated":"2016-08-16 14:23:17.000000000","message":"Not sure if it is enough; should we also log it?","commit_id":"3b86f3037c4c563f0fa2e11c2dbb5401aa046e43"}],"mistral/tests/unit/engine/rpc_backend/kombu/test_kombu_client.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5becbabb1f565c462da2df36711a2e71a17ea1d3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.ctx,"},{"line_number":80,"context_line":"            \u0027method_not_found\u0027"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":"        # check if consumer.consume was called once"},{"line_number":83,"context_line":"        self.assertEqual(self.client.consumer.consume.call_count, 1)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @mock.patch.object(utils, \u0027set_thread_local\u0027, mock.MagicMock())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0ab6f6db","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":15},"updated":"2016-08-25 10:06:58.000000000","message":"Soft: Comments should start with a capital and end with a period.","commit_id":"0f86b4b542acc605a710b78fd05aca07ca107370"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"8fc02364f4b80017b324fca7e2ce084a0e03f5fc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.ctx,"},{"line_number":80,"context_line":"            \u0027method_not_found\u0027"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":"        # check if consumer.consume was called once"},{"line_number":83,"context_line":"        self.assertEqual(self.client.consumer.consume.call_count, 1)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @mock.patch.object(utils, \u0027set_thread_local\u0027, mock.MagicMock())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_da4f53bc","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":15},"in_reply_to":"1ac06dbe_0ab6f6db","updated":"2016-09-12 12:29:36.000000000","message":"Done","commit_id":"0f86b4b542acc605a710b78fd05aca07ca107370"}]}