)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6779ff48bdc57c9e089af5780cff0882c51a35c6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"TODO:"},{"line_number":14,"context_line":"- Make it optional, for initial testing of the approach this"},{"line_number":15,"context_line":"  always includes the output (unless it breaks everything, which"},{"line_number":16,"context_line":"  seems likely as I\u0027ve not been able to test it yet.)"},{"line_number":17,"context_line":"- Add tests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1617351"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_fbe1732b","line":16,"updated":"2016-09-01 16:59:02.000000000","message":"I was able to test this with some horrible hackery to make mistralclient print out the raw response. It seems to work fine, I just need to now make it optional and add unit tests.","commit_id":"4c7b6ed951e15f670ea6749fdd682bd8bd5c25fc"}],"mistral/api/controllers/v2/execution.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    # order to make sure that it is correctly loaded."},{"line_number":53,"context_line":"    hasattr(ex, \u0027output\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    res \u003d resources.Execution.from_dict(ex.to_dict())"},{"line_number":56,"context_line":"    return res"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_a9862ab7","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":7},"updated":"2016-09-05 03:14:44.000000000","message":"Soft: It\u0027s rather a matter of taste but I would inline \u0027res\u0027 variable.","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"}],"mistral/tests/unit/api/v2/test_executions.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"f50d6e308aea539638d042bfdb8d187f916d6249","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from mistral import exceptions as exc"},{"line_number":33,"context_line":"from mistral.tests.unit.api import base"},{"line_number":34,"context_line":"from mistral import utils"},{"line_number":35,"context_line":"from mistral.utils import rest_utils"},{"line_number":36,"context_line":"from mistral.api.controllers.v2 import execution"},{"line_number":37,"context_line":"from mistral.workflow import states"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# This line is needed for correct initialization of messaging config."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_09e946b7","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":48},"updated":"2016-09-02 11:42:53.000000000","message":"correct the order.Please correct the order","commit_id":"ebee00ef6bae4b0506e6965f660ff7ce1ef856df"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"f50d6e308aea539638d042bfdb8d187f916d6249","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        args, kwargs \u003d mock_get_all.call_args"},{"line_number":621,"context_line":"        resource_function \u003d kwargs[\u0027resource_function\u0027]"},{"line_number":622,"context_line":"        self.assertEqual(resource_function, execution._get_execution_resource)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @mock.patch.object(db_api, \u0027get_workflow_executions\u0027, MOCK_WF_EXECUTIONS)"},{"line_number":625,"context_line":"    @mock.patch.object(rest_utils, \u0027get_all\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_49934e5b","line":622,"range":{"start_line":622,"start_character":7,"end_line":622,"end_character":78},"updated":"2016-09-02 11:42:53.000000000","message":"ditto","commit_id":"ebee00ef6bae4b0506e6965f660ff7ce1ef856df"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"f50d6e308aea539638d042bfdb8d187f916d6249","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        args, kwargs \u003d mock_get_all.call_args"},{"line_number":635,"context_line":"        resource_function \u003d kwargs[\u0027resource_function\u0027]"},{"line_number":636,"context_line":"        self.assertEqual(resource_function, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_09b6a6f8","line":636,"range":{"start_line":636,"start_character":8,"end_line":636,"end_character":49},"updated":"2016-09-02 11:42:53.000000000","message":"It should be assertEqual(Expected, actual)\nSo please use self.assertEqual(None, resource_function)","commit_id":"ebee00ef6bae4b0506e6965f660ff7ce1ef856df"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d0c5e6ff64dbf310034a7ecef452646ec3e25e94","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        args, kwargs \u003d mock_get_all.call_args"},{"line_number":635,"context_line":"        resource_function \u003d kwargs[\u0027resource_function\u0027]"},{"line_number":636,"context_line":"        self.assertEqual(resource_function, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_c248105f","line":636,"in_reply_to":"fa7ab95a_09b6a6f8","updated":"2016-09-02 13:39:32.000000000","message":"I don\u0027t really agree - python\u0027s assertEqual doesn\u0027t have an order and actually all the Python documentation has the order the same way around as I did.\n\nHowever, I have updated it anyway.","commit_id":"ebee00ef6bae4b0506e6965f660ff7ce1ef856df"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    @mock.patch.object(db_api, \u0027get_workflow_executions\u0027, MOCK_WF_EXECUTIONS)"},{"line_number":611,"context_line":"    @mock.patch.object(rest_utils, \u0027get_all\u0027)"},{"line_number":612,"context_line":"    def test_get_all_executions_with_output(self, mock_get_all):"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        resp \u003d self.app.get("},{"line_number":615,"context_line":"            \u0027/v2/executions?include_output\u003dtrue\u0027"},{"line_number":616,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_69bb4273","line":613,"updated":"2016-09-05 03:14:44.000000000","message":"Soft: I\u0027d remove this blank line","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        args, kwargs \u003d mock_get_all.call_args"},{"line_number":621,"context_line":"        resource_function \u003d kwargs[\u0027resource_function\u0027]"},{"line_number":622,"context_line":"        self.assertEqual(execution._get_execution_resource, resource_function)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @mock.patch.object(db_api, \u0027get_workflow_executions\u0027, MOCK_WF_EXECUTIONS)"},{"line_number":625,"context_line":"    @mock.patch.object(rest_utils, \u0027get_all\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_29c13ae5","line":622,"range":{"start_line":622,"start_character":8,"end_line":622,"end_character":12},"updated":"2016-09-05 03:14:44.000000000","message":"Soft: insert a blank line before assertion.","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    @mock.patch.object(db_api, \u0027get_workflow_executions\u0027, MOCK_WF_EXECUTIONS)"},{"line_number":625,"context_line":"    @mock.patch.object(rest_utils, \u0027get_all\u0027)"},{"line_number":626,"context_line":"    def test_get_all_executions_without_output(self, mock_get_all):"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        resp \u003d self.app.get("},{"line_number":629,"context_line":"            \u0027/v2/executions\u0027"},{"line_number":630,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_89b0868d","line":627,"updated":"2016-09-05 03:14:44.000000000","message":"Soft: I\u0027d remove this blank line","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":625,"context_line":"    @mock.patch.object(rest_utils, \u0027get_all\u0027)"},{"line_number":626,"context_line":"    def test_get_all_executions_without_output(self, mock_get_all):"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        resp \u003d self.app.get("},{"line_number":629,"context_line":"            \u0027/v2/executions\u0027"},{"line_number":630,"context_line":"        )"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_697262e7","line":630,"range":{"start_line":628,"start_character":27,"end_line":630,"end_character":9},"updated":"2016-09-05 03:14:44.000000000","message":"Soft: it would fit into 80 chars on a single line.","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d28a4840f9e4ccd9c1eea5a611c32ae8972e5a12","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        args, kwargs \u003d mock_get_all.call_args"},{"line_number":635,"context_line":"        resource_function \u003d kwargs[\u0027resource_function\u0027]"},{"line_number":636,"context_line":"        self.assertEqual(None, resource_function)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_49b67e8b","line":636,"range":{"start_line":636,"start_character":8,"end_line":636,"end_character":12},"updated":"2016-09-05 03:14:44.000000000","message":"Soft: insert a blank line before assertion.","commit_id":"4085dfb0658243a00a3909bb9b7a4cf2e41d05e5"}]}
