)]}'
{"mistral/expressions.py":[{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"f40ff048793b874d017fa87ddb955027dec0a1bc","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return cls.find_expression_pattern.findall(s)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"_environment \u003d jinja2.Environment("},{"line_number":169,"context_line":"    undefined\u003djinja2.StrictUndefined,"},{"line_number":170,"context_line":"    trim_blocks\u003dTrue,"},{"line_number":171,"context_line":"    lstrip_blocks\u003dTrue"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_d6ddc671","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":12},"updated":"2016-09-22 16:15:58.000000000","message":"good reason to not make them JinjaEvaluator class members?","commit_id":"9389aca7ce568073c6a00b9b4ce4fed70919047c"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"ceabbe649f7575c43914756ea767de95a8a21c3c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return cls.find_expression_pattern.findall(s)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"_environment \u003d jinja2.Environment("},{"line_number":169,"context_line":"    undefined\u003djinja2.StrictUndefined,"},{"line_number":170,"context_line":"    trim_blocks\u003dTrue,"},{"line_number":171,"context_line":"    lstrip_blocks\u003dTrue"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_e34e7dc0","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":12},"in_reply_to":"5a8bc5a2_d6ddc671","updated":"2016-09-22 17:45:22.000000000","message":"Filters need to be initialized. We can move it to constructor, inherit InlineJinjaEvaluator off JinjaEvaluator, remove all @classmethods... I\u0027ll turn the question back around, is there are good reason to make them class members? If so, we should probably do the same with YAQL_ENGINE.","commit_id":"9389aca7ce568073c6a00b9b4ce4fed70919047c"},{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"f40ff048793b874d017fa87ddb955027dec0a1bc","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    _environment.filters[name] \u003d _filters[name]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class JinjaEvaluator(YAQLEvaluator):"},{"line_number":180,"context_line":"    _env \u003d _environment.overlay()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_1691ee99","line":179,"range":{"start_line":179,"start_character":34,"end_line":179,"end_character":36},"updated":"2016-09-22 16:15:58.000000000","message":"Shouldn\u0027t it be BaseEvaluator from which Jinja and YAQL evaluators both inherit?","commit_id":"9389aca7ce568073c6a00b9b4ce4fed70919047c"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"ceabbe649f7575c43914756ea767de95a8a21c3c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    _environment.filters[name] \u003d _filters[name]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class JinjaEvaluator(YAQLEvaluator):"},{"line_number":180,"context_line":"    _env \u003d _environment.overlay()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_43cc9135","line":179,"range":{"start_line":179,"start_character":34,"end_line":179,"end_character":36},"in_reply_to":"5a8bc5a2_1691ee99","updated":"2016-09-22 17:45:22.000000000","message":"Done","commit_id":"9389aca7ce568073c6a00b9b4ce4fed70919047c"},{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"83b7b51309aa498a604155683fa9052bf01e34ab","unresolved":false,"context_lines":[{"line_number":234,"context_line":"JINJA_REGEXP \u003d \u0027({{\\s*(\\S*)?\\s*}})|({%\\s*(\\S*)?\\s*?%})\u0027"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"class InlineJinjaEvaluator(YAQLEvaluator):"},{"line_number":238,"context_line":"    # The regular expression for Jinja variables and blocks"},{"line_number":239,"context_line":"    find_expression_pattern \u003d re.compile(JINJA_REGEXP)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_eed1f4fc","line":237,"range":{"start_line":237,"start_character":27,"end_line":237,"end_character":40},"updated":"2016-09-22 23:08:36.000000000","message":"Should inherit from JinjaEvaluator? or Evaluator? Not YAQL for sure :)","commit_id":"0ed02985871240d118d57762dfe33021844c70d3"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import jinja2"},{"line_number":22,"context_line":"from jinja2 import parser as jinja_parse"},{"line_number":23,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_56c088e0","line":20,"updated":"2016-09-23 23:13:23.000000000","message":"Can we split the implementation into separate files similar to what we do for the auth plugins?  expressions/__init__.py to put the abstract class, one file for YAQL, another for Jinja?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import jinja2"},{"line_number":22,"context_line":"from jinja2 import parser as jinja_parse"},{"line_number":23,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_af85cf07","line":20,"in_reply_to":"5a8bc5a2_364cc99d","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import jinja2"},{"line_number":22,"context_line":"from jinja2 import parser as jinja_parse"},{"line_number":23,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_364cc99d","line":20,"in_reply_to":"5a8bc5a2_56c088e0","updated":"2016-09-25 13:12:44.000000000","message":"I agree, it would be a little nicer.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    lstrip_blocks\u003dTrue"},{"line_number":172,"context_line":")"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"_filters \u003d evaluation_utils.get_custom_functions()"},{"line_number":175,"context_line":"for name in _filters:"},{"line_number":176,"context_line":"    _environment.filters[name] \u003d _filters[name]"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_d67645d6","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":8},"updated":"2016-09-25 13:12:44.000000000","message":"Soft: usually we put blank lines before all control structures like \"for\", \"try\" or \"return\".","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    lstrip_blocks\u003dTrue"},{"line_number":172,"context_line":")"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"_filters \u003d evaluation_utils.get_custom_functions()"},{"line_number":175,"context_line":"for name in _filters:"},{"line_number":176,"context_line":"    _environment.filters[name] \u003d _filters[name]"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_be44271b","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":8},"in_reply_to":"5a8bc5a2_d67645d6","updated":"2016-09-26 09:50:58.000000000","message":"Done. I feel like having a linting rule for that might prove beneficial.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"def validate(expression):"},{"line_number":289,"context_line":"    LOG.debug(\"Validating expression [expression\u003d\u0027%s\u0027]\", expression)"},{"line_number":290,"context_line":"    for name in _mgr.names():"},{"line_number":291,"context_line":"        evaluator \u003d _mgr[name].plugin"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if (isinstance(expression, six.string_types) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_96475d76","line":290,"range":{"start_line":290,"start_character":4,"end_line":290,"end_character":7},"updated":"2016-09-25 13:12:44.000000000","message":"Soft: insert a blank line before \u0027for\u0027.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"def validate(expression):"},{"line_number":289,"context_line":"    LOG.debug(\"Validating expression [expression\u003d\u0027%s\u0027]\", expression)"},{"line_number":290,"context_line":"    for name in _mgr.names():"},{"line_number":291,"context_line":"        evaluator \u003d _mgr[name].plugin"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if (isinstance(expression, six.string_types) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_1e543bc8","line":290,"range":{"start_line":290,"start_character":4,"end_line":290,"end_character":7},"in_reply_to":"5a8bc5a2_96475d76","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"def evaluate(expression, context):"},{"line_number":299,"context_line":"    for name in _mgr.names():"},{"line_number":300,"context_line":"        evaluator \u003d _mgr[name].plugin"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        # Check if the passed value is expression so we don\u0027t need to do this"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_a19d045b","line":299,"updated":"2016-09-23 23:13:23.000000000","message":"Instead of iterating, is there an expression that can detect whether this is jinja or yaql expression?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"def evaluate(expression, context):"},{"line_number":299,"context_line":"    for name in _mgr.names():"},{"line_number":300,"context_line":"        evaluator \u003d _mgr[name].plugin"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        # Check if the passed value is expression so we don\u0027t need to do this"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_3633e915","line":299,"in_reply_to":"5a8bc5a2_a19d045b","updated":"2016-09-25 13:12:44.000000000","message":"I think it\u0027s almost impossible because of using this \u0027inline\u0027 evaluation. The thing is that \"expression\" here can contain both YAQL and Jinja expressions and we need to push an expression through both evaluators.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"def evaluate(expression, context):"},{"line_number":299,"context_line":"    for name in _mgr.names():"},{"line_number":300,"context_line":"        evaluator \u003d _mgr[name].plugin"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        # Check if the passed value is expression so we don\u0027t need to do this"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_becd07b9","line":299,"in_reply_to":"5a8bc5a2_a19d045b","updated":"2016-09-26 09:50:58.000000000","message":"well, the expression that lets us detect whether it\u0027s a jinja or yaql or something else is in their \u0027is_expression\u0027 methods. You still need to iterate to check all the possible options. Is it a performance concern? I can hardly imagine any way that will be obviously more effective than simply iterating the list.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        # every time on a caller side."},{"line_number":304,"context_line":"        if (isinstance(expression, six.string_types) and"},{"line_number":305,"context_line":"                evaluator.is_expression(expression)):"},{"line_number":306,"context_line":"            return evaluator.evaluate(expression, context)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    return expression"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_d62485c6","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":28},"updated":"2016-09-25 13:12:44.000000000","message":"Part 1:\n\nPer my previous comment, I think it\u0027s not right to just return after first evaluation. If I have an expression \"I want to watch the movie \u003c% $.movie_title %\u003e at {{ _.theater }}\" then both expressions must be evaluated.\n\n\nPart 2:\nAfter I wrote Part 1 I also looked at the tests and didn\u0027t find any tests for different types of expressions in one string. But it would be really cool to support this case. And what\u0027s more, it could be even confusing I guess why it\u0027s not supported. Of course, I understand that it may not be straightforward to do because of Jinja\u0027s \"if\" and \"endif\" capabilities, for example. One solution to bypass this problem is to evaluate the expression with YAQL evaluator first and then push the result into Jinja evaluator.\n\nPlease consider my suggestions.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"6015f65985fd4d0755978dca2615d0b476d57127","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        # every time on a caller side."},{"line_number":304,"context_line":"        if (isinstance(expression, six.string_types) and"},{"line_number":305,"context_line":"                evaluator.is_expression(expression)):"},{"line_number":306,"context_line":"            return evaluator.evaluate(expression, context)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    return expression"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_5f504b0b","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":28},"in_reply_to":"5a8bc5a2_be7187aa","updated":"2016-09-26 19:57:21.000000000","message":"I quite strongly think we shall not mix YAQL and Jinja. Simplicity wins: simple statement in docs \"use one, mix won\u0027t work\", and simpler in impl.\n \nWhile I know that some StackStorm users have already. But only used it because Jinja was not supported.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        # every time on a caller side."},{"line_number":304,"context_line":"        if (isinstance(expression, six.string_types) and"},{"line_number":305,"context_line":"                evaluator.is_expression(expression)):"},{"line_number":306,"context_line":"            return evaluator.evaluate(expression, context)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    return expression"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_be7187aa","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":28},"in_reply_to":"5a8bc5a2_d62485c6","updated":"2016-09-26 09:50:58.000000000","message":"Is there really a value in mixing Jinja and YAQL together? They seem to be similar enough for you to be able to decide which one you want to use on per-line basis and switch if you think the requirements have changed.\n\nIf you try to evaluate them in sequence, it would either require us to rewrite the logic of inline evaluators (which would overly complicate the PR) or open you up to unexpected side effects (like YAQL expression generating jinja expression like \u003c% \u0027{\u0027 + \u0027{ a }}\u0027%\u003e when you never intended it to do so).\n\nI\u0027m arguing that we need to find an explicit use case where mixing the two is essential, or at the very least, makes sense, before we attempt to solve the problem.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}],"mistral/expressions/__init__.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bff09773aa280d7cf6164e2c0190faa61af42763","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from stevedore import extension"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from mistral import exceptions as exc"},{"line_number":23,"context_line":"from mistral.expressions.jinja_expression import JINJA_REGEXP  # noqa"},{"line_number":24,"context_line":"from mistral.expressions.yaql_expression import INLINE_YAQL_REGEXP  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_bfe05c2a","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":61},"updated":"2016-09-27 07:17:24.000000000","message":"In OpenStack we need to import only modules.","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"e8c24c5d7ca2ed6a7103f0d9ae3b130cd4c96109","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from stevedore import extension"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from mistral import exceptions as exc"},{"line_number":23,"context_line":"from mistral.expressions.jinja_expression import JINJA_REGEXP  # noqa"},{"line_number":24,"context_line":"from mistral.expressions.yaql_expression import INLINE_YAQL_REGEXP  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_e764d2e6","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":61},"in_reply_to":"5a8bc5a2_bfe05c2a","updated":"2016-09-28 09:09:57.000000000","message":"Done","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"782c0b7f2d5acfaf98829dbd5d927937bdf0bcdd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if expression_found:"},{"line_number":47,"context_line":"                raise exc.ExpressionGrammarException("},{"line_number":48,"context_line":"                    \"The line already contains an expression of type \u0027%s\u0027. \""},{"line_number":49,"context_line":"                    \"Mixing expressions is not allowed.\" %"},{"line_number":50,"context_line":"                    expression_found)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_3a3fc8d7","line":49,"updated":"2016-09-27 22:18:16.000000000","message":"Mixing expression types in a single line is not allowed.","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"e8c24c5d7ca2ed6a7103f0d9ae3b130cd4c96109","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if expression_found:"},{"line_number":47,"context_line":"                raise exc.ExpressionGrammarException("},{"line_number":48,"context_line":"                    \"The line already contains an expression of type \u0027%s\u0027. \""},{"line_number":49,"context_line":"                    \"Mixing expressions is not allowed.\" %"},{"line_number":50,"context_line":"                    expression_found)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_07629ed8","line":49,"in_reply_to":"5a8bc5a2_3a3fc8d7","updated":"2016-09-28 09:09:57.000000000","message":"Done","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"316e47fafe36bf1bbc3ecce2e380f60ecaa8f63c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from mistral.expressions import yaql_expression"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"JINJA_REGEXP \u003d jinja_expression.JINJA_REGEXP"},{"line_number":27,"context_line":"INLINE_YAQL_REGEXP \u003d yaql_expression.INLINE_YAQL_REGEXP"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_cd229001","line":27,"updated":"2016-09-28 11:23:55.000000000","message":"Neither of these are used in this file and JINJA_REGEXP is never used. It would be better to update the imports on INLINE_YAQL_REGEXP to the new location (I only see two uses in mistral/workbook/v2/tasks/py and mistral/workbook/base.py)","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"8c88e658472af640b4beac79649b535d7816f2a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from mistral.expressions import yaql_expression"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"JINJA_REGEXP \u003d jinja_expression.JINJA_REGEXP"},{"line_number":27,"context_line":"INLINE_YAQL_REGEXP \u003d yaql_expression.INLINE_YAQL_REGEXP"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_16ef25e9","line":27,"in_reply_to":"5a8bc5a2_cd229001","updated":"2016-09-29 04:58:57.000000000","message":"Done","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"}],"mistral/expressions/jinja_expression.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bff09773aa280d7cf6164e2c0190faa61af42763","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def is_expression(cls, s):"},{"line_number":141,"context_line":"        result \u003d cls.find_expression_pattern.search(s)"},{"line_number":142,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_bfb21c4a","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":14},"updated":"2016-09-27 07:17:24.000000000","message":"Soft: \u0027result\u0027 could be inlined.","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"e8c24c5d7ca2ed6a7103f0d9ae3b130cd4c96109","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def is_expression(cls, s):"},{"line_number":141,"context_line":"        result \u003d cls.find_expression_pattern.search(s)"},{"line_number":142,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_47e82617","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":14},"in_reply_to":"5a8bc5a2_bfb21c4a","updated":"2016-09-28 09:09:57.000000000","message":"Ah, missed that in patch set 8. Find something else interesting and I\u0027ll fix that in the next one :P","commit_id":"e771b44cc87aeaec959a9323d9dba6874b51cb99"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"316e47fafe36bf1bbc3ecce2e380f60ecaa8f63c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"JINJA_REGEXP \u003d \u0027({{\\s*(\\S*)?\\s*}})|({%\\s*(\\S*)?\\s*?%})\u0027"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"class InlineJinjaEvaluator(Evaluator):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_6dfdfc6d","line":97,"updated":"2016-09-28 11:23:55.000000000","message":"I would move this to the top as it is a \"constant\"","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"8c88e658472af640b4beac79649b535d7816f2a4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"JINJA_REGEXP \u003d \u0027({{\\s*(\\S*)?\\s*}})|({%\\s*(\\S*)?\\s*?%})\u0027"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"class InlineJinjaEvaluator(Evaluator):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_f6f1d9ce","line":97,"in_reply_to":"5a8bc5a2_6dfdfc6d","updated":"2016-09-29 04:58:57.000000000","message":"Done","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"86a6a6c23867644ffc3aadcc620eb6d1855de535","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def is_expression(cls, s):"},{"line_number":141,"context_line":"        return cls.find_expression_pattern.search(s) or \\"},{"line_number":142,"context_line":"            cls.find_block_pattern.search(s)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a98d1f4_0de5c1a6","line":141,"range":{"start_line":141,"start_character":56,"end_line":141,"end_character":57},"updated":"2016-10-03 07:46:01.000000000","message":"I hate to say that but using backslashes for breaking lines is not allowed in OpenStack :( Please use parenthesis.","commit_id":"1dd03aa5a7b94a678e3aab0505116c84fd52dded"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"b33af0aee53a1278ac74c72a6b4dac20fc46720f","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def is_expression(cls, s):"},{"line_number":141,"context_line":"        return cls.find_expression_pattern.search(s) or \\"},{"line_number":142,"context_line":"            cls.find_block_pattern.search(s)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a98d1f4_98b3cd09","line":141,"in_reply_to":"3a98d1f4_0de5c1a6","updated":"2016-10-03 08:19:46.000000000","message":"I would encourage that we don\u0027t manually enforce this and it should just be added as a soft comment. It should be automatically linted, or treated as soft feedback. It just isn\u0027t that important and I think there are better places to spend out time and energy. :-)","commit_id":"1dd03aa5a7b94a678e3aab0505116c84fd52dded"}],"mistral/expressions/yaql_expression.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"316e47fafe36bf1bbc3ecce2e380f60ecaa8f63c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return False"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"INLINE_YAQL_REGEXP \u003d \u0027\u003c%.*?%\u003e\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class InlineYAQLEvaluator(YAQLEvaluator):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_adf7048b","line":68,"updated":"2016-09-28 11:23:55.000000000","message":"I would move this to the top as it is a \"constant\"","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"8c88e658472af640b4beac79649b535d7816f2a4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return False"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"INLINE_YAQL_REGEXP \u003d \u0027\u003c%.*?%\u003e\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class InlineYAQLEvaluator(YAQLEvaluator):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_76ddc941","line":68,"in_reply_to":"5a8bc5a2_adf7048b","updated":"2016-09-29 04:58:57.000000000","message":"Done","commit_id":"4bd3cad03fc43893c2bf1dfc055d846511b73342"}],"mistral/tests/resources/action_jinja.yaml":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tags: [hello]"},{"line_number":7,"context_line":"  base: std.echo"},{"line_number":8,"context_line":"  base-input:"},{"line_number":9,"context_line":"    output: \u0027Hello,  {{ _.name }}\u0027"},{"line_number":10,"context_line":"  input:"},{"line_number":11,"context_line":"    - name"},{"line_number":12,"context_line":"  output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a8bc5a2_412d2045","line":9,"updated":"2016-09-23 23:13:23.000000000","message":"Is \"_\" here the equivalent of \"$\" in yaql? Any option to be consistent in accessing the context using \"$\"?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tags: [hello]"},{"line_number":7,"context_line":"  base: std.echo"},{"line_number":8,"context_line":"  base-input:"},{"line_number":9,"context_line":"    output: \u0027Hello,  {{ _.name }}\u0027"},{"line_number":10,"context_line":"  input:"},{"line_number":11,"context_line":"    - name"},{"line_number":12,"context_line":"  output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a8bc5a2_d6dac5e7","line":9,"in_reply_to":"5a8bc5a2_412d2045","updated":"2016-09-25 13:12:44.000000000","message":"Yes, I\u0027m curious too. Although I suppose it\u0027s a standand Jinja syntax.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tags: [hello]"},{"line_number":7,"context_line":"  base: std.echo"},{"line_number":8,"context_line":"  base-input:"},{"line_number":9,"context_line":"    output: \u0027Hello,  {{ _.name }}\u0027"},{"line_number":10,"context_line":"  input:"},{"line_number":11,"context_line":"    - name"},{"line_number":12,"context_line":"  output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a8bc5a2_5b7b35f5","line":9,"in_reply_to":"5a8bc5a2_d6dac5e7","updated":"2016-09-26 09:50:58.000000000","message":"Jinja doesn\u0027t have a direct equivalent of $ and data context is top level usually. I\u0027ve deliberately made it similar to YAQL to lower the bar for transition between them.\n\nAs for $, I would also like it to be the same, but Jinja only supports variable names matching r\u0027\\b[a-zA-Z_][a-zA-Z0-9_]*\\b\u0027 and even if you go all the way and try to modify jinja code itself, you would still have a hard time making it recognize $ after \\b. _ is the closest equivalent.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}],"mistral/tests/unit/test_expressions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_function_uuid(self):"},{"line_number":136,"context_line":"        uuid \u003d self._evaluator.evaluate(\u0027uuid()\u0027, {})"},{"line_number":137,"context_line":"        self.assertTrue(utils.validate_unicode_uuid(uuid))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_function_env(self):"},{"line_number":140,"context_line":"        ctx \u003d {\u0027__env\u0027: \u0027some\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_f62d01a9","line":137,"range":{"start_line":137,"start_character":13,"end_line":137,"end_character":23},"updated":"2016-09-25 13:12:44.000000000","message":"Soft: please separate assertions from preparations with blank line (so that there goes a block of preparations and then block of assertions)","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_function_uuid(self):"},{"line_number":136,"context_line":"        uuid \u003d self._evaluator.evaluate(\u0027uuid()\u0027, {})"},{"line_number":137,"context_line":"        self.assertTrue(utils.validate_unicode_uuid(uuid))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_function_env(self):"},{"line_number":140,"context_line":"        ctx \u003d {\u0027__env\u0027: \u0027some\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_9e0dabea","line":137,"range":{"start_line":137,"start_character":13,"end_line":137,"end_character":23},"in_reply_to":"5a8bc5a2_f62d01a9","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_function_env(self):"},{"line_number":140,"context_line":"        ctx \u003d {\u0027__env\u0027: \u0027some\u0027}"},{"line_number":141,"context_line":"        self.assertEqual(ctx[\u0027__env\u0027], self._evaluator.evaluate(\u0027env()\u0027, ctx))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InlineYAQLEvaluatorTest(base.BaseTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_162b4d95","line":141,"range":{"start_line":141,"start_character":13,"end_line":141,"end_character":24},"updated":"2016-09-25 13:12:44.000000000","message":"Same","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_function_env(self):"},{"line_number":140,"context_line":"        ctx \u003d {\u0027__env\u0027: \u0027some\u0027}"},{"line_number":141,"context_line":"        self.assertEqual(ctx[\u0027__env\u0027], self._evaluator.evaluate(\u0027env()\u0027, ctx))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InlineYAQLEvaluatorTest(base.BaseTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_be126707","line":141,"range":{"start_line":141,"start_character":13,"end_line":141,"end_character":24},"in_reply_to":"5a8bc5a2_162b4d95","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.assertRaises(exc.YaqlEvaluationException,"},{"line_number":211,"context_line":"                          self._evaluator.validate,"},{"line_number":212,"context_line":"                          {\u0027a\u0027: 1})"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class JinjaEvaluatorTest(base.BaseTest):"},{"line_number":216,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_a1b424d1","line":213,"updated":"2016-09-23 23:13:23.000000000","message":"Can we add tests to test statement w/ both YAQL and Jinja? side by side?  One embedded in another? How will these cases be handled? Even if we don\u0027t support it, I like to see an exception to let user know.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.assertRaises(exc.YaqlEvaluationException,"},{"line_number":211,"context_line":"                          self._evaluator.validate,"},{"line_number":212,"context_line":"                          {\u0027a\u0027: 1})"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class JinjaEvaluatorTest(base.BaseTest):"},{"line_number":216,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_9dce882c","line":213,"in_reply_to":"5a8bc5a2_a1b424d1","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                          self._evaluator.validate,"},{"line_number":212,"context_line":"                          {\u0027a\u0027: 1})"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class JinjaEvaluatorTest(base.BaseTest):"},{"line_number":216,"context_line":"    def setUp(self):"},{"line_number":217,"context_line":"        super(JinjaEvaluatorTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_011cf810","line":214,"updated":"2016-09-23 23:13:23.000000000","message":"Can we separate the Jinja tests to a separate file?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                          self._evaluator.validate,"},{"line_number":212,"context_line":"                          {\u0027a\u0027: 1})"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class JinjaEvaluatorTest(base.BaseTest):"},{"line_number":216,"context_line":"    def setUp(self):"},{"line_number":217,"context_line":"        super(JinjaEvaluatorTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_4f91ab46","line":214,"in_reply_to":"5a8bc5a2_011cf810","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}],"mistral/utils/__init__.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return six.text_type(str(uuid.uuid4()))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def validate_unicode_uuid(uuid_string):"},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        val \u003d uuid.UUID(uuid_string, version\u003d4)"},{"line_number":52,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_569cf50e","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":25},"updated":"2016-09-25 13:12:44.000000000","message":"Usually functions starting with \"validate\" raise exceptions if their argument is invalid. When a function rather returns a boolean I would call it \"is_unicode_uuid_valid\" or even \"is_uuid_valid\" because I\u0027m not sure that \u0027unicode\u0027 is too important here.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return six.text_type(str(uuid.uuid4()))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def validate_unicode_uuid(uuid_string):"},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        val \u003d uuid.UUID(uuid_string, version\u003d4)"},{"line_number":52,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_1e199b22","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":25},"in_reply_to":"5a8bc5a2_569cf50e","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}],"mistral/utils/evaluation_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 - Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"#    You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_766bb1f1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-09-25 13:12:44.000000000","message":"Not a critical comment but may be we could consider calling this file \"expression_utils.py\".","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 - Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"#    You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_beb7c7f3","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"5a8bc5a2_766bb1f1","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return new_ctx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_jinja_context(data_context):"},{"line_number":49,"context_line":"    global ROOT_JINJA_CONTEXT"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if not ROOT_JINJA_CONTEXT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_566a35ef","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":21},"updated":"2016-09-25 13:12:44.000000000","message":"I\u0027m kind of surprise that Jinja context initialization looks very similar to YAQL context initialization (there\u0027s a notion of root context in both, for example). Just curious if it\u0027s a coincidence or not :)","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return new_ctx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_jinja_context(data_context):"},{"line_number":49,"context_line":"    global ROOT_JINJA_CONTEXT"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if not ROOT_JINJA_CONTEXT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_9e812bc6","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":21},"in_reply_to":"5a8bc5a2_566a35ef","updated":"2016-09-26 09:50:58.000000000","message":"It\u0027s not a coincidence in a sense that I\u0027ve deliberately made their contexts similar to reduce confusion and lower the barrier of entry for the user. Now the question whether we really need a root context for Jinja is open due to last minute changes in _register_jinja_functions(). Now that you brought my attention to it, I\u0027ll simplify this part.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}],"setup.cfg":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    std.javascript \u003d mistral.actions.std_actions:JavaScriptAction"},{"line_number":70,"context_line":"    std.sleep \u003d mistral.actions.std_actions:SleepAction"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"mistral.evaluation_functions \u003d"},{"line_number":73,"context_line":"    json_pp \u003d mistral.utils.evaluation_utils:json_pp_"},{"line_number":74,"context_line":"    task \u003d mistral.utils.evaluation_utils:task_"},{"line_number":75,"context_line":"    execution \u003d mistral.utils.evaluation_utils:execution_"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_41d1a056","line":72,"updated":"2016-09-23 23:13:23.000000000","message":"how about mistral.expression.functions?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    std.javascript \u003d mistral.actions.std_actions:JavaScriptAction"},{"line_number":70,"context_line":"    std.sleep \u003d mistral.actions.std_actions:SleepAction"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"mistral.evaluation_functions \u003d"},{"line_number":73,"context_line":"    json_pp \u003d mistral.utils.evaluation_utils:json_pp_"},{"line_number":74,"context_line":"    task \u003d mistral.utils.evaluation_utils:task_"},{"line_number":75,"context_line":"    execution \u003d mistral.utils.evaluation_utils:execution_"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_d68805c8","line":72,"in_reply_to":"5a8bc5a2_41d1a056","updated":"2016-09-25 13:12:44.000000000","message":"Agree. \"expression\" is a common prefix for both functions and evaluators and hence can be separated into its own token.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    std.javascript \u003d mistral.actions.std_actions:JavaScriptAction"},{"line_number":70,"context_line":"    std.sleep \u003d mistral.actions.std_actions:SleepAction"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"mistral.evaluation_functions \u003d"},{"line_number":73,"context_line":"    json_pp \u003d mistral.utils.evaluation_utils:json_pp_"},{"line_number":74,"context_line":"    task \u003d mistral.utils.evaluation_utils:task_"},{"line_number":75,"context_line":"    execution \u003d mistral.utils.evaluation_utils:execution_"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_9eb4cb82","line":72,"in_reply_to":"5a8bc5a2_41d1a056","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fb66e0202b2c04d1274a52023d58f5475118262","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    env \u003d mistral.utils.evaluation_utils:env_"},{"line_number":77,"context_line":"    uuid \u003d mistral.utils.evaluation_utils:uuid_"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"mistral.expression_evaluators \u003d"},{"line_number":80,"context_line":"    yaql \u003d mistral.expressions:InlineYAQLEvaluator"},{"line_number":81,"context_line":"    jinja \u003d mistral.expressions:InlineJinjaEvaluator"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_21e49439","line":79,"updated":"2016-09-23 23:13:23.000000000","message":"how about mistral.expression.evaluators?","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b7fa7f32703deac7d63acf620411321dfe70192a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    env \u003d mistral.utils.evaluation_utils:env_"},{"line_number":77,"context_line":"    uuid \u003d mistral.utils.evaluation_utils:uuid_"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"mistral.expression_evaluators \u003d"},{"line_number":80,"context_line":"    yaql \u003d mistral.expressions:InlineYAQLEvaluator"},{"line_number":81,"context_line":"    jinja \u003d mistral.expressions:InlineJinjaEvaluator"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_56c315ed","line":79,"in_reply_to":"5a8bc5a2_21e49439","updated":"2016-09-25 13:12:44.000000000","message":"Agree.","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"49e43d76d85eb01878a92d46426334299f56915f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    env \u003d mistral.utils.evaluation_utils:env_"},{"line_number":77,"context_line":"    uuid \u003d mistral.utils.evaluation_utils:uuid_"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"mistral.expression_evaluators \u003d"},{"line_number":80,"context_line":"    yaql \u003d mistral.expressions:InlineYAQLEvaluator"},{"line_number":81,"context_line":"    jinja \u003d mistral.expressions:InlineJinjaEvaluator"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"5a8bc5a2_beb9877b","line":79,"in_reply_to":"5a8bc5a2_56c315ed","updated":"2016-09-26 09:50:58.000000000","message":"Done","commit_id":"f71b3f149ea70703d6523a3a44f3a2ecac071806"}]}
