)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0d21f3533aa912c7f707e935ea0f8c84baa72a09","unresolved":false,"context_lines":[{"line_number":17,"context_line":"to have the action run synchronously and have the result be saved."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch adds a new API parameter `run_sync` which will be exposed by the"},{"line_number":20,"context_line":"CLI as `--run-async`. This new argument is intended to be used with `--save-"},{"line_number":21,"context_line":"result` but can be be used independently to ensure an action isn\u0027t ran"},{"line_number":22,"context_line":"synchronously by mistake. With the new argument the behaviour of the command"},{"line_number":23,"context_line":"is now as follows:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a98d1f4_b414e29f","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":19},"updated":"2016-10-04 08:20:50.000000000","message":"-\u003e sync","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"5c48b03f1571669acbd9ece03ba2a6ab4084e540","unresolved":false,"context_lines":[{"line_number":22,"context_line":"synchronously by mistake. With the new argument the behaviour of the command"},{"line_number":23,"context_line":"is now as follows:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* `mistral run-action` This behaves as it did before, it runs async if it can,"},{"line_number":26,"context_line":"  or it schedules for later and saves the action."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* `mistral run-action --save-result` Again, this is the same as before, it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a98d1f4_f442ea66","line":25,"range":{"start_line":25,"start_character":62,"end_line":25,"end_character":67},"updated":"2016-10-04 08:24:51.000000000","message":"AFAIK, mistral run-action start actions in sync mode","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d98eb973b5f8d2e948fb8e5e4cb3b1d674e4f8bd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"synchronously by mistake. With the new argument the behaviour of the command"},{"line_number":23,"context_line":"is now as follows:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* `mistral run-action` This behaves as it did before, it runs async if it can,"},{"line_number":26,"context_line":"  or it schedules for later and saves the action."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* `mistral run-action --save-result` Again, this is the same as before, it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a98d1f4_c117efa0","line":25,"in_reply_to":"3a98d1f4_f442ea66","updated":"2016-10-04 16:22:35.000000000","message":"yup, good catch - this is another mistake. It seems I got this confused when I was writing this.","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0d21f3533aa912c7f707e935ea0f8c84baa72a09","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* `mistral run-action --save-result` Again, this is the same as before, it"},{"line_number":29,"context_line":"  schedules the action to run later and the action is saved."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* `mistral run-action --run-async` This is similar to having no argument"},{"line_number":32,"context_line":"  passed, however, if you try to run an action that can\u0027t be used"},{"line_number":33,"context_line":"  synchronously it will be rejected and an error is returned."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a98d1f4_140e768b","line":31,"range":{"start_line":31,"start_character":28,"end_line":31,"end_character":33},"updated":"2016-10-04 08:20:50.000000000","message":"-\u003e sync","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0d21f3533aa912c7f707e935ea0f8c84baa72a09","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  passed, however, if you try to run an action that can\u0027t be used"},{"line_number":33,"context_line":"  synchronously it will be rejected and an error is returned."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* `mistral run-action --run-async --save-result` The combination of the two"},{"line_number":36,"context_line":"  arguments runs the actions synchronously and saves the result. If the action"},{"line_number":37,"context_line":"  can\u0027t be ran synchronously then an error is returned."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a98d1f4_145cb67b","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"updated":"2016-10-04 08:20:50.000000000","message":"-\u003e sync","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"}],"mistral/api/controllers/v2/resources.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0d21f3533aa912c7f707e935ea0f8c84baa72a09","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            output\u003d{\u0027some_output\u0027: \u0027Hello, John Doe!\u0027},"},{"line_number":374,"context_line":"            created_at\u003d\u00271970-01-01T00:00:00.000000\u0027,"},{"line_number":375,"context_line":"            updated_at\u003d\u00271970-01-01T00:00:00.000000\u0027,"},{"line_number":376,"context_line":"            params\u003d{\u0027save_result\u0027: True, \"run_async\": False}"},{"line_number":377,"context_line":"        )"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_d47ecee2","line":376,"range":{"start_line":376,"start_character":46,"end_line":376,"end_character":51},"updated":"2016-10-04 08:20:50.000000000","message":"-\u003e sync","commit_id":"287caec825f1542eede7afc9496850dafe1fa563"}],"mistral/tests/unit/engine/test_run_action.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"219240f6532859185c6491e622c3f6cc4b50cd2e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.assertEqual(\u0027Hello!\u0027, action_ex.output[\u0027result\u0027])"},{"line_number":138,"context_line":"        self.assertEqual(states.SUCCESS, action_ex.state)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_run_action_save_result_and_run_sync(self):"},{"line_number":141,"context_line":"        # Start action."},{"line_number":142,"context_line":"        action_ex \u003d self.engine.start_action("},{"line_number":143,"context_line":"            \u0027std.echo\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_e27a2277","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":48},"updated":"2016-10-04 12:03:32.000000000","message":"This test should also check if action execution is saved in the DB.","commit_id":"9f7905fc8ee4777db462f25f0a88fb247e78fafe"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"22d109723277895bd96eb7181255f2f136ded3e9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.assertEqual(\u0027Hello!\u0027, action_ex.output[\u0027result\u0027])"},{"line_number":138,"context_line":"        self.assertEqual(states.SUCCESS, action_ex.state)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_run_action_save_result_and_run_sync(self):"},{"line_number":141,"context_line":"        # Start action."},{"line_number":142,"context_line":"        action_ex \u003d self.engine.start_action("},{"line_number":143,"context_line":"            \u0027std.echo\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_9ab61c3c","line":140,"in_reply_to":"3a98d1f4_e27a2277","updated":"2016-10-04 16:22:18.000000000","message":"Done","commit_id":"9f7905fc8ee4777db462f25f0a88fb247e78fafe"}]}
