)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4442289c5266ebb8329a73b6e3e387890c50edd1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"cancelled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iafc2263735f75fe06ae5f03a885cda8f965a7cc4"},{"line_number":18,"context_line":"Implements: blueprint mistral-cancel-state"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a629dbe_adc2f050","line":18,"updated":"2016-11-11 18:34:30.000000000","message":"Does this blueprint exist? The link in gerrit takes me to https://blueprints.launchpad.net/openstack/?searchtext\u003dmistral-cancel-state","commit_id":"eb96de5d52223d197ca51c9169483e9119b973ce"}],"mistral/tests/unit/api/v2/test_action_executions.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"4e3dbffc0ffa6ec5636ad465eb38902a1050bd15","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        )"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @mock.patch.object(rpc.EngineClient, \u0027on_action_complete\u0027)"},{"line_number":383,"context_line":"    def test_put_cancelled(self, f):"},{"line_number":384,"context_line":"        f.return_value \u003d CANCELLED_ACTION_EX_DB"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        resp \u003d self.app.put_json(\u0027/v2/action_executions/123\u0027, CANCELLED_ACTION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_39f6168f","line":383,"range":{"start_line":383,"start_character":33,"end_line":383,"end_character":34},"updated":"2016-10-17 13:03:39.000000000","message":"Soft: can you give more describing name?","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"c9b8578c26aebef618069898acdbbdc02d56b5a8","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        )"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @mock.patch.object(rpc.EngineClient, \u0027on_action_complete\u0027)"},{"line_number":383,"context_line":"    def test_put_cancelled(self, f):"},{"line_number":384,"context_line":"        f.return_value \u003d CANCELLED_ACTION_EX_DB"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        resp \u003d self.app.put_json(\u0027/v2/action_executions/123\u0027, CANCELLED_ACTION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a7cf36af","line":383,"range":{"start_line":383,"start_character":33,"end_line":383,"end_character":34},"in_reply_to":"fa6399be_39f6168f","updated":"2016-11-07 22:50:35.000000000","message":"Done","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"}],"mistral/tests/unit/engine/test_direct_workflow_rerun_cancelled.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"4e3dbffc0ffa6ec5636ad465eb38902a1050bd15","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Use the set_default method to set value otherwise in certain test cases"},{"line_number":27,"context_line":"# the change in value is not permanent."},{"line_number":28,"context_line":"cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DirectWorkflowRerunCancelledTest(base.EngineTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5c75782f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":57},"updated":"2016-10-17 13:03:39.000000000","message":"This can be very dangerous. It would change default for all other tests, that would run after this file is processed. Why not use fixture from oslo_config instead? Example:\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/test.py#n206","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"eabc668e319e761db1450ddcacc1521f6991c6e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Use the set_default method to set value otherwise in certain test cases"},{"line_number":27,"context_line":"# the change in value is not permanent."},{"line_number":28,"context_line":"cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DirectWorkflowRerunCancelledTest(base.EngineTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_0267d425","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":57},"in_reply_to":"9a629dbe_071e2263","updated":"2016-11-08 13:08:45.000000000","message":"OK, I see.","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"c9b8578c26aebef618069898acdbbdc02d56b5a8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Use the set_default method to set value otherwise in certain test cases"},{"line_number":27,"context_line":"# the change in value is not permanent."},{"line_number":28,"context_line":"cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DirectWorkflowRerunCancelledTest(base.EngineTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_071e2263","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":57},"in_reply_to":"fa6399be_5c75782f","updated":"2016-11-07 22:50:35.000000000","message":"If we change how we disable auth for testing, we\u0027ll have to do this in a separate bp because this is common across mistral unit tests.","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"05af7a84759817390463fc8de6446547655569bb","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        wf1_t1_ex \u003d self._assert_single_item(wf1_ex.task_executions, name\u003d\u0027t1\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.await_task_cancelled(wf1_t1_ex.id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        wf1_ex \u003d db_api.get_workflow_execution(wf1_ex.id)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b1cafd9f","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":47},"updated":"2016-11-08 13:08:17.000000000","message":"Shouldn\u0027t this be checked before we check if whole workflow is canceled?","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"4aecf63483834102be6a5fb808562a43de220f93","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        wf1_t1_ex \u003d self._assert_single_item(wf1_ex.task_executions, name\u003d\u0027t1\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.await_task_cancelled(wf1_t1_ex.id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        wf1_ex \u003d db_api.get_workflow_execution(wf1_ex.id)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_24484987","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":47},"in_reply_to":"9a629dbe_b1cafd9f","updated":"2016-11-08 23:15:34.000000000","message":"It doesn\u0027t matter but I moved it to above self.await_workflow_cancelled","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"05af7a84759817390463fc8de6446547655569bb","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.await_task_cancelled(wf1_t1_ex.id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        wf1_ex \u003d db_api.get_workflow_execution(wf1_ex.id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        wf1_t1_ex \u003d self._assert_single_item(wf1_ex.task_executions, name\u003d\u0027t1\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertEqual(states.CANCELLED, wf1_ex.state)"},{"line_number":103,"context_line":"        self.assertEqual(\"Cancelled tasks: t1\", wf1_ex.state_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_f14b9529","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":79},"updated":"2016-11-08 13:08:17.000000000","message":"Why you are acquiring those two objects again?","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"4aecf63483834102be6a5fb808562a43de220f93","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.await_task_cancelled(wf1_t1_ex.id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        wf1_ex \u003d db_api.get_workflow_execution(wf1_ex.id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        wf1_t1_ex \u003d self._assert_single_item(wf1_ex.task_executions, name\u003d\u0027t1\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertEqual(states.CANCELLED, wf1_ex.state)"},{"line_number":103,"context_line":"        self.assertEqual(\"Cancelled tasks: t1\", wf1_ex.state_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_645a4152","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":79},"in_reply_to":"9a629dbe_f14b9529","updated":"2016-11-08 23:15:34.000000000","message":"Removed","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"05af7a84759817390463fc8de6446547655569bb","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_ex.state)"},{"line_number":124,"context_line":"        self.assertEqual(2, len(wf1_t1_action_exs))"},{"line_number":125,"context_line":"        self.assertEqual(states.CANCELLED, wf1_t1_action_exs[0].state)"},{"line_number":126,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_action_exs[1].state)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.engine.on_action_complete("},{"line_number":129,"context_line":"            wf1_t1_action_exs[1].id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_c725f3ab","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":68},"updated":"2016-11-08 13:08:17.000000000","message":"Are we sure that those two action executions would be in this order? They are sorted by \u0027created_at\u0027, but I\u0027m wondering if we can be 100% sure that this field would be different for both.","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"741682fe5be5fafcd5c07210dd050b47c0d38caf","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_ex.state)"},{"line_number":124,"context_line":"        self.assertEqual(2, len(wf1_t1_action_exs))"},{"line_number":125,"context_line":"        self.assertEqual(states.CANCELLED, wf1_t1_action_exs[0].state)"},{"line_number":126,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_action_exs[1].state)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.engine.on_action_complete("},{"line_number":129,"context_line":"            wf1_t1_action_exs[1].id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_8318ea76","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":68},"in_reply_to":"9a629dbe_1c61a7d3","updated":"2016-11-10 08:16:14.000000000","message":"OK. Thanks for the explenation!","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"3ea65e2a56adf720d65656ed431fddf54087d05b","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_ex.state)"},{"line_number":124,"context_line":"        self.assertEqual(2, len(wf1_t1_action_exs))"},{"line_number":125,"context_line":"        self.assertEqual(states.CANCELLED, wf1_t1_action_exs[0].state)"},{"line_number":126,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_action_exs[1].state)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.engine.on_action_complete("},{"line_number":129,"context_line":"            wf1_t1_action_exs[1].id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b013a00c","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":68},"in_reply_to":"9a629dbe_a41c59c2","updated":"2016-11-09 10:25:05.000000000","message":"Yes, I know about this. I\u0027m just wondering if Renat\u0027s comments from [1] are also valid in this case.\n\n[1] https://review.openstack.org/#/c/388590/4/mistral/tests/unit/engine/test_policies.py","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"2e01fcc5825f919a95b4cb04db4b24e17c83c1fd","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_ex.state)"},{"line_number":124,"context_line":"        self.assertEqual(2, len(wf1_t1_action_exs))"},{"line_number":125,"context_line":"        self.assertEqual(states.CANCELLED, wf1_t1_action_exs[0].state)"},{"line_number":126,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_action_exs[1].state)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.engine.on_action_complete("},{"line_number":129,"context_line":"            wf1_t1_action_exs[1].id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_1c61a7d3","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":68},"in_reply_to":"9a629dbe_b013a00c","updated":"2016-11-09 22:00:49.000000000","message":"I have not come across a run where this test fails because of the ordering here. The dialog you\u0027re referring to specific to task executions and not action executions. In task executions particularly if there are parallel tasks, we can\u0027t accurate determine order.  But in this case, the action executions are executed one at a time in a control fashion. So the concern here is not applicable.","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"4aecf63483834102be6a5fb808562a43de220f93","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_ex.state)"},{"line_number":124,"context_line":"        self.assertEqual(2, len(wf1_t1_action_exs))"},{"line_number":125,"context_line":"        self.assertEqual(states.CANCELLED, wf1_t1_action_exs[0].state)"},{"line_number":126,"context_line":"        self.assertEqual(states.RUNNING, wf1_t1_action_exs[1].state)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.engine.on_action_complete("},{"line_number":129,"context_line":"            wf1_t1_action_exs[1].id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_a41c59c2","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":68},"in_reply_to":"9a629dbe_c725f3ab","updated":"2016-11-08 23:15:34.000000000","message":"Yes. Please review https://github.com/openstack/mistral/blob/master/mistral/db/v2/sqlalchemy/api.py#L704. They are sorted by time (created_at).","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"05af7a84759817390463fc8de6446547655569bb","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Check action executions of task 1."},{"line_number":147,"context_line":"        self.assertEqual(states.SUCCESS, wf1_t1_ex.state)"},{"line_number":148,"context_line":"        self.assertIsNone(wf1_t2_ex.state_info)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        wf1_t1_action_exs \u003d db_api.get_action_executions("},{"line_number":151,"context_line":"            task_execution_id\u003dwf1_t1_ex.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_a77c7f73","line":148,"range":{"start_line":148,"start_character":30,"end_line":148,"end_character":32},"updated":"2016-11-08 13:08:17.000000000","message":"Shouldn\u0027t it be \u0027t1\u0027?","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"4aecf63483834102be6a5fb808562a43de220f93","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Check action executions of task 1."},{"line_number":147,"context_line":"        self.assertEqual(states.SUCCESS, wf1_t1_ex.state)"},{"line_number":148,"context_line":"        self.assertIsNone(wf1_t2_ex.state_info)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        wf1_t1_action_exs \u003d db_api.get_action_executions("},{"line_number":151,"context_line":"            task_execution_id\u003dwf1_t1_ex.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_c44a2d83","line":148,"range":{"start_line":148,"start_character":30,"end_line":148,"end_character":32},"in_reply_to":"9a629dbe_a77c7f73","updated":"2016-11-08 23:15:34.000000000","message":"Good catch!","commit_id":"28d2d33cd2bb22a293b4d2f3273b1026e7a6f3bd"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"7efa9fdfa02acdc62837c75a45a96ab4e2c1f93b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":"    def test_rerun_cancelled_task(self):"},{"line_number":44,"context_line":"        wb_def \u003d \"\"\""},{"line_number":45,"context_line":"            version: \u00272.0\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            name: wb1"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_3478858f","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":14},"updated":"2016-11-16 07:11:04.000000000","message":"You don\u0027t have to use workbooks. IMO, using them everywhere in tests make them more verbose.","commit_id":"c564945b8fcfe5c203e0809070fb52f35f0eae1f"}],"mistral/tests/unit/engine/test_policies.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4442289c5266ebb8329a73b6e3e387890c50edd1","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        requests,"},{"line_number":518,"context_line":"        \u0027request\u0027,"},{"line_number":519,"context_line":"        mock.MagicMock(side_effect\u003dException())"},{"line_number":520,"context_line":"    )"},{"line_number":521,"context_line":"    def test_retry_policy(self):"},{"line_number":522,"context_line":"        wb_service.create_workbook_v2(RETRY_WB)"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_0d0bdc7d","line":520,"updated":"2016-11-11 18:34:30.000000000","message":"I don\u0027t really understand this addition - can you explain it?","commit_id":"eb96de5d52223d197ca51c9169483e9119b973ce"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"09e2a8f75d1ca6abfd521a61b45d35aac27463e4","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        requests,"},{"line_number":518,"context_line":"        \u0027request\u0027,"},{"line_number":519,"context_line":"        mock.MagicMock(side_effect\u003dException())"},{"line_number":520,"context_line":"    )"},{"line_number":521,"context_line":"    def test_retry_policy(self):"},{"line_number":522,"context_line":"        wb_service.create_workbook_v2(RETRY_WB)"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_23a43106","line":520,"in_reply_to":"9a629dbe_0d0bdc7d","updated":"2016-11-11 19:19:36.000000000","message":"This is actually a bug in mistral that\u0027s not related to this patch. Depending on the test environment, the bad URL in the RETRY_WB returned a response that didn\u0027t lead to error. The mock here ensures the HTTP call specified in the RETRY_WB is going to fail for this retry test here. This was a poorly written test as it tries to make an actual HTTP call to the bad URL.  Anyway, I will remove this and fix it separately so to move this patch forward.","commit_id":"eb96de5d52223d197ca51c9169483e9119b973ce"}],"mistral/utils/javascript.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"4e3dbffc0ffa6ec5636ad465eb38902a1050bd15","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from mistral import exceptions as exc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":"CONF.import_opt(\u0027js_implementation\u0027, \u0027mistral.config\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PYV8 \u003d importutils.try_import(\u0027PyV8\u0027)"},{"line_number":27,"context_line":"_V8EVAL \u003d importutils.try_import(\u0027v8eval\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_32c2ab85","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":54},"updated":"2016-10-17 13:03:39.000000000","message":"How this is related to whole change?","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"c9b8578c26aebef618069898acdbbdc02d56b5a8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from mistral import exceptions as exc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":"CONF.import_opt(\u0027js_implementation\u0027, \u0027mistral.config\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PYV8 \u003d importutils.try_import(\u0027PyV8\u0027)"},{"line_number":27,"context_line":"_V8EVAL \u003d importutils.try_import(\u0027v8eval\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_2d6a2581","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":54},"in_reply_to":"fa6399be_32c2ab85","updated":"2016-11-07 22:50:35.000000000","message":"I had problem w/ this earlier.  Maybe it was fixed in a patch. Anyway, it\u0027s removed now.","commit_id":"4b5af7812baeb55981351a988bd9bf677e1bfe23"}]}