)]}'
{"mistral/tests/unit/engine/test_policies.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a9b64858a43ccc1dab71961442d216f679d06503","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":"        retry_task \u003d wf_ex.task_executions[1]"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.assertDictEqual("},{"line_number":911,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_10133f5c","line":908,"range":{"start_line":908,"start_character":42,"end_line":908,"end_character":45},"updated":"2016-11-02 03:26:03.000000000","message":"It seems to be a dangerous assumption about order of the collection. I wonder if it will fail in case you run the test multiple times.","commit_id":"d2400dcb4c1ba5270f8a2a0bbf0f1636112aaaf5"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3b63317dab7688aa63222f184278dab5524adff4","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":"        retry_task \u003d wf_ex.task_executions[1]"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.assertDictEqual("},{"line_number":911,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_445dfa45","line":908,"in_reply_to":"ba5da102_040f8288","updated":"2016-11-02 07:18:49.000000000","message":"Agreed - it would be best to check this. Thanks for the explanation.","commit_id":"d2400dcb4c1ba5270f8a2a0bbf0f1636112aaaf5"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"232d9136e66dcc369a9b6999f931ec057943bb36","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":"        retry_task \u003d wf_ex.task_executions[1]"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.assertDictEqual("},{"line_number":911,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_0db7a5f5","line":908,"in_reply_to":"ba5da102_040f8288","updated":"2016-11-02 08:59:56.000000000","message":"Fair enough, Renat, thanks for pointing out this, will fix.","commit_id":"d2400dcb4c1ba5270f8a2a0bbf0f1636112aaaf5"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"ebc31d290bda13f53ba2a8c0da5ac40b95f6c1ee","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":"        retry_task \u003d wf_ex.task_executions[1]"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.assertDictEqual("},{"line_number":911,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_24cc8669","line":908,"in_reply_to":"ba5da102_10133f5c","updated":"2016-11-02 07:04:09.000000000","message":"Wont task2 always be executed after task1?","commit_id":"d2400dcb4c1ba5270f8a2a0bbf0f1636112aaaf5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"446eebea4cdcdf3979ed6f99cd72ba167bc29e55","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":"        retry_task \u003d wf_ex.task_executions[1]"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.assertDictEqual("},{"line_number":911,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_040f8288","line":908,"in_reply_to":"ba5da102_24cc8669","updated":"2016-11-02 07:09:55.000000000","message":"True, but that absolutely doesn\u0027t mean that the DB API method will return them in the same order. If it will I would like to see the evidence of that. If ordering is based on \u0027created_at\u0027 field that also doesn\u0027t guarantee the right ordering. The tasks can have the same value if they run quickly enough.\n\nI personally always avoid assumptions about ordering if it\u0027s not explicitly implied.","commit_id":"d2400dcb4c1ba5270f8a2a0bbf0f1636112aaaf5"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"2142014e1ff82f8f7cffdc7470e5b8b802b58531","unresolved":false,"context_lines":[{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"        for t in wf_ex.task_executions:"},{"line_number":910,"context_line":"            if t.name \u003d\u003d \u0027task2\u0027:"},{"line_number":911,"context_line":"                retry_task \u003d t"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        self.assertDictEqual("},{"line_number":914,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_3024aa5e","line":911,"range":{"start_line":909,"start_character":0,"end_line":911,"end_character":30},"updated":"2016-11-02 15:49:52.000000000","message":"You can use\n\n retry_task \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task2\u0027)","commit_id":"efe5ad629d059e7c0d2f16828a5e623b79d3cc15"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0d6fbb0b0ea05195e328e5243cf2808cf28f8e7a","unresolved":false,"context_lines":[{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"        for t in wf_ex.task_executions:"},{"line_number":910,"context_line":"            if t.name \u003d\u003d \u0027task2\u0027:"},{"line_number":911,"context_line":"                retry_task \u003d t"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        self.assertDictEqual("},{"line_number":914,"context_line":"            {\u0027retry_no\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_d9b2af4b","line":911,"range":{"start_line":909,"start_character":0,"end_line":911,"end_character":30},"in_reply_to":"ba5da102_3024aa5e","updated":"2016-11-02 20:17:18.000000000","message":"hah, that makes it more clear, thanks, Dawid","commit_id":"efe5ad629d059e7c0d2f16828a5e623b79d3cc15"}]}
