)]}'
{"mistral/api/controllers/v2/action.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"75ba72de530a7f84fc8908e63099cbbfa5b40208","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        acl.enforce(\u0027actions:get\u0027, context.ctx())"},{"line_number":58,"context_line":"        LOG.info(_LI(\"Fetch action [identifier\u003d%s]\") % identifier)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        db_model \u003d db_api.get_action_definition(identifier)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_16aaedd4","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":66},"updated":"2016-11-07 12:22:17.000000000","message":"Hi, As per guideline we should use , instead of %.\nPlease look into http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"f8cec9c097618413ad247d4bb9a19801dbc35428"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"75ba72de530a7f84fc8908e63099cbbfa5b40208","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                 \"filters\u003d%(FILTER)s\"), {"},{"line_number":200,"context_line":"                 \u0027Marker\u0027: marker,"},{"line_number":201,"context_line":"                 \u0027LIMIT\u0027: limit,"},{"line_number":202,"context_line":"                 \u0027SORT_KEY\u0027: sort_keys,"},{"line_number":203,"context_line":"                 \u0027SORT_DIRS\u0027: sort_dirs, \u0027FILTER\u0027: filters"},{"line_number":204,"context_line":"                 })"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_f6c9f9ad","line":202,"range":{"start_line":202,"start_character":18,"end_line":202,"end_character":26},"updated":"2016-11-07 12:22:17.000000000","message":"please use small fonts if possible.","commit_id":"f8cec9c097618413ad247d4bb9a19801dbc35428"}],"mistral/api/controllers/v2/member.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6e651adfd90c7a240d1e360fd1287ae5fb916b95","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        acl.enforce(\u0027members:create\u0027, context.ctx())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        LOG.info(_LI("},{"line_number":116,"context_line":"            \"Share resource to a member. [resource_id\u003d%(Resource)s, \""},{"line_number":117,"context_line":"            \"resource_type\u003d%(ResourceType)s, member_info\u003d%(Member)s].\"), {"},{"line_number":118,"context_line":"            \u0027Resource\u0027: self.resource_id,"},{"line_number":119,"context_line":"            \u0027ResourceType\u0027: self.type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_f8223651","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":64},"updated":"2016-11-10 05:00:47.000000000","message":"Do we have to use these identifiers with i18n? I personally don\u0027t like them since they make code more verbose.","commit_id":"764a996dc30722944df206815070b5a9b922d8d9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a69b2fb2742b9870a14891f4da9ffcba6f4cfc61","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        acl.enforce(\u0027members:create\u0027, context.ctx())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        LOG.info(_LI("},{"line_number":116,"context_line":"            \"Share resource to a member. [resource_id\u003d%(Resource)s, \""},{"line_number":117,"context_line":"            \"resource_type\u003d%(ResourceType)s, member_info\u003d%(Member)s].\"), {"},{"line_number":118,"context_line":"            \u0027Resource\u0027: self.resource_id,"},{"line_number":119,"context_line":"            \u0027ResourceType\u0027: self.type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_a1d4d8eb","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":64},"in_reply_to":"9a629dbe_9b893478","updated":"2016-11-11 05:36:44.000000000","message":"Is it critical for us? Why don\u0027t we enforce it?","commit_id":"764a996dc30722944df206815070b5a9b922d8d9"},{"author":{"_account_id":23733,"name":"pawnesh kumar","email":"pawnesh.kumar@nectechnologies.in","username":"pawnesh.kumar"},"change_message_id":"060f5ff47c47dff446445f3dfcc74fb84761a0ef","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        acl.enforce(\u0027members:create\u0027, context.ctx())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        LOG.info(_LI("},{"line_number":116,"context_line":"            \"Share resource to a member. [resource_id\u003d%(Resource)s, \""},{"line_number":117,"context_line":"            \"resource_type\u003d%(ResourceType)s, member_info\u003d%(Member)s].\"), {"},{"line_number":118,"context_line":"            \u0027Resource\u0027: self.resource_id,"},{"line_number":119,"context_line":"            \u0027ResourceType\u0027: self.type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_9b893478","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":64},"in_reply_to":"9a629dbe_f8223651","updated":"2016-11-10 05:35:32.000000000","message":"Thanks for reviewing.\n\nYes,If we dont use identifiers , flake8 shows error saying:\"Multiple positional placeholders are used\"","commit_id":"764a996dc30722944df206815070b5a9b922d8d9"}],"mistral/config.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"75ba72de530a7f84fc8908e63099cbbfa5b40208","unresolved":false,"context_lines":[{"line_number":32,"context_line":"launch_opt \u003d cfg.ListOpt("},{"line_number":33,"context_line":"    \u0027server\u0027,"},{"line_number":34,"context_line":"    default\u003d[\u0027all\u0027],"},{"line_number":35,"context_line":"    help\u003d_(\u0027Specifies which mistral server to start by the launch script. \u0027"},{"line_number":36,"context_line":"           \u0027Valid options are all or any combination of \u0027"},{"line_number":37,"context_line":"           \u0027api, engine, and executor.\u0027)"},{"line_number":38,"context_line":")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_b68ea125","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":11},"updated":"2016-11-07 12:22:17.000000000","message":"Do we need translation for config file ? I think we don\u0027t need it here. Have checked in other projects ?","commit_id":"f8cec9c097618413ad247d4bb9a19801dbc35428"}],"tox.ini":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"3e820db8a44006c7c99595d25c635f04826e134c","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[hacking]"},{"line_number":68,"context_line":"local-check-factory \u003d mistral.hacking.checks.factory"},{"line_number":69,"context_line":"import_exceptions \u003d mistral._i18n"}],"source_content_type":"text/x-properties","patch_set":4,"id":"ba5da102_f392e74a","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":33},"updated":"2016-11-04 12:17:29.000000000","message":"Why this line got added? (I\u0027m not a tox expert, just want to get extra knowledge)","commit_id":"87d4920853773e4d66aa54d109f1382fe6453846"},{"author":{"_account_id":23733,"name":"pawnesh kumar","email":"pawnesh.kumar@nectechnologies.in","username":"pawnesh.kumar"},"change_message_id":"9ef872e5c54e6c4768a77e58b556f4c94f24cbfb","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[hacking]"},{"line_number":68,"context_line":"local-check-factory \u003d mistral.hacking.checks.factory"},{"line_number":69,"context_line":"import_exceptions \u003d mistral._i18n"}],"source_content_type":"text/x-properties","patch_set":4,"id":"ba5da102_6046d4c0","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":33},"in_reply_to":"ba5da102_f392e74a","updated":"2016-11-07 04:17:29.000000000","message":"Thanks for review. please have a look on this doc\nhttp://docs.openstack.org/developer/oslo.i18n/usage.html\n\nThanks","commit_id":"87d4920853773e4d66aa54d109f1382fe6453846"}]}