)]}'
{"mistral/actions/openstack/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f676cc7035d5fbe2bdcf0cf9727c0aaacecf3578","unresolved":false,"context_lines":[{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        @classmethod"},{"line_number":790,"context_line":"        def _get_fake_client(cls):"},{"line_number":791,"context_line":"            return cls._get_client_class()(\"http://127.0.0.1:8778\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_36e4bfaa","line":791,"range":{"start_line":791,"start_character":61,"end_line":791,"end_character":65},"updated":"2016-11-10 06:51:03.000000000","message":"Why this port?","commit_id":"e3f546f92f746458f267bdea4e836b0b8ca75b7c"}],"mistral/tests/unit/actions/openstack/test_openstack_actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f676cc7035d5fbe2bdcf0cf9727c0aaacecf3578","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    @mock.patch.object(actions.SenlinAction, \u0027_get_client\u0027)"},{"line_number":364,"context_line":"    def test_senlin_action(self, mocked):"},{"line_number":365,"context_line":"        method_name \u003d \"get_cluster\""},{"line_number":366,"context_line":"        action_class \u003d actions.SenlinAction"},{"line_number":367,"context_line":"        action_class.client_method_name \u003d method_name"},{"line_number":368,"context_line":"        params \u003d {\u0027cluster_id\u0027: \u00271234-abcd\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_3692fff6","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":19},"updated":"2016-11-10 06:51:03.000000000","message":"Do we need this extra variable? I would inline it. It\u0027s used only once in a small local scope.","commit_id":"e3f546f92f746458f267bdea4e836b0b8ca75b7c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f676cc7035d5fbe2bdcf0cf9727c0aaacecf3578","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        method_name \u003d \"get_cluster\""},{"line_number":366,"context_line":"        action_class \u003d actions.SenlinAction"},{"line_number":367,"context_line":"        action_class.client_method_name \u003d method_name"},{"line_number":368,"context_line":"        params \u003d {\u0027cluster_id\u0027: \u00271234-abcd\u0027}"},{"line_number":369,"context_line":"        action \u003d action_class(**params)"},{"line_number":370,"context_line":"        action.run()"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_f6b24793","line":368,"range":{"start_line":368,"start_character":8,"end_line":368,"end_character":14},"updated":"2016-11-10 06:51:03.000000000","message":"Same here, I would inline \"params\" too.","commit_id":"e3f546f92f746458f267bdea4e836b0b8ca75b7c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f676cc7035d5fbe2bdcf0cf9727c0aaacecf3578","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        action_class.client_method_name \u003d method_name"},{"line_number":368,"context_line":"        params \u003d {\u0027cluster_id\u0027: \u00271234-abcd\u0027}"},{"line_number":369,"context_line":"        action \u003d action_class(**params)"},{"line_number":370,"context_line":"        action.run()"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        self.assertTrue(mocked().get_cluster.called)"},{"line_number":373,"context_line":"        mocked().get_cluster.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_966aebec","line":370,"range":{"start_line":370,"start_character":8,"end_line":370,"end_character":14},"updated":"2016-11-10 06:51:03.000000000","message":"Soft: I would separate this method with blank lines since this is the essential part of the method, it needs to be clearly visible. I know that you probably did as it was in other methods but those methods need to be adjusted too.","commit_id":"e3f546f92f746458f267bdea4e836b0b8ca75b7c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f676cc7035d5fbe2bdcf0cf9727c0aaacecf3578","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        action \u003d action_class(**params)"},{"line_number":370,"context_line":"        action.run()"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        self.assertTrue(mocked().get_cluster.called)"},{"line_number":373,"context_line":"        mocked().get_cluster.assert_called_once_with("},{"line_number":374,"context_line":"            cluster_id\u003d\"1234-abcd\""},{"line_number":375,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_56f85349","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":52},"updated":"2016-11-10 06:51:03.000000000","message":"Soft: add a blank line after the assertion block.","commit_id":"e3f546f92f746458f267bdea4e836b0b8ca75b7c"}]}