)]}'
{"mistral/api/controllers/v2/action.py":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"9ee2c6da0291dd15046418941d0381f2af85121c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":82,"context_line":"            )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        with db_api.transaction():"},{"line_number":85,"context_line":"            db_acts \u003d actions.update_actions("},{"line_number":86,"context_line":"                definition,"},{"line_number":87,"context_line":"                scope\u003dscope,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_1bb8dbc7","line":84,"range":{"start_line":84,"start_character":20,"end_line":84,"end_character":31},"updated":"2016-11-09 16:50:28.000000000","message":"we are using the db transaction context here, so is the decorator relevant here?","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"cad392ad4f5b81ef4890b459b84b02cea2e6b5d7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":82,"context_line":"            )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        with db_api.transaction():"},{"line_number":85,"context_line":"            db_acts \u003d actions.update_actions("},{"line_number":86,"context_line":"                definition,"},{"line_number":87,"context_line":"                scope\u003dscope,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_bb0b6f29","line":84,"in_reply_to":"9a629dbe_1bb8dbc7","updated":"2016-11-09 17:01:18.000000000","message":"It would be good to standardise this - so maybe we can remove it here? Same comment to below too.","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5cd26c37dfb74685142938040a8ae33216884dcd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":82,"context_line":"            )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        with db_api.transaction():"},{"line_number":85,"context_line":"            db_acts \u003d actions.update_actions("},{"line_number":86,"context_line":"                definition,"},{"line_number":87,"context_line":"                scope\u003dscope,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_c194b644","line":84,"in_reply_to":"9a629dbe_bb0b6f29","updated":"2016-11-09 17:31:10.000000000","message":"Everything is failing and I suspect this is why, the errors are related to the transaction having already been started.","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"96c9e7bc240a72b430056db884c87bf050446b50","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":82,"context_line":"            )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        with db_api.transaction():"},{"line_number":85,"context_line":"            db_acts \u003d actions.update_actions("},{"line_number":86,"context_line":"                definition,"},{"line_number":87,"context_line":"                scope\u003dscope,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a5c33bec","line":84,"in_reply_to":"9a629dbe_c194b644","updated":"2016-11-10 04:44:51.000000000","message":"Sure. This is the reason.","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"9ee2c6da0291dd15046418941d0381f2af85121c","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        LOG.info(\"Create action(s) [definition\u003d%s]\", definition)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        with db_api.transaction():"},{"line_number":119,"context_line":"            db_acts \u003d actions.create_actions(definition, scope\u003dscope)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        models_dicts \u003d [db_act.to_dict() for db_act in db_acts]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_db74a337","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":34},"updated":"2016-11-09 16:50:28.000000000","message":"do we need the decorator, as we are using the db transaction context here","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"9ee2c6da0291dd15046418941d0381f2af85121c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        acl.enforce(\u0027actions:delete\u0027, context.ctx())"},{"line_number":132,"context_line":"        LOG.info(\"Delete action [identifier\u003d%s]\", identifier)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        with db_api.transaction():"},{"line_number":135,"context_line":"            db_model \u003d db_api.get_action_definition(identifier)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            if db_model.is_system:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_fb716745","line":134,"range":{"start_line":134,"start_character":20,"end_line":134,"end_character":31},"updated":"2016-11-09 16:50:28.000000000","message":"same as line 118","commit_id":"a90b444d9548867e374542c52ffb35b6795cde6d"}]}
