)]}'
{"mistral/services/triggers.py":[{"author":{"_account_id":24086,"name":"Jizhaoxuan","email":"zhaoxuan.ji@easystack.cn","username":"xuange"},"change_message_id":"d6ab169ef012726014e24d7f8e1c36f8239089f6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            \u0027Pattern or first_execution_time must be specified.\u0027"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"    if first_time:"},{"line_number":48,"context_line":"        if (datetime.datetime.utcnow() + datetime.timedelta(0, 60)) \u003e first_time:"},{"line_number":49,"context_line":"            raise exc.InvalidModelException("},{"line_number":50,"context_line":"                \u0027first_execution_time must be at least 1 minute in the future.\u0027"},{"line_number":51,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_39c97579","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":80},"updated":"2016-12-02 01:56:34.000000000","message":"I think first_time may be local time,Do you think it will be ok if you change \u0027first_time\u0027 to \u0027first_utc_time\u0027","commit_id":"b9948d83d4785a005af50da3ba32f71611fb9f1c"}],"mistral/tests/unit/services/test_trigger_service.py":[{"author":{"_account_id":24086,"name":"Jizhaoxuan","email":"zhaoxuan.ji@easystack.cn","username":"xuange"},"change_message_id":"d6ab169ef012726014e24d7f8e1c36f8239089f6","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            \u0027*/3 * * * *\u0027,"},{"line_number":275,"context_line":"            None,"},{"line_number":276,"context_line":"            None,"},{"line_number":277,"context_line":"            datetime.datetime.utcnow() + datetime.timedelta(0, 50)"},{"line_number":278,"context_line":"        )"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        trigger_names \u003d [t.name for t in t_s.get_next_cron_triggers()]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d93a4136","line":277,"range":{"start_line":277,"start_character":12,"end_line":277,"end_character":66},"updated":"2016-12-02 01:56:34.000000000","message":"I don\u0027t think you need to change it.Because the parameter is local time","commit_id":"b9948d83d4785a005af50da3ba32f71611fb9f1c"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"a1b8140d067d5472d133d15eec429710fad13638","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def test_get_next_execution_time(self):"},{"line_number":334,"context_line":"        pattern \u003d \u0027*/20 * * * *\u0027"},{"line_number":335,"context_line":"        start_time \u003d datetime.datetime(2011, 3, 22, 23, 46)"},{"line_number":336,"context_line":"        result \u003d t_s.get_next_execution_time(pattern, start_time)"},{"line_number":337,"context_line":"        self.assertEqual(result, datetime.datetime(2011, 3, 23, 0, 0))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_af5a7e4e","line":335,"updated":"2016-11-16 08:18:27.000000000","message":"Should we test a timezone aware datetime?","commit_id":"b9948d83d4785a005af50da3ba32f71611fb9f1c"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"93991b5d99fab33ccad646c184d6b6b4fc5c478a","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def test_get_next_execution_time(self):"},{"line_number":334,"context_line":"        pattern \u003d \u0027*/20 * * * *\u0027"},{"line_number":335,"context_line":"        start_time \u003d datetime.datetime(2011, 3, 22, 23, 46)"},{"line_number":336,"context_line":"        result \u003d t_s.get_next_execution_time(pattern, start_time)"},{"line_number":337,"context_line":"        self.assertEqual(result, datetime.datetime(2011, 3, 23, 0, 0))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_7ed82980","line":335,"in_reply_to":"7a77a97e_af5a7e4e","updated":"2016-11-22 10:30:01.000000000","message":"I agree. We should check if newly added function converts from local to UTC in correct manner.","commit_id":"b9948d83d4785a005af50da3ba32f71611fb9f1c"}]}
