)]}'
{"mistral/actions/openstack/actions.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"a75d33cbacabb43c93bb1ff4b7cf4e7667982e4e","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            ironic_endpoint.url,"},{"line_number":375,"context_line":"            token\u003dctx.auth_token,"},{"line_number":376,"context_line":"            region_name\u003dironic_endpoint.region,"},{"line_number":377,"context_line":"            os_ironic_api_version\u003d\u00271.22\u0027,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_b0cbdc1d","line":377,"range":{"start_line":377,"start_character":12,"end_line":377,"end_character":41},"updated":"2016-11-30 13:59:18.000000000","message":"a) Unnecessary coma at the end of a line\nb) It seems OK, BUT as we add it for all of the other clients it would require someone from a team to go trough the whole file and change the version of API\u0027s once in a while. So my question is: can we obtain it automatically somehow? If the answer is yes - we should go this way (but we can merge it nevertheless if this change is needed for tripleO folks). If the answer is no, then I would like to create some constant value like IRONIC_API_VERSION at the beginning of this file (or maybe in separate file) so that we have one place when we keep all of the versions of APIs for every project.","commit_id":"566ddc7bc8c05c73627abe01fa2ad7c05ca91c1a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f363a9c4f8df23aa9512254b2f4a9d9197cf58","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            ironic_endpoint.url,"},{"line_number":375,"context_line":"            token\u003dctx.auth_token,"},{"line_number":376,"context_line":"            region_name\u003dironic_endpoint.region,"},{"line_number":377,"context_line":"            os_ironic_api_version\u003d\u00271.22\u0027,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_db5b192d","line":377,"range":{"start_line":377,"start_character":12,"end_line":377,"end_character":41},"in_reply_to":"5a74a57a_b0cbdc1d","updated":"2016-11-30 14:03:28.000000000","message":"\u003e Unnecessary coma at the end of a line\n\nThis will reduce the diff next time somebody appends something here, but I can remove it.\n\n\u003e can we obtain it automatically somehow\n\nWell, we can obtain the latest version from ironic, if this is something we want to. We can even just pass \"latest\" there and always get the latest version. However, this is not how they intend microversions to be used, as this will expose workflow users to unexpected changes in API, depending on what exactly version of Ironic they\u0027re running against.\n\nWhat would you prefer?","commit_id":"566ddc7bc8c05c73627abe01fa2ad7c05ca91c1a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5f1cfa89db36d994359d307ea8a4d9914a6072f4","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            ironic_endpoint.url,"},{"line_number":375,"context_line":"            token\u003dctx.auth_token,"},{"line_number":376,"context_line":"            region_name\u003dironic_endpoint.region,"},{"line_number":377,"context_line":"            os_ironic_api_version\u003d\u00271.22\u0027,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_3b4ecdc1","line":377,"range":{"start_line":377,"start_character":12,"end_line":377,"end_character":41},"in_reply_to":"5a74a57a_bb981d6c","updated":"2016-11-30 14:15:20.000000000","message":"\u003e I think that the best option would be to get the API version from config\n\nI don\u0027t think it\u0027s quite right: we don\u0027t keep actions in config, so operators won\u0027t get newer actions by just changing the config file. The ultimate solution is for users of API to provide a version, because it is users who provide workflows. This patch is more of a setting a reasonable default, because defaulting to mid-Liberty sounds suboptimal to me.","commit_id":"566ddc7bc8c05c73627abe01fa2ad7c05ca91c1a"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"724985474d6cd126a378939023dd7f7e6823552a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            ironic_endpoint.url,"},{"line_number":375,"context_line":"            token\u003dctx.auth_token,"},{"line_number":376,"context_line":"            region_name\u003dironic_endpoint.region,"},{"line_number":377,"context_line":"            os_ironic_api_version\u003d\u00271.22\u0027,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_bb981d6c","line":377,"range":{"start_line":377,"start_character":12,"end_line":377,"end_character":41},"in_reply_to":"5a74a57a_db5b192d","updated":"2016-11-30 14:11:46.000000000","message":"\u003e This will reduce the diff next time somebody appends something here, but I can remove it.\n\nRight, it can stay\n\n\u003e What would you prefer?\n\nAfter thinking a little about microversions and user experience I think that the best option would be to get the API version from config, so that everyone can use the version that suits them best.","commit_id":"566ddc7bc8c05c73627abe01fa2ad7c05ca91c1a"}]}
