)]}'
{"mistral/engine/tasks.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"0f51ca2a6a9c5d4163f7156a9a31d625084c73a3","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_dfce2a2c","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"updated":"2016-12-19 10:44:32.000000000","message":"I don\u0027t understand what this do. What is the reason to always break the \u0027for\u0027 loop after the first iteration?","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"5fd843297b3abb740523c39d534d235e6aa49f89","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_6eafc094","line":456,"range":{"start_line":454,"start_character":12,"end_line":456,"end_character":21},"updated":"2016-12-19 08:44:58.000000000","message":"action_count \u003d len(with_items_values.values()[0]) ?","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0b153bf2f08c2d0e6d0b9b847523ae2555285cac","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_a7c54d3e","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"in_reply_to":"1a6eadb0_5e2529c0","updated":"2016-12-20 05:15:53.000000000","message":"This is the only way I found because at least for Python 3 dict.values() returns a structure without random access (by index). It\u0027s basically an iterator. The only way is to use it as an iterator.","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"c16072a3380a751ca6264756178f3bd0644f8a2b","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_5059885a","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"in_reply_to":"1a6eadb0_70e76440","updated":"2016-12-20 09:00:42.000000000","message":"Renat,\n\nplease use something like\n\n v \u003d list(with_items_values.values())\n action_count \u003d len(v[0]) if v else 0","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"97c23c9db2cb145a12fd5e70b6913fdbf8213448","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_bdfc7a3f","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"in_reply_to":"1a6eadb0_a7c54d3e","updated":"2016-12-20 06:27:52.000000000","message":"Interesting... Can you just put a note ? Actually at first look it seems weird. It may create confusion in future.","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"91eeeaddefd417b3e54eaa8dd46a70b044e17aef","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_70e76440","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"in_reply_to":"1a6eadb0_bdfc7a3f","updated":"2016-12-20 08:45:40.000000000","message":"Is separate patch ok? Say https://review.openstack.org/#/c/412761/","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"98653819362ee5372494f1f3535fbd4a272fad5f","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            action_count \u003d 0"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            for v in with_items_values.values():"},{"line_number":455,"context_line":"                action_count \u003d len(v)"},{"line_number":456,"context_line":"                break"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            with_items.prepare_runtime_context("},{"line_number":459,"context_line":"                self.task_ex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_5e2529c0","line":456,"range":{"start_line":454,"start_character":0,"end_line":456,"end_character":21},"in_reply_to":"1a6eadb0_dfce2a2c","updated":"2016-12-20 01:34:31.000000000","message":"me neither, renat, can you explain it a little bit? or add some notes in the code?","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"635ea952a06352239b9a2aeeedbba089ed3a916a","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"            return"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        for i, input_dict in input_dicts:"},{"line_number":472,"context_line":"            target \u003d self._get_target(input_dict)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"            action \u003d self._build_action()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_e685acad","line":471,"updated":"2016-12-19 13:33:40.000000000","message":"Longer is better IMO :)","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0b153bf2f08c2d0e6d0b9b847523ae2555285cac","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"            return"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        for i, input_dict in input_dicts:"},{"line_number":472,"context_line":"            target \u003d self._get_target(input_dict)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"            action \u003d self._build_action()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_27e05dcc","line":471,"in_reply_to":"1a6eadb0_e685acad","updated":"2016-12-20 05:15:53.000000000","message":"A matter of taste :)","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"}],"mistral/tests/unit/engine/test_with_items.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"5963b4b1e851fed99ac4bc14fc3c6e3bdbfad963","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        self.assertEqual(12, len(task1_executions))"},{"line_number":1099,"context_line":"        self._assert_multiple_items(task1_executions, 3, accepted\u003dTrue)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    @testtools.skip(\u0027Repair with-items concurrency\u0027)"},{"line_number":1102,"context_line":"    def test_with_items_retry_policy_concurrency(self):"},{"line_number":1103,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":1104,"context_line":"        version: \"2.0\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_7653736b","line":1101,"updated":"2016-12-15 20:27:23.000000000","message":"Is this going to be fixed soon?","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f4ad865ac33a18663025f204d7fc6c49620934d2","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        self.assertEqual(12, len(task1_executions))"},{"line_number":1099,"context_line":"        self._assert_multiple_items(task1_executions, 3, accepted\u003dTrue)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    @testtools.skip(\u0027Repair with-items concurrency\u0027)"},{"line_number":1102,"context_line":"    def test_with_items_retry_policy_concurrency(self):"},{"line_number":1103,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":1104,"context_line":"        version: \"2.0\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_63a80578","line":1101,"in_reply_to":"1a6eadb0_7653736b","updated":"2016-12-16 06:33:59.000000000","message":"Yes, it seems like it\u0027s a problem of the test itself. I\u0027ll fix it soon.","commit_id":"f82b9bc8c3532639382afc1a4964ab9234c293c4"}]}