)]}'
{"mistral/actions/openstack/action_generator/base.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b8aeb34de4eb2cd131991c2671ea74cd3024462","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                            \u0027%(namespace)s.%(name)s %(e)s\u0027),"},{"line_number":91,"context_line":"                            {\u0027namespace\u0027: cls.action_namespace,"},{"line_number":92,"context_line":"                             \u0027name\u0027: action_name,"},{"line_number":93,"context_line":"                             \u0027e\u0027: e})"},{"line_number":94,"context_line":"                client_method \u003d None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if client_method:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_0425d2bf","line":93,"range":{"start_line":93,"start_character":36,"end_line":93,"end_character":37},"updated":"2016-12-27 09:38:26.000000000","message":"the closing braces should also be in a new line according to mistral code conventions.","commit_id":"ad9b42821fce3db7a30299709fd7114fa5e4e250"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b8aeb34de4eb2cd131991c2671ea74cd3024462","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                client_method \u003d clazz.get_fake_client_method()"},{"line_number":88,"context_line":"            except Exception as e:"},{"line_number":89,"context_line":"                LOG.warning(_LW(\u0027Failed to create action: \u0027"},{"line_number":90,"context_line":"                            \u0027%(namespace)s.%(name)s %(e)s\u0027),"},{"line_number":91,"context_line":"                            {\u0027namespace\u0027: cls.action_namespace,"},{"line_number":92,"context_line":"                             \u0027name\u0027: action_name,"},{"line_number":93,"context_line":"                             \u0027e\u0027: e})"},{"line_number":94,"context_line":"                client_method \u003d None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if client_method:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_24573627","line":93,"range":{"start_line":89,"start_character":28,"end_line":93,"end_character":36},"updated":"2016-12-27 09:38:26.000000000","message":"the code block should start in a new line.","commit_id":"ad9b42821fce3db7a30299709fd7114fa5e4e250"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"53bcd86823bc1e26c29e6ccaddfe5bd9c7a9bfbd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                LOG.warning("},{"line_number":90,"context_line":"                    _LW(\u0027Failed to create action: \u0027"},{"line_number":91,"context_line":"                        \u0027%(namespace)s.%(name)s %(e)s\u0027),"},{"line_number":92,"context_line":"                    {\u0027namespace\u0027: cls.action_namespace,"},{"line_number":93,"context_line":"                     \u0027name\u0027: action_name,"},{"line_number":94,"context_line":"                     \u0027e\u0027: e}"},{"line_number":95,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_2ce14cd1","line":92,"range":{"start_line":92,"start_character":22,"end_line":92,"end_character":31},"updated":"2017-01-10 04:15:24.000000000","message":"I might have asked this question before but I don\u0027t remember the answer. Is it necessary to use named placeholders? Like %(namespace). If not, I would prefer not to use them because they make code more verbose.","commit_id":"bd37c899aa64c25e71fba2bc55480a239614d1de"},{"author":{"_account_id":24086,"name":"Jizhaoxuan","email":"zhaoxuan.ji@easystack.cn","username":"xuange"},"change_message_id":"d12c2268904a65ca3ec45a04eaeaca1ce1ef97ac","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                LOG.warning("},{"line_number":90,"context_line":"                    _LW(\u0027Failed to create action: \u0027"},{"line_number":91,"context_line":"                        \u0027%(namespace)s.%(name)s %(e)s\u0027),"},{"line_number":92,"context_line":"                    {\u0027namespace\u0027: cls.action_namespace,"},{"line_number":93,"context_line":"                     \u0027name\u0027: action_name,"},{"line_number":94,"context_line":"                     \u0027e\u0027: e}"},{"line_number":95,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_ac229cff","line":92,"range":{"start_line":92,"start_character":22,"end_line":92,"end_character":31},"in_reply_to":"ba5201f7_2ce14cd1","updated":"2017-01-10 04:21:18.000000000","message":"I have ever tried not to use placeholders,but it had pep8 errors.","commit_id":"bd37c899aa64c25e71fba2bc55480a239614d1de"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2e38b8f9baa994bbe6410c24a0c2571e0e7fbdc7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                LOG.warning("},{"line_number":90,"context_line":"                    _LW(\u0027Failed to create action: \u0027"},{"line_number":91,"context_line":"                        \u0027%(namespace)s.%(name)s %(e)s\u0027),"},{"line_number":92,"context_line":"                    {\u0027namespace\u0027: cls.action_namespace,"},{"line_number":93,"context_line":"                     \u0027name\u0027: action_name,"},{"line_number":94,"context_line":"                     \u0027e\u0027: e}"},{"line_number":95,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a57fde8_2fe4090c","line":92,"range":{"start_line":92,"start_character":22,"end_line":92,"end_character":31},"in_reply_to":"ba5201f7_ac229cff","updated":"2017-01-12 07:29:56.000000000","message":"What errors? Do you get them only in case of using _LW or for any strings?","commit_id":"bd37c899aa64c25e71fba2bc55480a239614d1de"}],"mistral/actions/openstack/actions.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b8aeb34de4eb2cd131991c2671ea74cd3024462","unresolved":false,"context_lines":[{"line_number":408,"context_line":"            return cls._get_client_class()(session\u003dsess)"},{"line_number":409,"context_line":"        except Exception as e:"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            LOG.warning(_LW(\"There was an error trying to create the \""},{"line_number":412,"context_line":"                        \"ironic-inspector client using a session: %s\")"},{"line_number":413,"context_line":"                        % str(e))"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"            # If it\u0027s not possible to establish a keystone session, attempt to"},{"line_number":416,"context_line":"            # create a client without it. This should fall back to where the"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_38af5ae3","line":413,"range":{"start_line":411,"start_character":24,"end_line":413,"end_character":33},"updated":"2016-12-27 09:38:26.000000000","message":"same. Rent has a review here where the lines are indented according to the convention. see lines 1120-1125 for example\nhttps://review.openstack.org/#/c/415148/2/mistralclient/tests/functional/cli/v2/cli_tests_v2.py","commit_id":"ad9b42821fce3db7a30299709fd7114fa5e4e250"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"55fc3f4a8420471cb24bebc435d963c0b59031e5","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            LOG.warning("},{"line_number":412,"context_line":"                _LW(\"There was an error trying to create the \""},{"line_number":413,"context_line":"                    \"ironic-inspector client using a session: %s\")"},{"line_number":414,"context_line":"                % str(e)"},{"line_number":415,"context_line":"            )"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"            # If it\u0027s not possible to establish a keystone session, attempt to"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_fdb79037","line":414,"updated":"2017-01-04 22:48:26.000000000","message":"ditto","commit_id":"06d43b03e4188bb7af964e9655b2a2ad30b6d7f4"}],"mistral/engine/workflows.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b8aeb34de4eb2cd131991c2671ea74cd3024462","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            LOG.warning("},{"line_number":198,"context_line":"                _LW(\u0027Failed to get final context for %(wf_ex)s: %(e)s\u0027),"},{"line_number":199,"context_line":"                {\u0027wf_ex\u0027: self.wf_ex,"},{"line_number":200,"context_line":"                 \u0027e\u0027: e})"},{"line_number":201,"context_line":"        return final_context"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _create_execution(self, input_dict, desc, params):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_d8f1ee02","line":200,"range":{"start_line":200,"start_character":24,"end_line":200,"end_character":25},"updated":"2016-12-27 09:38:26.000000000","message":"should be in a new line","commit_id":"ad9b42821fce3db7a30299709fd7114fa5e4e250"}],"mistral/workflow/data_flow.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"55fc3f4a8420471cb24bebc435d963c0b59031e5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        LOG.warning("},{"line_number":203,"context_line":"            _LW(\u0027Shadowing context variable with \u0027"},{"line_number":204,"context_line":"                \u0027task name while publishing: %s\u0027)"},{"line_number":205,"context_line":"            % (task_ex.name)"},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    data \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_bdb18849","line":205,"range":{"start_line":205,"start_character":12,"end_line":205,"end_character":13},"updated":"2017-01-04 22:48:26.000000000","message":"According to i18n guideline, we shoud use comma to avoid string interpolation, so the correct format is:\n\n    LOG.info(_LW(\u0027some message: variable\u003d%s\u0027), variable)","commit_id":"06d43b03e4188bb7af964e9655b2a2ad30b6d7f4"}]}