)]}'
{"mistral/workbook/v2/workbook.py":[{"author":{"_account_id":23383,"name":"Endre János Kovács","email":"endre.kovacs@nokia.com","username":"endre.janos.kovacs"},"change_message_id":"a92bcc3f9ff45614dffcb4e131e81c0389b78ea4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from mistral.workbook.v2 import workflows as wf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# We want to match any single word that isn\u0027t exactly \"version\""},{"line_number":21,"context_line":"NON_VERSION_WORD_REGEX \u003d \"^(?!version$)[\\w-]+$\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WorkbookSpec(base.BaseSpec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_7c99fc1e","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":46},"updated":"2017-01-20 17:55:47.000000000","message":"Not necessarily a problem, but one thing to note here is that this particular pattern will also allow names consisting solely of hyphens, or even a single hyphen.","commit_id":"b8d94ee4b832f52008d80d72b4b15bd804e738f0"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d798d312f3b064d2429aa3631ce66e704419550f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from mistral.workbook.v2 import workflows as wf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# We want to match any single word that isn\u0027t exactly \"version\""},{"line_number":21,"context_line":"NON_VERSION_WORD_REGEX \u003d \"^(?!version$)[\\w-]+$\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WorkbookSpec(base.BaseSpec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f57a2c87","line":21,"in_reply_to":"5a3905b3_7c99fc1e","updated":"2017-01-23 08:08:25.000000000","message":"Endre, that is a good point, because \\w allows underscores that means a workflow could be named just \"_\" too. We might want to make it stricter again later, I\u0027ll open a bug about this so we don\u0027t forget.","commit_id":"b8d94ee4b832f52008d80d72b4b15bd804e738f0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"814f2ed909f63ff945915b5c28948e76afc9030e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from mistral.workbook.v2 import workflows as wf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# We want to match any single word that isn\u0027t exactly \"version\""},{"line_number":21,"context_line":"NON_VERSION_WORD_REGEX \u003d \"^(?!version$)[\\w-]+$\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WorkbookSpec(base.BaseSpec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_bea96a92","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":46},"in_reply_to":"5a3905b3_7c99fc1e","updated":"2017-01-23 04:57:44.000000000","message":"This doesn\u0027t also seem to include say underscores but we need them. I\u0027m ok though if it\u0027s addressed as a separate patch.","commit_id":"b8d94ee4b832f52008d80d72b4b15bd804e738f0"}]}