)]}'
{"mistral/actions/openstack/action_generator/base.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6659d3322a554f7944762c11532e84421c195778","unresolved":false,"context_lines":[{"line_number":26,"context_line":"os_actions_mapping_path \u003d cfg.StrOpt("},{"line_number":27,"context_line":"    \u0027openstack_actions_mapping_path\u0027,"},{"line_number":28,"context_line":"    short\u003d\u0027m\u0027,"},{"line_number":29,"context_line":"    metavar\u003d\u0027PATH\u0027,"},{"line_number":30,"context_line":"    default\u003d\u0027actions/openstack/mapping.json\u0027,"},{"line_number":31,"context_line":"    help\u003d\u0027Path to openstack action mapping json file.\u0027"},{"line_number":32,"context_line":"         \u0027It could be relative to mistral package \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_78455cb1","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":17},"updated":"2017-01-30 03:05:50.000000000","message":"\u0027PATH\u0027 here will make people confused with system path, how about \u0027MAPPING_PATH\u0027?","commit_id":"153ed40b26c5695872d287e0b075307d7eedc679"}],"mistral/tests/unit/actions/openstack/test_generator.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6659d3322a554f7944762c11532e84421c195778","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from mistral.actions import generator_factory"},{"line_number":15,"context_line":"from mistral.actions.openstack import actions"},{"line_number":16,"context_line":"from mistral.actions.openstack.actions import NovaAction"},{"line_number":17,"context_line":"from mistral.tests.unit import base"},{"line_number":18,"context_line":"from mock import patch"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_f8a22c4a","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":56},"updated":"2017-01-30 03:05:50.000000000","message":"This import is redundant, please use \u0027actions.NovaAction\u0027 instead.","commit_id":"153ed40b26c5695872d287e0b075307d7eedc679"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6659d3322a554f7944762c11532e84421c195778","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from mistral.actions.openstack import actions"},{"line_number":16,"context_line":"from mistral.actions.openstack.actions import NovaAction"},{"line_number":17,"context_line":"from mistral.tests.unit import base"},{"line_number":18,"context_line":"from mock import patch"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"MODULE_MAPPING \u003d {"},{"line_number":21,"context_line":"    \u0027nova\u0027: [\u0027nova.servers_get\u0027, actions.NovaAction],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_98be8863","line":18,"updated":"2017-01-30 03:05:50.000000000","message":"We usually use:\n\n    import mock\n    ...\n    @mock.patch(...)","commit_id":"153ed40b26c5695872d287e0b075307d7eedc679"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6659d3322a554f7944762c11532e84421c195778","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.assertTrue(issubclass(action[\u0027class\u0027], action_cls))"},{"line_number":68,"context_line":"            self.assertEqual(method_name, action[\u0027class\u0027].client_method_name)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @patch(target\u003d\"mistral.actions.openstack.action_generator.\""},{"line_number":71,"context_line":"                  \"base.CONF.openstack_actions_mapping_path\","},{"line_number":72,"context_line":"           new\u003d\"tests/resources/openstack/test_mapping.json\")"},{"line_number":73,"context_line":"    def test_missing_module_from_mapping(self):"},{"line_number":74,"context_line":"        for generator_cls in generator_factory.all_generators():"},{"line_number":75,"context_line":"            action_classes \u003d generator_cls.create_actions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_b89c2410","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":61},"updated":"2017-01-30 03:05:50.000000000","message":"why not define the configuration inside the test case (cfg.CONF.set_default)?","commit_id":"153ed40b26c5695872d287e0b075307d7eedc679"}]}