)]}'
{"mistral/tests/unit/utils/test_utils.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"d6c6834b9878029614829ac4574f9ba5a8dd34cd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            ]"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Digit keys and numbers."},{"line_number":187,"context_line":"        d \u003d {1: 2, 3: 4}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        s \u003d utils.cut_dict(d, 6)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.assertIn(s, [\"{1: 2, ...\", \"{3: 4, ...\"])"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        s \u003d utils.cut_dict(d, 8)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        self.assertIn(s, [\"{1: 2, 3...\", \"{3: 4, 1...\"])"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        s \u003d utils.cut_dict(d, 100)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        self.assertIn(s, [\"{1: 2, 3: 4}\", \"{3: 4, 1: 2}\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_666d88cb","line":199,"range":{"start_line":186,"start_character":0,"end_line":199,"end_character":58},"updated":"2017-01-31 12:19:25.000000000","message":"IMO this should be a separate test, so we can tell what\u0027s wrong just by looking on the test name.","commit_id":"7977c1e82ea420209329ac794f2d0f8d48c78174"}],"mistral/utils/__init__.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"53ba82de73251c411e28fc47ec6da450c2bb60c2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        # Processing key."},{"line_number":200,"context_line":"        new_len \u003d len(res) + len(k)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if isinstance(k, str):"},{"line_number":203,"context_line":"            new_len +\u003d 2"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if new_len \u003e\u003d length:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f22a328f","line":202,"updated":"2017-01-30 16:53:36.000000000","message":"Isn\u0027t k always a str? It is created with str(key)","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dc45d77f2ef31d81e7faf382366fa531e4dca16","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        # Processing key."},{"line_number":200,"context_line":"        new_len \u003d len(res) + len(k)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if isinstance(k, str):"},{"line_number":203,"context_line":"            new_len +\u003d 2"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if new_len \u003e\u003d length:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_fb9918c5","line":202,"in_reply_to":"3a461143_f22a328f","updated":"2017-01-31 08:38:33.000000000","message":"Ooh, this is actually a bug. It needs to be isinstance(key). I\u0027ll add more tests for that. Same for other checks.","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"53ba82de73251c411e28fc47ec6da450c2bb60c2","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        new_len \u003d len(res) + len(s)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if isinstance(item, str):"},{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b5125455","line":249,"updated":"2017-01-30 16:53:36.000000000","message":"like above, this should always be true.","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dc45d77f2ef31d81e7faf382366fa531e4dca16","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        new_len \u003d len(res) + len(s)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if isinstance(item, str):"},{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_9bd6544d","line":249,"in_reply_to":"3a461143_b5125455","updated":"2017-01-31 08:38:33.000000000","message":"No, this is ok because I check \u0027item\u0027, not \u0027s\u0027.","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"53ba82de73251c411e28fc47ec6da450c2bb60c2","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        if isinstance(item, str):"},{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"},{"line_number":253,"context_line":"            if isinstance(item, str):"},{"line_number":254,"context_line":"                res +\u003d \"\u0027%s...\" % s[:length - new_len]"},{"line_number":255,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b53974d9","line":252,"updated":"2017-01-30 16:53:36.000000000","message":"This if statement is repeated at least 3 times I think - might be worth breaking out?","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dc45d77f2ef31d81e7faf382366fa531e4dca16","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        if isinstance(item, str):"},{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"},{"line_number":253,"context_line":"            if isinstance(item, str):"},{"line_number":254,"context_line":"                res +\u003d \"\u0027%s...\" % s[:length - new_len]"},{"line_number":255,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_bb407008","line":252,"in_reply_to":"3a461143_b53974d9","updated":"2017-01-31 08:38:33.000000000","message":"Let me think about it.","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"53ba82de73251c411e28fc47ec6da450c2bb60c2","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"},{"line_number":253,"context_line":"            if isinstance(item, str):"},{"line_number":254,"context_line":"                res +\u003d \"\u0027%s...\" % s[:length - new_len]"},{"line_number":255,"context_line":"            else:"},{"line_number":256,"context_line":"                res +\u003d \"%s...\" % s"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_755aac2b","line":253,"updated":"2017-01-30 16:53:36.000000000","message":"always true?","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dc45d77f2ef31d81e7faf382366fa531e4dca16","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            new_len +\u003d 2"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if new_len \u003e\u003d length:"},{"line_number":253,"context_line":"            if isinstance(item, str):"},{"line_number":254,"context_line":"                res +\u003d \"\u0027%s...\" % s[:length - new_len]"},{"line_number":255,"context_line":"            else:"},{"line_number":256,"context_line":"                res +\u003d \"%s...\" % s"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_3bbe40ff","line":253,"in_reply_to":"3a461143_755aac2b","updated":"2017-01-31 08:38:33.000000000","message":"No, this is \"item\", not \"s\".","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"53ba82de73251c411e28fc47ec6da450c2bb60c2","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"            break"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            res +\u003d \"\u0027%s\u0027\" % s if isinstance(item, str) else s"},{"line_number":261,"context_line":"            res +\u003d \u0027, \u0027 if idx \u003c len(l) - 1 else \u0027]\u0027"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_95439841","line":260,"updated":"2017-01-30 16:53:36.000000000","message":"always true again?","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"617938fc02313ce51fe49bb4f8655bc03c0ffc2e","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"            break"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            res +\u003d \"\u0027%s\u0027\" % s if isinstance(item, str) else s"},{"line_number":261,"context_line":"            res +\u003d \u0027, \u0027 if idx \u003c len(l) - 1 else \u0027]\u0027"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_ec6b1983","line":260,"in_reply_to":"3a461143_1b4a6426","updated":"2017-01-31 12:54:58.000000000","message":"I guess the main difference between cases where item is str and item is not str - is that result string will or will not contain quotes at the edges of this object. That is, for object result will be: \n\n  {\u003csomeCoolObject at 0x12312\u003e: \"value\"}\n\nAnd for string it would:\n\n  {\u0027see the auotes\u0027: \u0027value\u0027}\n\nIs that correct?","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dc45d77f2ef31d81e7faf382366fa531e4dca16","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"            break"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            res +\u003d \"\u0027%s\u0027\" % s if isinstance(item, str) else s"},{"line_number":261,"context_line":"            res +\u003d \u0027, \u0027 if idx \u003c len(l) - 1 else \u0027]\u0027"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1b4a6426","line":260,"in_reply_to":"3a461143_95439841","updated":"2017-01-31 08:38:33.000000000","message":"Again no :)","commit_id":"f2a8ccaca1a79a9bb2157e28ec52098707afcdaa"}]}