)]}'
{"mistral/api/controllers/v2/action_execution.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"ccba45b4b3333e3adfc3b628348ad5679fe2436a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_53dace18","line":48,"updated":"2017-02-16 09:41:54.000000000","message":"This is a backwards incompatible change. Are we sure nobody is using this? Can we at least make it optional?\n\nFor example, in the workflow execution list there is an include_output parameter.\nhttps://github.com/openstack/mistral/blob/master/mistral/api/controllers/v2/execution.py#L271","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":22830,"name":"houweichao","email":"houwch@gohighsec.com","username":"houweichao"},"change_message_id":"7a85f7c0aa6417712cc69f34965cc1a6e5b6f3f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_053c6f92","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":35},"updated":"2017-02-20 10:26:06.000000000","message":"i think it should maintain the compatible feature","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6997c3a2ea60eb5afe650c3987d5ab1032c1f135","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_9fb8c7ea","line":48,"in_reply_to":"fa31d9ce_53dace18","updated":"2017-02-16 10:58:33.000000000","message":"Ooh, I actually forgot about this option for workflow executions. Michal, I agree with Dougal, we need to do the same. Btw, IMO it should be \"False\" by default, not \"None\".","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7977bf72828b6fbcea2d47cd5357020df21a2d58","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_9310c6ad","line":48,"in_reply_to":"fa31d9ce_53dace18","updated":"2017-02-16 09:43:04.000000000","message":"We also need to make sure this is removed from the documentation. The example here shows https://docs.openstack.org/developer/mistral/developer/webapi/v2.html#ActionExecution","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"1e1023e7ceb64a3d6a1392b1d7f21bce5d0609df","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_71e427ac","line":48,"in_reply_to":"fa31d9ce_79f8934a","updated":"2017-02-16 11:30:03.000000000","message":"no, I think leaving it is fine in that case. We should maybe make it clear that you need to enable it in both - but we can do that later.","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"93ef01c985658c077c89474de08cbc915904ffa4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_79f8934a","line":48,"in_reply_to":"fa31d9ce_9310c6ad","updated":"2017-02-16 11:09:48.000000000","message":"If we add the flag, do we still need to remove it from the docs? workflow executions has an output in it\u0027s sample.","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"93ef01c985658c077c89474de08cbc915904ffa4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    with db_api.transaction():"},{"line_number":46,"context_line":"        action_ex \u003d db_api.get_action_execution(id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        _load_deferred_output_field(action_ex)"},{"line_number":49,"context_line":"        return _get_action_execution_resource(action_ex)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_df423f68","line":48,"in_reply_to":"fa31d9ce_9fb8c7ea","updated":"2017-02-16 11:09:48.000000000","message":"cool, I\u0027ll add the flag to the code and tests","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"547579b038fb2c98177062c82beb421772de86af","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                         wtypes.text, wtypes.text, wtypes.text,"},{"line_number":194,"context_line":"                         wtypes.text, wtypes.text, wtypes.text, types.uuid,"},{"line_number":195,"context_line":"                         wtypes.text, wtypes.text, bool, types.jsontype,"},{"line_number":196,"context_line":"                         types.jsontype, types.jsontype, wtypes.text, bool)"},{"line_number":197,"context_line":"    def get_all(self, marker\u003dNone, limit\u003dNone, sort_keys\u003d\u0027created_at\u0027,"},{"line_number":198,"context_line":"                sort_dirs\u003d\u0027asc\u0027, fields\u003d\u0027\u0027, created_at\u003dNone, name\u003dNone,"},{"line_number":199,"context_line":"                tags\u003dNone, updated_at\u003dNone, workflow_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_f877139d","line":196,"range":{"start_line":196,"start_character":70,"end_line":196,"end_character":74},"updated":"2017-02-16 14:17:16.000000000","message":"this is what we have in executions, so I used it, but I tested and saw something odd - output filed is present in the action execution list when calling the API with include_output set to false like so: /v2/executions?include_output\u003dfalse\n\nI was thinking opening a bug and fixing it later if it is indeed a bug. Reviewers, what do you think?","commit_id":"f4d891864ef2d7a5fb9dea1cae478cbecb10c132"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2a546b87be08b3eec8ff3ac7d84170f497a93120","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _get_action_execution_resource(action_ex):"},{"line_number":50,"context_line":"    _load_deferred_output_field(action_ex)"},{"line_number":51,"context_line":"    return _get_action_execution_resource_for_list(action_ex)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_e8ec582b","line":50,"updated":"2017-02-21 19:32:51.000000000","message":"Soft: I\u0027d add a blank line before \u0027return\u0027","commit_id":"01945a5e7dddf7d2aa8f15692923cdf113fd868a"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4b624c1d46bab37366af3f364667579a652f5b48","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _get_action_execution_resource(action_ex):"},{"line_number":50,"context_line":"    _load_deferred_output_field(action_ex)"},{"line_number":51,"context_line":"    return _get_action_execution_resource_for_list(action_ex)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_342499c3","line":50,"in_reply_to":"da36d5c6_e8ec582b","updated":"2017-02-24 16:15:24.000000000","message":"Done","commit_id":"01945a5e7dddf7d2aa8f15692923cdf113fd868a"}],"mistral_tempest_tests/services/v2/mistral_client.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"aaf2f04e7df1a2c026ae522b253126a7989d7249","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return resp, json.loads(body)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_action_execution(self, action_execution_id):"},{"line_number":79,"context_line":"        resp \u003d self.get(\u0027action_executions/%s\u0027 % action_execution_id)"},{"line_number":80,"context_line":"        return resp"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def create_execution(self, identifier, wf_input\u003dNone, params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_d6bb17c2","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":12},"updated":"2017-02-16 04:00:39.000000000","message":"Soft: \u0027resp\u0027 could be inlined.","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"e9e1c3837660d29012328757b56c13138dc214eb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return resp, json.loads(body)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_action_execution(self, action_execution_id):"},{"line_number":79,"context_line":"        resp \u003d self.get(\u0027action_executions/%s\u0027 % action_execution_id)"},{"line_number":80,"context_line":"        return resp"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def create_execution(self, identifier, wf_input\u003dNone, params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_b385ca5a","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":12},"in_reply_to":"fa31d9ce_d6bb17c2","updated":"2017-02-16 09:36:44.000000000","message":"Done","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"}],"mistral_tempest_tests/tests/api/v2/test_action_executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"aaf2f04e7df1a2c026ae522b253126a7989d7249","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def resource_setup(cls):"},{"line_number":33,"context_line":"        super(ActionExecutionTestsV2, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.client.create_action_execution("},{"line_number":35,"context_line":"            {"},{"line_number":36,"context_line":"                \u0027name\u0027: \u0027std.echo\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_16004f65","line":33,"updated":"2017-02-16 04:00:39.000000000","message":"I\u0027d add a blank line after 33.","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"e9e1c3837660d29012328757b56c13138dc214eb","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def resource_setup(cls):"},{"line_number":33,"context_line":"        super(ActionExecutionTestsV2, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.client.create_action_execution("},{"line_number":35,"context_line":"            {"},{"line_number":36,"context_line":"                \u0027name\u0027: \u0027std.echo\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_1395b687","line":33,"in_reply_to":"fa31d9ce_16004f65","updated":"2017-02-16 09:36:44.000000000","message":"Done","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"aaf2f04e7df1a2c026ae522b253126a7989d7249","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":72,"context_line":"    def test_list_action_executions(self):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        resp, body \u003d self.client.get_list_obj(\u0027action_executions\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_b6df830b","line":73,"updated":"2017-02-16 04:00:39.000000000","message":"Soft: I\u0027d remove 73","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"e9e1c3837660d29012328757b56c13138dc214eb","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":72,"context_line":"    def test_list_action_executions(self):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        resp, body \u003d self.client.get_list_obj(\u0027action_executions\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_3392baa0","line":73,"in_reply_to":"fa31d9ce_b6df830b","updated":"2017-02-16 09:36:44.000000000","message":"Done","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"aaf2f04e7df1a2c026ae522b253126a7989d7249","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":79,"context_line":"    def test_output_appear_in_response_only_when_needed(self):"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        resp, body \u003d self.client.get_list_obj(\u0027action_executions\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_d6e237d4","line":80,"updated":"2017-02-16 04:00:39.000000000","message":"Soft: I\u0027d remove 80","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"e9e1c3837660d29012328757b56c13138dc214eb","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":79,"context_line":"    def test_output_appear_in_response_only_when_needed(self):"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        resp, body \u003d self.client.get_list_obj(\u0027action_executions\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_538f2e75","line":80,"in_reply_to":"fa31d9ce_d6e237d4","updated":"2017-02-16 09:36:44.000000000","message":"Done","commit_id":"ce924202acfd0aa14200b81d62edc3bf73006f77"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"547579b038fb2c98177062c82beb421772de86af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                \u0027input\u0027: \u0027{\"output\": \"Hello, Mistral!\"}\u0027"},{"line_number":39,"context_line":"            }"},{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_cleanup(cls):"},{"line_number":44,"context_line":"        for action_ex in cls.client.action_executions:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_d8ba4f71","line":41,"updated":"2017-02-16 14:17:16.000000000","message":"is it OK to create a workflow execution here?","commit_id":"f4d891864ef2d7a5fb9dea1cae478cbecb10c132"}],"releasenotes/notes/include-output-paramter-in-action-execution-list-c946f1b38dc5a052.yaml":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2a546b87be08b3eec8ff3ac7d84170f497a93120","unresolved":false,"context_lines":[{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    New parameter called \u0027include_outpt\u0027 added to action execution api."},{"line_number":7,"context_line":"    By default output field does not return when calling list action executions"},{"line_number":8,"context_line":"    API"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da36d5c6_c805d4c2","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":39},"updated":"2017-02-21 19:32:51.000000000","message":"typo in \u0027output\u0027","commit_id":"01945a5e7dddf7d2aa8f15692923cdf113fd868a"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4b624c1d46bab37366af3f364667579a652f5b48","unresolved":false,"context_lines":[{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    New parameter called \u0027include_outpt\u0027 added to action execution api."},{"line_number":7,"context_line":"    By default output field does not return when calling list action executions"},{"line_number":8,"context_line":"    API"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da36d5c6_f414c14d","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":39},"in_reply_to":"da36d5c6_c805d4c2","updated":"2017-02-24 16:15:24.000000000","message":"Done","commit_id":"01945a5e7dddf7d2aa8f15692923cdf113fd868a"}]}