)]}'
{"mistral/tests/unit/utils/test_utils.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"891333de72183131f35f920fbda5793773542a27","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \u0027param2\u0027: 2,"},{"line_number":117,"context_line":"                \u0027param3\u0027: \u0027var3\u0027"},{"line_number":118,"context_line":"            },"},{"line_number":119,"context_line":"            utils.get_dict_from_string(\u0027param1, param2\u003d2, param3\u003d\"var3\"\u0027)"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self.assertDictEqual({}, utils.get_dict_from_string(\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_82993271","line":119,"range":{"start_line":119,"start_character":18,"end_line":119,"end_character":38},"updated":"2017-03-15 09:19:11.000000000","message":"would you mind adding another test for this function passing a more complex json?\n\nI looked for such test in this file, but couldn\u0027t find one.\n\nI was thinking passing a call like one with a parameter that is a dict itself and also maybe a string containing \u0027\u003d\u0027.","commit_id":"97311a6c04eba447b0d1cf829cda69471dea9e81"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"edfff07bfcf8b60cc109083ac324e1dee8444d41","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \u0027param2\u0027: 2,"},{"line_number":117,"context_line":"                \u0027param3\u0027: \u0027var3\u0027"},{"line_number":118,"context_line":"            },"},{"line_number":119,"context_line":"            utils.get_dict_from_string(\u0027param1, param2\u003d2, param3\u003d\"var3\"\u0027)"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self.assertDictEqual({}, utils.get_dict_from_string(\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_c59fb15d","line":119,"range":{"start_line":119,"start_character":18,"end_line":119,"end_character":38},"in_reply_to":"3a1ff146_52ab8589","updated":"2017-03-15 10:47:59.000000000","message":"Ooh, I now see what you\u0027re saying. The method actually uses json.loads() so it can be more complicated stuff actually. Would you mind if I add more tests in a separate patch?","commit_id":"97311a6c04eba447b0d1cf829cda69471dea9e81"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"102bb58b7b75bc5a78bc51bc7dbdf98291c31a16","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \u0027param2\u0027: 2,"},{"line_number":117,"context_line":"                \u0027param3\u0027: \u0027var3\u0027"},{"line_number":118,"context_line":"            },"},{"line_number":119,"context_line":"            utils.get_dict_from_string(\u0027param1, param2\u003d2, param3\u003d\"var3\"\u0027)"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self.assertDictEqual({}, utils.get_dict_from_string(\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_52ab8589","line":119,"range":{"start_line":119,"start_character":18,"end_line":119,"end_character":38},"in_reply_to":"3a1ff146_82993271","updated":"2017-03-15 10:25:46.000000000","message":"Well, I don\u0027t think that this method was designed for taking care of more complex scenarios where, for example, an entry value can be a dict itself. It\u0027s just a simple parser of key-value pairs with the ability to put NotDefied as a value for the entries which don\u0027t have explicit values.\n\nOr maybe I just didn\u0027t get your point. Please let me know what you think.","commit_id":"97311a6c04eba447b0d1cf829cda69471dea9e81"}]}