)]}'
{"mistral/actions/openstack/actions.py":[{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"bb4da066a9b6f9d5796e3c8c6143284451a8034e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        glance_endpoint \u003d self.get_service_endpoint()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return self._get_client_class()("},{"line_number":104,"context_line":"            glance_endpoint.url,"},{"line_number":105,"context_line":"            region_name\u003dglance_endpoint.region,"},{"line_number":106,"context_line":"            **self.get_session_and_auth(context)"},{"line_number":107,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f3b32209","line":104,"updated":"2017-06-26 06:23:28.000000000","message":"I think so we don\u0027t need url and region again.\n\nPlus I don\u0027t know how this and old code could work due to signature of glanceclient is quite different:\n\ndef Client(version\u003dNone, endpoint\u003dNone, session\u003dNone, *args, **kwargs):\n\nSee:\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/client.py#L23","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"52cc4a4c7fa77eaf9dadef68404213bc8cb2546f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        glance_endpoint \u003d self.get_service_endpoint()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return self._get_client_class()("},{"line_number":104,"context_line":"            glance_endpoint.url,"},{"line_number":105,"context_line":"            region_name\u003dglance_endpoint.region,"},{"line_number":106,"context_line":"            **self.get_session_and_auth(context)"},{"line_number":107,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f680b0c1","line":104,"in_reply_to":"5f201791_f3b32209","updated":"2017-06-26 07:24:58.000000000","message":"You may be right but I tested it locally with an Ocata cloud and image listing works perfectly. I\u0027ll look into it.","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"bb4da066a9b6f9d5796e3c8c6143284451a8034e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        LOG.debug(\"Keystone action security context: %s\" % context)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        kwargs \u003d self.get_session_and_auth(context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        client \u003d self._get_client_class()(**kwargs)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f3a8c28c","line":126,"updated":"2017-06-26 06:23:28.000000000","message":"It could be a one-liner.","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"bb4da066a9b6f9d5796e3c8c6143284451a8034e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        return self._get_client_class()("},{"line_number":199,"context_line":"            endpoint_url,"},{"line_number":200,"context_line":"            region_name\u003dheat_endpoint.region,"},{"line_number":201,"context_line":"            **self.get_session_and_auth(context)"},{"line_number":202,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_9393ce5b","line":199,"updated":"2017-06-26 06:23:28.000000000","message":"Do we really need endpoint and region again?","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"52cc4a4c7fa77eaf9dadef68404213bc8cb2546f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        return self._get_client_class()("},{"line_number":199,"context_line":"            endpoint_url,"},{"line_number":200,"context_line":"            region_name\u003dheat_endpoint.region,"},{"line_number":201,"context_line":"            **self.get_session_and_auth(context)"},{"line_number":202,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_b657d858","line":199,"in_reply_to":"5f201791_9393ce5b","updated":"2017-06-26 07:24:58.000000000","message":"Based on the experience with the Mistral client, it\u0027s better to stay on the safe side. :)","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"bb4da066a9b6f9d5796e3c8c6143284451a8034e","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        session_and_auth \u003d self.get_session_and_auth(context)"},{"line_number":283,"context_line":"        return self._get_client_class()("},{"line_number":284,"context_line":"            mistral_url\u003dsession_and_auth[\u0027auth\u0027].endpoint,"},{"line_number":285,"context_line":"            **session_and_auth"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_5399b676","line":284,"updated":"2017-06-26 06:23:28.000000000","message":"Do we reaaly need endpoint again?","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"52cc4a4c7fa77eaf9dadef68404213bc8cb2546f","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        session_and_auth \u003d self.get_session_and_auth(context)"},{"line_number":283,"context_line":"        return self._get_client_class()("},{"line_number":284,"context_line":"            mistral_url\u003dsession_and_auth[\u0027auth\u0027].endpoint,"},{"line_number":285,"context_line":"            **session_and_auth"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_96d97cf4","line":284,"in_reply_to":"5f201791_5399b676","updated":"2017-06-26 07:24:58.000000000","message":"Yes. The Mistral client needs to be updated to work correctly with sessions. Hopefully, the ongoing keystoneauth update will help (https://review.openstack.org/#/c/455174/)","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"}],"mistral/services/triggers.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"052695cf702e58545f3919a0a1942484788861a4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            wf_spec.__class__.__name__"},{"line_number":109,"context_line":"        )"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        trigger_parameters \u003d {"},{"line_number":112,"context_line":"            \u0027name\u0027: name,"},{"line_number":113,"context_line":"            \u0027pattern\u0027: pattern,"},{"line_number":114,"context_line":"            \u0027first_execution_time\u0027: first_time,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_7948115b","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":26},"updated":"2017-06-26 07:42:07.000000000","message":"Soft: the change is ok but we usually use \"values\" instead of parameters across the code when we mean \"a dictionary representing an object\". A little bit inconsistent with the rest of the code. And also we usually use short \"params\" instead of full \"parameters\" if it\u0027s a variable and not part of a function name.\n\nAnyway, I won\u0027t be arguing much about style things like that. It\u0027s counterproductive. Just noticing..","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"6fa22f14861ec536e65734598ad53350dec1a97d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            wf_spec.__class__.__name__"},{"line_number":109,"context_line":"        )"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        trigger_parameters \u003d {"},{"line_number":112,"context_line":"            \u0027name\u0027: name,"},{"line_number":113,"context_line":"            \u0027pattern\u0027: pattern,"},{"line_number":114,"context_line":"            \u0027first_execution_time\u0027: first_time,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_b96af216","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":26},"in_reply_to":"5f201791_7948115b","updated":"2017-06-27 15:04:57.000000000","message":"Done. You know I believe that the IDE is for typing out stuff for me. But I obey the customs. :)","commit_id":"7741aac2fe44f612df04552f0635dddab33bf2f3"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"918857bfb306d94104ecf7662428a88c9a685016","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_system_ca_file():"},{"line_number":43,"context_line":"    \"\"\"Return path to system default CA file.\"\"\""},{"line_number":44,"context_line":"    # Standard CA file locations for Debian/Ubuntu, RedHat/Fedora,"},{"line_number":45,"context_line":"    # Suse, FreeBSD/OpenBSD, MacOSX, and the bundled ca"},{"line_number":46,"context_line":"    ca_path \u003d [\u0027/etc/ssl/certs/ca-certificates.crt\u0027,"},{"line_number":47,"context_line":"               \u0027/etc/pki/tls/certs/ca-bundle.crt\u0027,"},{"line_number":48,"context_line":"               \u0027/etc/ssl/ca-bundle.pem\u0027,"},{"line_number":49,"context_line":"               \u0027/etc/ssl/cert.pem\u0027,"},{"line_number":50,"context_line":"               \u0027/System/Library/OpenSSL/certs/cacert.pem\u0027,"},{"line_number":51,"context_line":"               requests.certs.where()]"},{"line_number":52,"context_line":"    for ca in ca_path:"},{"line_number":53,"context_line":"        LOG.debug(\"Looking for ca file %s\", ca)"},{"line_number":54,"context_line":"        if os.path.exists(ca):"},{"line_number":55,"context_line":"            LOG.debug(\"Using ca file %s\", ca)"},{"line_number":56,"context_line":"            return ca"},{"line_number":57,"context_line":"    LOG.warning(\"System ca file could not be found.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"SYSTEM_CA_FILE \u003d get_system_ca_file()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_9d608937","line":59,"range":{"start_line":43,"start_character":0,"end_line":59,"end_character":15},"updated":"2017-03-20 08:08:16.000000000","message":"using a standard keystone session, this should have been already handled by python-requests. Why is this needed?","commit_id":"fc45cb72fc2d7df43a91543885aed3bee5e6085b"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"5b4e2e494286f552ad1765d46fac3e876c9f300f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_system_ca_file():"},{"line_number":43,"context_line":"    \"\"\"Return path to system default CA file.\"\"\""},{"line_number":44,"context_line":"    # Standard CA file locations for Debian/Ubuntu, RedHat/Fedora,"},{"line_number":45,"context_line":"    # Suse, FreeBSD/OpenBSD, MacOSX, and the bundled ca"},{"line_number":46,"context_line":"    ca_path \u003d [\u0027/etc/ssl/certs/ca-certificates.crt\u0027,"},{"line_number":47,"context_line":"               \u0027/etc/pki/tls/certs/ca-bundle.crt\u0027,"},{"line_number":48,"context_line":"               \u0027/etc/ssl/ca-bundle.pem\u0027,"},{"line_number":49,"context_line":"               \u0027/etc/ssl/cert.pem\u0027,"},{"line_number":50,"context_line":"               \u0027/System/Library/OpenSSL/certs/cacert.pem\u0027,"},{"line_number":51,"context_line":"               requests.certs.where()]"},{"line_number":52,"context_line":"    for ca in ca_path:"},{"line_number":53,"context_line":"        LOG.debug(\"Looking for ca file %s\", ca)"},{"line_number":54,"context_line":"        if os.path.exists(ca):"},{"line_number":55,"context_line":"            LOG.debug(\"Using ca file %s\", ca)"},{"line_number":56,"context_line":"            return ca"},{"line_number":57,"context_line":"    LOG.warning(\"System ca file could not be found.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"SYSTEM_CA_FILE \u003d get_system_ca_file()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_002432ad","line":59,"range":{"start_line":43,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"1a1ced50_9d608937","updated":"2017-03-20 08:15:42.000000000","message":"Yes, I just copied it from heatclient, but this shall be removed.","commit_id":"fc45cb72fc2d7df43a91543885aed3bee5e6085b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"918857bfb306d94104ecf7662428a88c9a685016","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    LOG.debug(\"Action security context for %s project: %s\" % (project, ctx))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    nova_endpoint \u003d get_endpoint_for_project(project)"},{"line_number":237,"context_line":"    endpoint \u003d format_url("},{"line_number":238,"context_line":"        nova_endpoint.url,"},{"line_number":239,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_fd5dfd79","line":236,"range":{"start_line":236,"start_character":4,"end_line":236,"end_character":17},"updated":"2017-03-20 08:08:16.000000000","message":"??","commit_id":"fc45cb72fc2d7df43a91543885aed3bee5e6085b"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"5b4e2e494286f552ad1765d46fac3e876c9f300f","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    LOG.debug(\"Action security context for %s project: %s\" % (project, ctx))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    nova_endpoint \u003d get_endpoint_for_project(project)"},{"line_number":237,"context_line":"    endpoint \u003d format_url("},{"line_number":238,"context_line":"        nova_endpoint.url,"},{"line_number":239,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_6035e6d8","line":236,"range":{"start_line":236,"start_character":4,"end_line":236,"end_character":17},"in_reply_to":"1a1ced50_fd5dfd79","updated":"2017-03-20 08:15:42.000000000","message":"It is copied from nova actions...","commit_id":"fc45cb72fc2d7df43a91543885aed3bee5e6085b"}]}
