)]}'
{"mistral/engine/workflow_handler.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"28775277f789fa01e251245ccc3834cd847f8a0c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        pause_workflow(wf_ex, msg)"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        raise exc.MistralError("},{"line_number":157,"context_line":"            \u0027Invalid workflow execution state [wf_ex_id\u003d%s, state\u003d%s]\u0027 %"},{"line_number":158,"context_line":"            (wf_ex.id, state)"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_0e3dc8ba","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":55},"updated":"2017-03-24 04:39:31.000000000","message":"Lingxian, I can\u0027t really agree with this change. What use can we make of just execution id? If we look at such a log we can\u0027t be sure what we\u0027re looking at. I came across this when debugging myself. At least, we should always print id and name, ideally also input (maybe shrinked by utils.cut()) in order to quickly identify what it is. IMO, you\u0027re oversimplifying log statements.","commit_id":"0eb751a902372b19c2a8493e86059773c191881f"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"d0af516d1e622d5ac95f8c9b82859cd0bc84a2de","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        pause_workflow(wf_ex, msg)"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        raise exc.MistralError("},{"line_number":157,"context_line":"            \u0027Invalid workflow execution state [wf_ex_id\u003d%s, state\u003d%s]\u0027 %"},{"line_number":158,"context_line":"            (wf_ex.id, state)"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_eb2728b6","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":55},"in_reply_to":"ffe62b97_0e3dc8ba","updated":"2017-03-24 10:47:48.000000000","message":"Hmm...then I prefer we specify some information to print in the log. I don\u0027t like utils.cut() because it doesn\u0027t consider importance level of the data and just cut from the beginning.\n\nFor me, I always use log together with CLI to get more details :)","commit_id":"0eb751a902372b19c2a8493e86059773c191881f"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"8e62994fb54493a235ccf35f4030d89e9889816f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        pause_workflow(wf_ex, msg)"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        raise exc.MistralError("},{"line_number":157,"context_line":"            \u0027Invalid workflow execution state [wf_ex_id\u003d%s, state\u003d%s]\u0027 %"},{"line_number":158,"context_line":"            (wf_ex.id, state)"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4b85f4ac","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":55},"in_reply_to":"ffe62b97_4b529469","updated":"2017-03-24 11:07:49.000000000","message":"Sure","commit_id":"0eb751a902372b19c2a8493e86059773c191881f"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d55fd5d1a08cf70d2e234c382da5a3cba1a093db","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        pause_workflow(wf_ex, msg)"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        raise exc.MistralError("},{"line_number":157,"context_line":"            \u0027Invalid workflow execution state [wf_ex_id\u003d%s, state\u003d%s]\u0027 %"},{"line_number":158,"context_line":"            (wf_ex.id, state)"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4b529469","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":55},"in_reply_to":"ffe62b97_eb2728b6","updated":"2017-03-24 11:06:19.000000000","message":"Ok, let\u0027s include at least id and name everywhere. Can you do it?","commit_id":"0eb751a902372b19c2a8493e86059773c191881f"}]}
