)]}'
{"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d656f79a6ec2eacb4497e5527469cf6e0d016123","unresolved":false,"context_lines":[{"line_number":738,"context_line":"def get_workflow_execution(id, session\u003dNone):"},{"line_number":739,"context_line":"    ctx \u003d context.ctx()"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    wf_ex \u003d _get_db_object_by_name_or_id("},{"line_number":742,"context_line":"        models.WorkflowExecution,"},{"line_number":743,"context_line":"        id,"},{"line_number":744,"context_line":"        insecure\u003dctx.is_admin"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_72aa94d2","line":741,"range":{"start_line":741,"start_character":12,"end_line":741,"end_character":40},"updated":"2017-04-04 06:26:57.000000000","message":"I assume this is a slight performance regression because a DB query with just one parameter id should work faster. Can we just add this logic related to \u0027insecure\u0027 into _get_db_object_by_id instead?","commit_id":"ff76a8cca30a91a2f90d93aabd9a887b8975b35c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0286c4cfb6bf9f1e4b2e528329009428c88eb45d","unresolved":false,"context_lines":[{"line_number":738,"context_line":"def get_workflow_execution(id, session\u003dNone):"},{"line_number":739,"context_line":"    ctx \u003d context.ctx()"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    wf_ex \u003d _get_db_object_by_name_or_id("},{"line_number":742,"context_line":"        models.WorkflowExecution,"},{"line_number":743,"context_line":"        id,"},{"line_number":744,"context_line":"        insecure\u003dctx.is_admin"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_a5f68ff8","line":741,"range":{"start_line":741,"start_character":12,"end_line":741,"end_character":40},"in_reply_to":"dfeb2761_72aa94d2","updated":"2017-04-04 09:44:47.000000000","message":"Hi, Renat, that\u0027s why I asked you today about deprecating using name in the URL. e.g. we still support get workflow definition by specifying workflow name, the api layer will call get_workflow_execution() using the name instead of ID. That\u0027s the reason that we maintain _get_db_object_by_name_or_id() method in db layer.","commit_id":"ff76a8cca30a91a2f90d93aabd9a887b8975b35c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b1364ba692116507921fd36a278156874062c1e5","unresolved":false,"context_lines":[{"line_number":738,"context_line":"def get_workflow_execution(id, session\u003dNone):"},{"line_number":739,"context_line":"    ctx \u003d context.ctx()"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    wf_ex \u003d _get_db_object_by_name_or_id("},{"line_number":742,"context_line":"        models.WorkflowExecution,"},{"line_number":743,"context_line":"        id,"},{"line_number":744,"context_line":"        insecure\u003dctx.is_admin"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_e03125a4","line":741,"range":{"start_line":741,"start_character":12,"end_line":741,"end_character":40},"in_reply_to":"dfeb2761_a5f68ff8","updated":"2017-04-04 10:15:43.000000000","message":"I know, yes. I just think that we\u0027ll have to support both methods for the time being.","commit_id":"ff76a8cca30a91a2f90d93aabd9a887b8975b35c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6d5c8aa975851e2a9affe9ae5642d7f3ef028511","unresolved":false,"context_lines":[{"line_number":738,"context_line":"def get_workflow_execution(id, session\u003dNone):"},{"line_number":739,"context_line":"    ctx \u003d context.ctx()"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    wf_ex \u003d _get_db_object_by_name_or_id("},{"line_number":742,"context_line":"        models.WorkflowExecution,"},{"line_number":743,"context_line":"        id,"},{"line_number":744,"context_line":"        insecure\u003dctx.is_admin"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_0096174d","line":741,"range":{"start_line":741,"start_character":12,"end_line":741,"end_character":40},"in_reply_to":"dfeb2761_e03125a4","updated":"2017-04-05 11:41:16.000000000","message":"ooh, now I know, I have \u0027workflow definition\u0027 instead of \u0027workflow execution\u0027 in my mind when I was writing the code. So, for workflow execution, we only support ID.","commit_id":"ff76a8cca30a91a2f90d93aabd9a887b8975b35c"}],"mistral/tests/unit/db/v2/test_locking.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d656f79a6ec2eacb4497e5527469cf6e0d016123","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _run_correct_locking(self, wf_ex):"},{"line_number":93,"context_line":"        # Set context info for the thread."},{"line_number":94,"context_line":"        ctx \u003d test_base.get_context()"},{"line_number":95,"context_line":"        auth_context.set_ctx(ctx)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self._random_sleep()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_929878c0","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":11},"updated":"2017-04-04 06:26:57.000000000","message":"Soft: please inline this variable.","commit_id":"ff76a8cca30a91a2f90d93aabd9a887b8975b35c"}]}