)]}'
{"mistral/config.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"020bee90e276737ee496e6fd28835458c2b674fe","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    cfg.StrOpt("},{"line_number":173,"context_line":"        \u0027type\u0027,"},{"line_number":174,"context_line":"        default\u003d\u0027remote\u0027,"},{"line_number":175,"context_line":"        help\u003d\u0027Type of executor.\u0027"},{"line_number":176,"context_line":"    ),"},{"line_number":177,"context_line":"    cfg.StrOpt("},{"line_number":178,"context_line":"        \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_ba169e54","line":175,"range":{"start_line":175,"start_character":14,"end_line":175,"end_character":30},"updated":"2017-04-10 04:57:04.000000000","message":"I think we need to list all available options here.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"6adb87d5f5126e5e5b5492d46ea29df582f43bad","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    cfg.StrOpt("},{"line_number":173,"context_line":"        \u0027type\u0027,"},{"line_number":174,"context_line":"        default\u003d\u0027remote\u0027,"},{"line_number":175,"context_line":"        help\u003d\u0027Type of executor.\u0027"},{"line_number":176,"context_line":"    ),"},{"line_number":177,"context_line":"    cfg.StrOpt("},{"line_number":178,"context_line":"        \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_abc40b92","line":175,"range":{"start_line":175,"start_character":14,"end_line":175,"end_character":30},"in_reply_to":"bff0334d_ba169e54","updated":"2017-04-10 11:09:59.000000000","message":"I agree with Renat, we have to let people know what choices they have.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4087d139858e9ba67fff5e2ccae524eb1ff1544d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \u0027type\u0027,"},{"line_number":174,"context_line":"        choices\u003d[\u0027local\u0027, \u0027remote\u0027],"},{"line_number":175,"context_line":"        default\u003d\u0027remote\u0027,"},{"line_number":176,"context_line":"        help\u003d\u0027Type of executor.\u0027"},{"line_number":177,"context_line":"    ),"},{"line_number":178,"context_line":"    cfg.StrOpt("},{"line_number":179,"context_line":"        \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_f51c806b","line":176,"updated":"2017-04-25 11:12:52.000000000","message":"Can we explain what the difference is in the help message?","commit_id":"a838e67110bf87311de6931c3ca417d51a344944"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"aa5e730a84dba9e7b011675b3a4d8fd0a43294b5","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \u0027type\u0027,"},{"line_number":174,"context_line":"        choices\u003d[\u0027local\u0027, \u0027remote\u0027],"},{"line_number":175,"context_line":"        default\u003d\u0027remote\u0027,"},{"line_number":176,"context_line":"        help\u003d\u0027Type of executor.\u0027"},{"line_number":177,"context_line":"    ),"},{"line_number":178,"context_line":"    cfg.StrOpt("},{"line_number":179,"context_line":"        \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_4bec4d8e","line":176,"in_reply_to":"5ff73747_f51c806b","updated":"2017-04-27 19:01:28.000000000","message":"Sure.... This patch is stuck for a week waiting for another approver and I\u0027m -1 for something like this... Let\u0027s see how long this patch is going to get stuck in the pipeline...","commit_id":"a838e67110bf87311de6931c3ca417d51a344944"}],"mistral/engine/rpc_backend/rpc.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"713d0d3de528de41c330e92c2d83c8551b2bba9b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from mistral import context as auth_ctx"},{"line_number":25,"context_line":"from mistral.engine import base as eng"},{"line_number":26,"context_line":"from mistral import exceptions as exc"},{"line_number":27,"context_line":"from mistral.executors import base as exe"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_4f86e6dd","line":27,"range":{"start_line":27,"start_character":38,"end_line":27,"end_character":41},"updated":"2017-04-25 23:33:22.000000000","message":"I don\u0027t like both of the alias names, can you use engine_base and executors_base or something else similar to make the code more readable?","commit_id":"a838e67110bf87311de6931c3ca417d51a344944"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e158f34fe135cd13748ed9175c508339e842692c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from mistral import context as auth_ctx"},{"line_number":25,"context_line":"from mistral.engine import base as eng"},{"line_number":26,"context_line":"from mistral import exceptions as exc"},{"line_number":27,"context_line":"from mistral.executors import base as exe"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_fc2b292d","line":27,"range":{"start_line":27,"start_character":38,"end_line":27,"end_character":41},"in_reply_to":"5ff73747_4f86e6dd","updated":"2017-04-26 05:02:03.000000000","message":"I\u0027m usually in favor of using shorter names so I\u0027d be ok with what Winson proposed but also would not be against of renaming.","commit_id":"a838e67110bf87311de6931c3ca417d51a344944"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"aa5e730a84dba9e7b011675b3a4d8fd0a43294b5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from mistral import context as auth_ctx"},{"line_number":25,"context_line":"from mistral.engine import base as eng"},{"line_number":26,"context_line":"from mistral import exceptions as exc"},{"line_number":27,"context_line":"from mistral.executors import base as exe"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_4ba1ed45","line":27,"range":{"start_line":27,"start_character":38,"end_line":27,"end_character":41},"in_reply_to":"5ff73747_fc2b292d","updated":"2017-04-27 19:01:28.000000000","message":"I\u0027m going to stick with eng and exe. I prefer short clean alias. There\u0027re plenty of other short alias thru out the code.  It\u0027s a matter of preference here.","commit_id":"a838e67110bf87311de6931c3ca417d51a344944"}],"mistral/executors/base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"020bee90e276737ee496e6fd28835458c2b674fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from stevedore import driver"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"_IMPL_EXEC_HANDLERS \u003d {}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def cleanup():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_0d01d605","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":19},"updated":"2017-04-10 04:57:04.000000000","message":"Why not just _EXECUTORS?","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"}],"mistral/executors/default.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"6adb87d5f5126e5e5b5492d46ea29df582f43bad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 - Mirantis, Inc."},{"line_number":2,"context_line":"# Copyright 2016 - Brocade Communications Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_cb962f4d","line":1,"updated":"2017-04-10 11:09:59.000000000","message":"Soft: this file should me named \u0027default_executor\u0027.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"}],"mistral/executors/remote.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"020bee90e276737ee496e6fd28835458c2b674fe","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_ad242ab0","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"updated":"2017-04-10 04:57:04.000000000","message":"Although I understand the logic of the naming it slightly bothers me that now we don\u0027t have \"local\" and \"remote\" executors which would be symmetric. And we also don\u0027t have symmetry with e.g. Engine and EngineClient.\n\nWhat if we keep DefaultExecutor and ExecutorClient and just create an alias called RemoteExecutor? Or we can just reference ExecutorClient as \u0027remote\u0027. I also don\u0027t quite like that part of the clients are left in rpc.py and the client for executor has been moved to a different place. Maybe we could move engine client and engine event client to their own places too? Closer to Engine and EventEngine (not necessarily in this patch)\n\nWhat do you think?\n\nJust a note: I totally agree that executors need to be in their own package \u0027executors\u0027, this is a good idea IMO.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"461a1fd68653195fab4a98ed5efca07c186cf711","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_63f70a8d","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"in_reply_to":"bff0334d_147d196d","updated":"2017-04-11 22:42:14.000000000","message":"Revisiting the rpc_backend implementation in the engine module, IMO, it looks like there\u0027s inconsistency in the location of the rpc_backend in general. The rpc_backend for oslo and kombu should have been outside of the engine module. Since there\u0027s an event_engine module already, the associated rpc classes for event_engine should have been moved there. So, given I\u0027m making changes to separate executors, I\u0027ll also deconstruct the rpc_backends and migrate them appropriately.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"0b93dc15ac3c980f079362e522893e30c6f24e54","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_05438243","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"in_reply_to":"bff0334d_1a2bf882","updated":"2017-04-12 16:35:31.000000000","message":"I started down the path to have the RemoteExecutor inherit from the ExecutorClient. And with the executors separated into different module already. I\u0027ve proceeded to split out the rpc backends and the rpc for engine and event_engine in this patch.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b4297eff776866cd3f6d3f46cbcce192733c43f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_1a2bf882","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"in_reply_to":"bff0334d_63f70a8d","updated":"2017-04-12 04:57:23.000000000","message":"Ok Winson, no problem. I agree that rpc_backend/rpc.py needs to be split into different modules. You can actually do it in a separate patch if you want. As far as symmetry with Engine it was rather a doubt than a strong opinion.\n\nWhat would you prefer? To make these changes in this patch or in a new patch?","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"6adb87d5f5126e5e5b5492d46ea29df582f43bad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_2b323b60","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"in_reply_to":"bff0334d_ad242ab0","updated":"2017-04-10 11:09:59.000000000","message":"+1","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"15da1e1ef572516c446adee6dbeb5f83b99c8da7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class RemoteExecutor(base.Executor):"},{"line_number":28,"context_line":"    \"\"\"RPC Executor client.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_147d196d","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"in_reply_to":"bff0334d_ad242ab0","updated":"2017-04-11 19:59:51.000000000","message":"We\u0027ve separated the executors into a different module and if you haven\u0027t noticed, by moving the executors as stevedore extensions, we\u0027ve now allow the possibility for 3rd party executors. I don\u0027t think it\u0027s necessary to get hung up on the engine symmetry here. It just so happens that the remote executor implementation is similar to the RPC engine and engine client. If it helps you, I\u0027ll put the ExecutorClient in the executors module and have RemoteExecutor inherit from it. But I think it\u0027ll make the executors module unnecessary messy.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"}],"mistral/tests/unit/engine/base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"020bee90e276737ee496e6fd28835458c2b674fe","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.threads \u003d []"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Start remote executor"},{"line_number":66,"context_line":"        if cfg.CONF.executor.type \u003d\u003d \u0027remote\u0027:"},{"line_number":67,"context_line":"            LOG.info(\"Starting remote executor threads...\")"},{"line_number":68,"context_line":"            self.executor_client \u003d exe.RemoteExecutor()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_8d42863d","line":65,"updated":"2017-04-10 04:57:04.000000000","message":"Soft: missing period.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"020bee90e276737ee496e6fd28835458c2b674fe","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            self.threads.append(eventlet.spawn(launch_service, exe_svc))"},{"line_number":72,"context_line":"            self.addCleanup(exe_svc.stop, True)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Start engine"},{"line_number":75,"context_line":"        LOG.info(\"Starting engine threads...\")"},{"line_number":76,"context_line":"        self.engine_client \u003d rpc.get_engine_client()"},{"line_number":77,"context_line":"        eng_svc \u003d engine_server.get_oslo_service(setup_profiler\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_6d3f42b4","line":74,"updated":"2017-04-10 04:57:04.000000000","message":"Soft: missing period.","commit_id":"9a3680f6b0ed08a93865429ac17bee5e6ad95ddc"}]}
