)]}'
{"mistral/api/controllers/v2/action_execution.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from mistral.workflow import states"},{"line_number":31,"context_line":"from mistral.workflow import utils as wf_utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo_context import context as o_context"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_e58de8d3","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":45},"updated":"2017-05-19 02:24:43.000000000","message":"wrong import section, should move it to line 17.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"}],"mistral/config.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"81b4e863e07c39436b4f6a34669cac63501219fd","unresolved":false,"context_lines":[{"line_number":321,"context_line":"EXECUTION_EXPIRATION_POLICY_GROUP \u003d \u0027execution_expiration_policy\u0027"},{"line_number":322,"context_line":"PROFILER_GROUP \u003d profiler.list_opts()[0][0]"},{"line_number":323,"context_line":"KEYCLOAK_OIDC_GROUP \u003d \"keycloak_oidc\""},{"line_number":324,"context_line":"OPENSTACK_ACTIONS_GROUP \u003d \u0027openstack_actions\u0027"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"CONF.register_opt(wf_trace_log_name_opt)"},{"line_number":327,"context_line":"CONF.register_opt(auth_type_opt)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff0f0b1f_f6d25934","side":"PARENT","line":324,"updated":"2017-05-18 12:54:54.000000000","message":"The error I see is \"oslo_config.cfg.NoSuchOptError: no such option openstack_actions in group [DEFAULT]\"\n\nIt looks like this was removed, or renamed to just \"clients\" here - why rename it?","commit_id":"5a10c521d5e13aef00e629e6d68532416aa6650b"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    help\u003d_(\u0027Seconds to wait for a response from a call.\u0027)"},{"line_number":107,"context_line":")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"os_endpoint_type \u003d cfg.StrOpt("},{"line_number":110,"context_line":"    \u0027os-actions-endpoint-type\u0027,"},{"line_number":111,"context_line":"    default\u003dos.environ.get(\u0027OS_ACTIONS_ENDPOINT_TYPE\u0027, \u0027public\u0027),"},{"line_number":112,"context_line":"    choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_e5fde8b1","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":16},"updated":"2017-05-19 02:24:43.000000000","message":"this option has been moved to \u0027openstack_actions\u0027 group.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    help\u003d_(\u0027Seconds to wait for a response from a call.\u0027)"},{"line_number":107,"context_line":")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"os_endpoint_type \u003d cfg.StrOpt("},{"line_number":110,"context_line":"    \u0027os-actions-endpoint-type\u0027,"},{"line_number":111,"context_line":"    default\u003dos.environ.get(\u0027OS_ACTIONS_ENDPOINT_TYPE\u0027, \u0027public\u0027),"},{"line_number":112,"context_line":"    choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_f11a07ca","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":16},"in_reply_to":"ff0f0b1f_e5fde8b1","updated":"2017-05-22 15:24:15.000000000","message":"Well, this one is not from my patch. I just rebase on top of it","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    )"},{"line_number":307,"context_line":"]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"clients_opts \u003d ["},{"line_number":310,"context_line":"    cfg.StrOpt("},{"line_number":311,"context_line":"        \u0027auth_uri\u0027,"},{"line_number":312,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":313,"context_line":"        help\u003d_(\u0027Unversioned keystone url in format like\u0027"},{"line_number":314,"context_line":"                \u0027http://0.0.0.0:5000.\u0027)"},{"line_number":315,"context_line":"    ),"},{"line_number":316,"context_line":"    cfg.StrOpt("},{"line_number":317,"context_line":"        \u0027ca_file\u0027,"},{"line_number":318,"context_line":"        help\u003d_(\u0027Optional CA cert file to use in SSL connections.\u0027)"},{"line_number":319,"context_line":"    ),"},{"line_number":320,"context_line":"    cfg.StrOpt("},{"line_number":321,"context_line":"        \u0027cert_file\u0027,"},{"line_number":322,"context_line":"        help\u003d_(\u0027Optional PEM-formatted certificate chain file.\u0027)"},{"line_number":323,"context_line":"    ),"},{"line_number":324,"context_line":"    cfg.StrOpt("},{"line_number":325,"context_line":"        \u0027key_file\u0027,"},{"line_number":326,"context_line":"        help\u003d_(\u0027Optional PEM-formatted file that contains the\u0027"},{"line_number":327,"context_line":"               \u0027private key.\u0027)"},{"line_number":328,"context_line":"    ),"},{"line_number":329,"context_line":"    cfg.BoolOpt("},{"line_number":330,"context_line":"        \u0027insecure\u0027,"},{"line_number":331,"context_line":"        default\u003dFalse,"},{"line_number":332,"context_line":"        help\u003d_(\"If set, then the server\u0027s certificate will not\""},{"line_number":333,"context_line":"               \"be verified.\")"},{"line_number":334,"context_line":"    )"},{"line_number":335,"context_line":"]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"# note: this command line option is used only from sync_db and"},{"line_number":338,"context_line":"# mistral-db-manage"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_251d200f","line":335,"range":{"start_line":309,"start_character":0,"end_line":335,"end_character":1},"updated":"2017-05-19 02:24:43.000000000","message":"why not move those options to \u0027openstack_actions\u0027 group because they are all related to openstack integration IMO.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    )"},{"line_number":307,"context_line":"]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"clients_opts \u003d ["},{"line_number":310,"context_line":"    cfg.StrOpt("},{"line_number":311,"context_line":"        \u0027auth_uri\u0027,"},{"line_number":312,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":313,"context_line":"        help\u003d_(\u0027Unversioned keystone url in format like\u0027"},{"line_number":314,"context_line":"                \u0027http://0.0.0.0:5000.\u0027)"},{"line_number":315,"context_line":"    ),"},{"line_number":316,"context_line":"    cfg.StrOpt("},{"line_number":317,"context_line":"        \u0027ca_file\u0027,"},{"line_number":318,"context_line":"        help\u003d_(\u0027Optional CA cert file to use in SSL connections.\u0027)"},{"line_number":319,"context_line":"    ),"},{"line_number":320,"context_line":"    cfg.StrOpt("},{"line_number":321,"context_line":"        \u0027cert_file\u0027,"},{"line_number":322,"context_line":"        help\u003d_(\u0027Optional PEM-formatted certificate chain file.\u0027)"},{"line_number":323,"context_line":"    ),"},{"line_number":324,"context_line":"    cfg.StrOpt("},{"line_number":325,"context_line":"        \u0027key_file\u0027,"},{"line_number":326,"context_line":"        help\u003d_(\u0027Optional PEM-formatted file that contains the\u0027"},{"line_number":327,"context_line":"               \u0027private key.\u0027)"},{"line_number":328,"context_line":"    ),"},{"line_number":329,"context_line":"    cfg.BoolOpt("},{"line_number":330,"context_line":"        \u0027insecure\u0027,"},{"line_number":331,"context_line":"        default\u003dFalse,"},{"line_number":332,"context_line":"        help\u003d_(\"If set, then the server\u0027s certificate will not\""},{"line_number":333,"context_line":"               \"be verified.\")"},{"line_number":334,"context_line":"    )"},{"line_number":335,"context_line":"]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"# note: this command line option is used only from sync_db and"},{"line_number":338,"context_line":"# mistral-db-manage"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_11645b49","line":335,"range":{"start_line":309,"start_character":0,"end_line":335,"end_character":1},"in_reply_to":"ff0f0b1f_251d200f","updated":"2017-05-22 15:24:15.000000000","message":"Yep, good point. And i think i will remove this one from this patch since it does not connect to the topic.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":374,"context_line":"CONF.register_opts(pecan_opts, group\u003dPECAN_GROUP)"},{"line_number":375,"context_line":"CONF.register_opts(coordination_opts, group\u003dCOORDINATION_GROUP)"},{"line_number":376,"context_line":"CONF.register_opts(profiler_opts, group\u003dPROFILER_GROUP)"},{"line_number":377,"context_line":"CONF.register_opt(js_impl_opt)"},{"line_number":378,"context_line":"CONF.register_opt(rpc_impl_opt)"},{"line_number":379,"context_line":"CONF.register_opt(rpc_response_timeout_opt)"},{"line_number":380,"context_line":"CONF.register_opts(keycloak_oidc_opts, group\u003dKEYCLOAK_OIDC_GROUP)"},{"line_number":381,"context_line":"CONF.register_opt(os_endpoint_type)"},{"line_number":382,"context_line":"CONF.register_opt(expiration_token_duration)"},{"line_number":383,"context_line":"CONF.register_opts(clients_opts, group\u003dCLIENTS_GROUP)"},{"line_number":384,"context_line":"CONF.register_opts(openstack_actions_opts, group\u003dOPENSTACK_ACTIONS_GROUP)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_25e2c002","line":383,"range":{"start_line":377,"start_character":0,"end_line":383,"end_character":53},"updated":"2017-05-19 02:24:43.000000000","message":"Is there a particular reason that you mix the single options with options belonging to groups?","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":374,"context_line":"CONF.register_opts(pecan_opts, group\u003dPECAN_GROUP)"},{"line_number":375,"context_line":"CONF.register_opts(coordination_opts, group\u003dCOORDINATION_GROUP)"},{"line_number":376,"context_line":"CONF.register_opts(profiler_opts, group\u003dPROFILER_GROUP)"},{"line_number":377,"context_line":"CONF.register_opt(js_impl_opt)"},{"line_number":378,"context_line":"CONF.register_opt(rpc_impl_opt)"},{"line_number":379,"context_line":"CONF.register_opt(rpc_response_timeout_opt)"},{"line_number":380,"context_line":"CONF.register_opts(keycloak_oidc_opts, group\u003dKEYCLOAK_OIDC_GROUP)"},{"line_number":381,"context_line":"CONF.register_opt(os_endpoint_type)"},{"line_number":382,"context_line":"CONF.register_opt(expiration_token_duration)"},{"line_number":383,"context_line":"CONF.register_opts(clients_opts, group\u003dCLIENTS_GROUP)"},{"line_number":384,"context_line":"CONF.register_opts(openstack_actions_opts, group\u003dOPENSTACK_ACTIONS_GROUP)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_b480fd47","line":383,"range":{"start_line":377,"start_character":0,"end_line":383,"end_character":53},"in_reply_to":"ff0f0b1f_25e2c002","updated":"2017-05-22 15:24:15.000000000","message":"I think it is because of conflict and i was quite tired to solve it, my bad for this messy change.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"0a6d1e4a598d566ac6251456d7f92f4d92e229c8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"CONF.register_opts(pecan_opts, group\u003dPECAN_GROUP)"},{"line_number":375,"context_line":"CONF.register_opts(coordination_opts, group\u003dCOORDINATION_GROUP)"},{"line_number":376,"context_line":"CONF.register_opts(profiler_opts, group\u003dPROFILER_GROUP)"},{"line_number":377,"context_line":"CONF.register_opt(js_impl_opt)"},{"line_number":378,"context_line":"CONF.register_opt(rpc_impl_opt)"},{"line_number":379,"context_line":"CONF.register_opt(rpc_response_timeout_opt)"},{"line_number":380,"context_line":"CONF.register_opts(keycloak_oidc_opts, group\u003dKEYCLOAK_OIDC_GROUP)"},{"line_number":381,"context_line":"CONF.register_opt(os_endpoint_type)"},{"line_number":382,"context_line":"CONF.register_opt(expiration_token_duration)"},{"line_number":383,"context_line":"CONF.register_opts(clients_opts, group\u003dCLIENTS_GROUP)"},{"line_number":384,"context_line":"CONF.register_opts(openstack_actions_opts, group\u003dOPENSTACK_ACTIONS_GROUP)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_7449452f","line":383,"range":{"start_line":377,"start_character":0,"end_line":383,"end_character":53},"in_reply_to":"ff0f0b1f_b480fd47","updated":"2017-05-22 15:26:48.000000000","message":"Oh, and of course, it is done by someone else on master and i just solve the conflict","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    )"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"def get_client_option(option):"},{"line_number":443,"context_line":"    # look for the option in the [clients] section"},{"line_number":444,"context_line":"    # unknown options raise cfg.NoSuchOptError"},{"line_number":445,"context_line":"    try:"},{"line_number":446,"context_line":"        cfg.CONF.import_opt(option, \u0027mistral.config\u0027,"},{"line_number":447,"context_line":"                            group\u003d\u0027clients\u0027)"},{"line_number":448,"context_line":"        v \u003d getattr(getattr(cfg.CONF, \u0027clients\u0027), option)"},{"line_number":449,"context_line":"        if v is not None:"},{"line_number":450,"context_line":"            return v"},{"line_number":451,"context_line":"    except cfg.NoSuchGroupError:"},{"line_number":452,"context_line":"        pass"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def get_ssl_options():"},{"line_number":456,"context_line":"    # Look for the ssl options in the [clients] section"},{"line_number":457,"context_line":"    cacert \u003d get_client_option(\u0027ca_file\u0027)"},{"line_number":458,"context_line":"    insecure \u003d get_client_option(\u0027insecure\u0027)"},{"line_number":459,"context_line":"    cert \u003d get_client_option(\u0027cert_file\u0027)"},{"line_number":460,"context_line":"    key \u003d get_client_option(\u0027key_file\u0027)"},{"line_number":461,"context_line":"    if insecure:"},{"line_number":462,"context_line":"        verify \u003d False"},{"line_number":463,"context_line":"    else:"},{"line_number":464,"context_line":"        verify \u003d cacert or True"},{"line_number":465,"context_line":"    if cert and key:"},{"line_number":466,"context_line":"        cert \u003d (cert, key)"},{"line_number":467,"context_line":"    return {\u0027verify\u0027: verify, \u0027cert\u0027: cert}"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"def set_config_defaults():"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_a58db032","line":467,"range":{"start_line":442,"start_character":0,"end_line":467,"end_character":43},"updated":"2017-05-19 02:24:43.000000000","message":"I am a little confused by the two methods here. Why not just use cfg.CONF.\u003cgroup_name\u003e.\u003coption_name\u003e to access options?","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    )"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"def get_client_option(option):"},{"line_number":443,"context_line":"    # look for the option in the [clients] section"},{"line_number":444,"context_line":"    # unknown options raise cfg.NoSuchOptError"},{"line_number":445,"context_line":"    try:"},{"line_number":446,"context_line":"        cfg.CONF.import_opt(option, \u0027mistral.config\u0027,"},{"line_number":447,"context_line":"                            group\u003d\u0027clients\u0027)"},{"line_number":448,"context_line":"        v \u003d getattr(getattr(cfg.CONF, \u0027clients\u0027), option)"},{"line_number":449,"context_line":"        if v is not None:"},{"line_number":450,"context_line":"            return v"},{"line_number":451,"context_line":"    except cfg.NoSuchGroupError:"},{"line_number":452,"context_line":"        pass"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def get_ssl_options():"},{"line_number":456,"context_line":"    # Look for the ssl options in the [clients] section"},{"line_number":457,"context_line":"    cacert \u003d get_client_option(\u0027ca_file\u0027)"},{"line_number":458,"context_line":"    insecure \u003d get_client_option(\u0027insecure\u0027)"},{"line_number":459,"context_line":"    cert \u003d get_client_option(\u0027cert_file\u0027)"},{"line_number":460,"context_line":"    key \u003d get_client_option(\u0027key_file\u0027)"},{"line_number":461,"context_line":"    if insecure:"},{"line_number":462,"context_line":"        verify \u003d False"},{"line_number":463,"context_line":"    else:"},{"line_number":464,"context_line":"        verify \u003d cacert or True"},{"line_number":465,"context_line":"    if cert and key:"},{"line_number":466,"context_line":"        cert \u003d (cert, key)"},{"line_number":467,"context_line":"    return {\u0027verify\u0027: verify, \u0027cert\u0027: cert}"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"def set_config_defaults():"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_149d69bb","line":467,"range":{"start_line":442,"start_character":0,"end_line":467,"end_character":43},"in_reply_to":"ff0f0b1f_a58db032","updated":"2017-05-22 15:24:15.000000000","message":"In fact, they do nothing just adding some checks to the importing options from configuration files.\n\nBtw, you have the point that these options should not be here in this patch. It can be added to the new patch since this one is just refactoring context to use oslo_messaging","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"ec87460d10da66ccfd51e563bf068e61913c79a4","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"openstack_actions_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt("},{"line_number":293,"context_line":"        \u0027os-actions-endpoint-type\u0027,"},{"line_number":294,"context_line":"        default\u003dos.environ.get(\u0027OS_ACTIONS_ENDPOINT_TYPE\u0027, \u0027public\u0027),"},{"line_number":295,"context_line":"        choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027],"},{"line_number":296,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ff0f0b1f_af676db7","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":34},"updated":"2017-05-23 08:19:40.000000000","message":"There is already the same config option you just added.","commit_id":"93588d2c9bd4173d25e49cec3c63a1fa94ec8e92"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"20af15f564088b1bdf2603c40f3caad0d7740c39","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"openstack_actions_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt("},{"line_number":293,"context_line":"        \u0027os-actions-endpoint-type\u0027,"},{"line_number":294,"context_line":"        default\u003dos.environ.get(\u0027OS_ACTIONS_ENDPOINT_TYPE\u0027, \u0027public\u0027),"},{"line_number":295,"context_line":"        choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027],"},{"line_number":296,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ff0f0b1f_bb49efb7","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":34},"in_reply_to":"ff0f0b1f_2f023d70","updated":"2017-05-23 10:39:02.000000000","message":"Oh, sorry for duplicate. I could not focus 100% on the upstream work so that it is quite embarrassed for this error:(. I will fix it in the latter.","commit_id":"93588d2c9bd4173d25e49cec3c63a1fa94ec8e92"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"09c673cf21fb73f4e86b728b55d050f9e5a7dc07","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"openstack_actions_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt("},{"line_number":293,"context_line":"        \u0027os-actions-endpoint-type\u0027,"},{"line_number":294,"context_line":"        default\u003dos.environ.get(\u0027OS_ACTIONS_ENDPOINT_TYPE\u0027, \u0027public\u0027),"},{"line_number":295,"context_line":"        choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027],"},{"line_number":296,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ff0f0b1f_2f023d70","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":34},"in_reply_to":"ff0f0b1f_af676db7","updated":"2017-05-23 08:28:14.000000000","message":"Yes.","commit_id":"93588d2c9bd4173d25e49cec3c63a1fa94ec8e92"}],"mistral/context.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"292182350ed1e5191d74320b5ca0baf5a9007ce5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 trust_id\u003dNone, trustor_user_id\u003dNone, auth_token\u003dNone,"},{"line_number":92,"context_line":"                 region_name\u003dNone, auth_plugin\u003dNone, trusts_auth_plugin\u003dNone,"},{"line_number":93,"context_line":"                 user_id\u003dNone, project_id\u003dNone, insecure\u003dFalse, is_trust_scoped\u003dFalse,"},{"line_number":94,"context_line":"                 redelivered\u003dFalse, service_catalog\u003dNone, project_name\u003dNone, expires_at\u003dNone, **kwargs):"},{"line_number":95,"context_line":"        \"\"\"Initialisation of the request context."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param overwrite: Set to False to ensure that the greenthread local"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_531abfcb","line":94,"updated":"2017-04-10 20:37:56.000000000","message":"can we just pass most of these through to super().__init__? The idea is that they are then handled by from_environ.\n\nHave a look through the things that the base oslo.context provides now, it\u0027s improved in the last cycle or two. \n\nhttps://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L370","commit_id":"89e9bd858e8c79de898405b8d76e03a786a8a302"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"3fb503ffa746c150a80933e7c7c78a4d9fbe1abb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 trust_id\u003dNone, trustor_user_id\u003dNone, auth_token\u003dNone,"},{"line_number":92,"context_line":"                 region_name\u003dNone, auth_plugin\u003dNone, trusts_auth_plugin\u003dNone,"},{"line_number":93,"context_line":"                 user_id\u003dNone, project_id\u003dNone, insecure\u003dFalse, is_trust_scoped\u003dFalse,"},{"line_number":94,"context_line":"                 redelivered\u003dFalse, service_catalog\u003dNone, project_name\u003dNone, expires_at\u003dNone, **kwargs):"},{"line_number":95,"context_line":"        \"\"\"Initialisation of the request context."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param overwrite: Set to False to ensure that the greenthread local"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_3896eb94","line":94,"in_reply_to":"bff0334d_531abfcb","updated":"2017-04-11 07:44:01.000000000","message":"Yep, i will update it in the new patch","commit_id":"89e9bd858e8c79de898405b8d76e03a786a8a302"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# password \u003d password"},{"line_number":52,"context_line":"PASSWORD_PLUGIN \u003d \u0027password\u0027"},{"line_number":53,"context_line":"TRUSTEE_CONF_GROUP \u003d \u0027trustee\u0027"},{"line_number":54,"context_line":"ks_loading.register_auth_conf_options(cfg.CONF, TRUSTEE_CONF_GROUP)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_85998c6f","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":67},"updated":"2017-05-19 02:24:43.000000000","message":"I suggest moving the option registration to a single place (mistral/config.py)","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# password \u003d password"},{"line_number":52,"context_line":"PASSWORD_PLUGIN \u003d \u0027password\u0027"},{"line_number":53,"context_line":"TRUSTEE_CONF_GROUP \u003d \u0027trustee\u0027"},{"line_number":54,"context_line":"ks_loading.register_auth_conf_options(cfg.CONF, TRUSTEE_CONF_GROUP)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_3f75eb32","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":67},"in_reply_to":"ff0f0b1f_85998c6f","updated":"2017-05-22 15:24:15.000000000","message":"I will remove it to the next patch for trustor and trustee. Btw, you can see on the above comments that show that these configs should be done vua ks_loading, therefore it should be placed here and its list_opts will be put into entry_points","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            **kwargs"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.user_name \u003d user_name"},{"line_number":103,"context_line":"        self.user_id \u003d user_id"},{"line_number":104,"context_line":"        self.project_id \u003d project_id"},{"line_number":105,"context_line":"        self.password \u003d password"},{"line_number":106,"context_line":"        self.project_name \u003d project_name"},{"line_number":107,"context_line":"        self.region_name \u003d region_name"},{"line_number":108,"context_line":"        self.auth_url \u003d auth_url"},{"line_number":109,"context_line":"        self.auth_uri \u003d auth_uri"},{"line_number":110,"context_line":"        self.auth_cacert \u003d auth_cacert"},{"line_number":111,"context_line":"        self.service_catalog \u003d service_catalog"},{"line_number":112,"context_line":"        self.is_trust_scoped \u003d is_trust_scoped"},{"line_number":113,"context_line":"        self.redelivered \u003d redelivered"},{"line_number":114,"context_line":"        self._session \u003d None"},{"line_number":115,"context_line":"        self._keystone_session \u003d session.Session("},{"line_number":116,"context_line":"            **config.get_ssl_options())"},{"line_number":117,"context_line":"        self._auth_plugin \u003d auth_plugin"},{"line_number":118,"context_line":"        self._trusts_auth_plugin \u003d trusts_auth_plugin"},{"line_number":119,"context_line":"        self.is_admin \u003d is_admin"},{"line_number":120,"context_line":"        self.is_target \u003d is_target"},{"line_number":121,"context_line":"        self.expires_at \u003d expires_at"},{"line_number":122,"context_line":"        self.insecure \u003d insecure"},{"line_number":123,"context_line":"        # context scoped cache dict where the key is a class of the type of"},{"line_number":124,"context_line":"        # object being cached and the value is the cache implementation class"},{"line_number":125,"context_line":"        self._object_cache \u003d {}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def cache(self, cache_cls):"},{"line_number":128,"context_line":"        cache \u003d self._object_cache.get(cache_cls)"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_65031875","line":125,"range":{"start_line":102,"start_character":0,"end_line":125,"end_character":31},"updated":"2017-05-19 02:24:43.000000000","message":"There are some properties already defined in RequestContext class that we don\u0027t need to duplicate them here.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self._object_cache[cache_cls] \u003d cache"},{"line_number":132,"context_line":"        return cache"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def to_dict(self):"},{"line_number":135,"context_line":"        context \u003d {"},{"line_number":136,"context_line":"            \u0027auth_token\u0027: self.auth_token,"},{"line_number":137,"context_line":"            \u0027user_name\u0027: self.user_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_e543a8ae","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":15},"updated":"2017-05-19 02:24:43.000000000","message":"why not use RequestContext.to_dict() and append mistral related things to the result?","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self._object_cache[cache_cls] \u003d cache"},{"line_number":132,"context_line":"        return cache"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def to_dict(self):"},{"line_number":135,"context_line":"        context \u003d {"},{"line_number":136,"context_line":"            \u0027auth_token\u0027: self.auth_token,"},{"line_number":137,"context_line":"            \u0027user_name\u0027: self.user_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_b186cf12","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":15},"in_reply_to":"ff0f0b1f_e543a8ae","updated":"2017-05-22 15:24:15.000000000","message":"well, of course we can go with that way and also modify the from_dict() too. However it will take time and this modification of this context just a supplementary part for the keystone trust usage. Therefore i would like to keep like this in order to move forward with the main purpose.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8088d045197911c3540dee8c348ca58fc541081","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    utils.set_thread_local(_CTX_THREAD_LOCAL_NAME, new_ctx)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def context_from_headers_and_env(headers, env):"},{"line_number":220,"context_line":"    params \u003d _extract_auth_params_from_headers(headers)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    auth_cacert \u003d params[\u0027auth_cacert\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_a5f37073","line":219,"range":{"start_line":219,"start_character":4,"end_line":219,"end_character":32},"updated":"2017-05-19 02:24:43.000000000","message":"If we really want to use oslo.context, this function should live in MistralContext class and use MistralContext.from_environ() to initialize the context object.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"fb8118e5c76f3a79ad6cb7b6f4f84f0ba1c64be4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    utils.set_thread_local(_CTX_THREAD_LOCAL_NAME, new_ctx)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def context_from_headers_and_env(headers, env):"},{"line_number":220,"context_line":"    params \u003d _extract_auth_params_from_headers(headers)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    auth_cacert \u003d params[\u0027auth_cacert\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff0f0b1f_71203749","line":219,"range":{"start_line":219,"start_character":4,"end_line":219,"end_character":32},"in_reply_to":"ff0f0b1f_a5f37073","updated":"2017-05-22 15:24:15.000000000","message":"Calling from from_environ() is actually a good way to go.","commit_id":"fe1f0a9f931c96f1aaa39a08a5fe63f6422b1a8d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5fe66eee9a6c2c364961a5911ec992fbb50c02a0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.v3 import client as keystone_client"},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"import oslo_messaging as messaging"},{"line_number":20,"context_line":"from osprofiler import profiler"}],"source_content_type":"text/x-python","patch_set":24,"id":"df140735_96c0dd52","line":17,"updated":"2017-05-29 02:05:26.000000000","message":"why not use oslo.log?","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.user_name \u003d user_name"},{"line_number":65,"context_line":"        self.user_id \u003d user_id"},{"line_number":66,"context_line":"        self.project_id \u003d project_id"},{"line_number":67,"context_line":"        self.password \u003d password"},{"line_number":68,"context_line":"        self.project_name \u003d project_name"},{"line_number":69,"context_line":"        self.region_name \u003d region_name"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_c720bd9e","line":66,"updated":"2017-05-26 19:47:50.000000000","message":"The identity parameters need to be passed to the base class using their correct names to ensure that logging works as expected. It\u0027s fine to store the values under other names, but look at the base class before doing that because some of them are already defined using properties that pull the value from the old name.","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self._session \u003d None"},{"line_number":77,"context_line":"        self._auth_plugin \u003d auth_plugin"},{"line_number":78,"context_line":"        self._trusts_auth_plugin \u003d trusts_auth_plugin"},{"line_number":79,"context_line":"        self.is_admin \u003d is_admin"},{"line_number":80,"context_line":"        self.is_target \u003d is_target"},{"line_number":81,"context_line":"        self.expires_at \u003d expires_at"},{"line_number":82,"context_line":"        self.insecure \u003d insecure"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_2731b9ed","line":79,"updated":"2017-05-26 19:47:50.000000000","message":"The base class already has an is_admin field, so pass that in when initializing the base class.","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self._object_cache[cache_cls] \u003d cache"},{"line_number":92,"context_line":"        return cache"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def to_dict(self):"},{"line_number":95,"context_line":"        context \u003d {"},{"line_number":96,"context_line":"            \u0027auth_token\u0027: self.auth_token,"},{"line_number":97,"context_line":"            \u0027user_name\u0027: self.user_name,"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_c7555dfc","line":94,"updated":"2017-05-26 19:47:50.000000000","message":"The base class defines a version of this method that includes a bunch of other properties it needs in order to be reconstructed correctly. If this subclass needs more values, they should be added to that dictionary (call the base class to_dict() method then add values, instead of building a new dictionary here in this method).","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        return context"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @classmethod"},{"line_number":113,"context_line":"    def from_dict(cls, values):"},{"line_number":114,"context_line":"        return cls("},{"line_number":115,"context_line":"            auth_token\u003dvalues.get(\u0027auth_token\u0027),"},{"line_number":116,"context_line":"            user_name\u003dvalues.get(\u0027user_name\u0027),"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_27465951","line":113,"updated":"2017-05-26 19:47:50.000000000","message":"There is already a from_dict() on the base class. You may not need this method at all.","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    Note that overwrite is False here so this context will not update the"},{"line_number":149,"context_line":"    greenthread-local stored context that is used when logging."},{"line_number":150,"context_line":"    \"\"\""},{"line_number":151,"context_line":"    return context.RequestContext("},{"line_number":152,"context_line":"        user_id\u003dNone,"},{"line_number":153,"context_line":"        project_id\u003dNone,"},{"line_number":154,"context_line":"        is_admin\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_275f790f","line":151,"updated":"2017-05-26 19:47:50.000000000","message":"Should this create a MistralContext?","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":159,"context_line":"    return context.RequestContext(is_admin\u003dTrue,"},{"line_number":160,"context_line":"                                  show_deleted\u003dshow_deleted"},{"line_number":161,"context_line":"                                  )"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_079a35c4","line":159,"updated":"2017-05-26 19:47:50.000000000","message":"Should this create a MistralContext?","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e198e5f4d4954b5b8ee38c104f103add0012a761","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                  )"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def has_ctx():"},{"line_number":165,"context_line":"    return utils.has_thread_local(_CTX_THREAD_LOCAL_NAME)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ff0f0b1f_e7874161","line":164,"updated":"2017-05-26 19:47:50.000000000","message":"oslo.context manages its own thread-local store. New contexts are written there automatically when they are created. These functions (has_ctx, and ctx) could be changed to use that implementation. The set_ctx() method has no equivalent and shouldn\u0027t be needed.","commit_id":"9edd9a2e78cde08b3478d52828410c7fe7be880b"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"5b506f820f02d2b331843b06f4f655656674c4a2","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def is_token_trust_scoped(auth_token):"},{"line_number":172,"context_line":"    # admin_project_name \u003d CONF.keystone_authtoken.admin_tenant_name"},{"line_number":173,"context_line":"    admin_project_name \u003d None"},{"line_number":174,"context_line":"    keystone_client \u003d _admin_client(project_name\u003dadmin_project_name)"},{"line_number":175,"context_line":"    token_info \u003d keystone_client.tokens.validate(auth_token)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_376d3a04","line":172,"updated":"2017-04-25 19:37:52.000000000","message":"Is this an oversight, as admin_project_name is hard coded to None.","commit_id":"c8cbc8831c2f60bce199fa04e9f2465ae93aee19"},{"author":{"_account_id":14025,"name":"luong tuan","email":"tuan.luong_huu@nokia.com","username":"tuantuluong"},"change_message_id":"7d56d705621323cb56b81a131b0f228b6652fc67","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def is_token_trust_scoped(auth_token):"},{"line_number":172,"context_line":"    # admin_project_name \u003d CONF.keystone_authtoken.admin_tenant_name"},{"line_number":173,"context_line":"    admin_project_name \u003d None"},{"line_number":174,"context_line":"    keystone_client \u003d _admin_client(project_name\u003dadmin_project_name)"},{"line_number":175,"context_line":"    token_info \u003d keystone_client.tokens.validate(auth_token)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_9f49b7d1","line":172,"in_reply_to":"5ff73747_376d3a04","updated":"2017-04-26 06:26:03.000000000","message":"Oh, my bad. Forgot to remove this hardcode here. It was there when i test myself keystone_authtoken.\n\nThanks Toure for this stupid fault.","commit_id":"c8cbc8831c2f60bce199fa04e9f2465ae93aee19"}]}
