)]}'
{"mistral/engine/tasks.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"5301343e46e3feb5dee7c3c0a56afc2f3295c7c7","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if self.triggered_by:"},{"line_number":232,"context_line":"            values[\u0027runtime_context\u0027][\u0027triggered_by\u0027] \u003d ["},{"line_number":233,"context_line":"                {"},{"line_number":234,"context_line":"                    \u0027task_id\u0027: self.triggered_by[0].id,"},{"line_number":235,"context_line":"                    \u0027event\u0027: self.triggered_by[1]"},{"line_number":236,"context_line":"                }"},{"line_number":237,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_b896974b","line":234,"updated":"2017-05-10 21:28:57.000000000","message":"How is join handled? I would expect multiple tasks identified here.","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d9f7ec22dfd47edcc37bd0c006d08a1c8db8b70c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if self.triggered_by:"},{"line_number":232,"context_line":"            values[\u0027runtime_context\u0027][\u0027triggered_by\u0027] \u003d ["},{"line_number":233,"context_line":"                {"},{"line_number":234,"context_line":"                    \u0027task_id\u0027: self.triggered_by[0].id,"},{"line_number":235,"context_line":"                    \u0027event\u0027: self.triggered_by[1]"},{"line_number":236,"context_line":"                }"},{"line_number":237,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_fb2416b1","line":234,"in_reply_to":"3f044301_b896974b","updated":"2017-05-11 04:12:53.000000000","message":"Join will be handled in a subsequent patch (there\u0027s a WIP for it). There will be multiple items {\u0027task_id\u0027: ..., \u0027event\u0027: ...} if it\u0027s join.","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"06ef9a5d3158029f7edf37ff2b9fca04e671f790","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if self.triggered_by:"},{"line_number":232,"context_line":"            values[\u0027runtime_context\u0027][\u0027triggered_by\u0027] \u003d ["},{"line_number":233,"context_line":"                {"},{"line_number":234,"context_line":"                    \u0027task_id\u0027: self.triggered_by[0].id,"},{"line_number":235,"context_line":"                    \u0027event\u0027: self.triggered_by[1]"},{"line_number":236,"context_line":"                }"},{"line_number":237,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_1fdb7e1b","line":234,"in_reply_to":"3f044301_fb2416b1","updated":"2017-05-16 16:50:36.000000000","message":"Ok. Than I\u0027ll remove the -1 and look out for this other patch.","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"}],"mistral/tests/unit/engine/test_direct_workflow.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4677c31cd3d2325cf36823e26c527790ac2dade9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Explicitly wait for \u0027task2\u0027 completion since it may finish"},{"line_number":90,"context_line":"        # after the workflow state was set to \u0027ERROR\u0027."},{"line_number":91,"context_line":"        self.await_task_success(task2.id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_condition_transition_not_triggering(self):"},{"line_number":94,"context_line":"        wf_text \u003d \"\"\"---"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_38b8c428","line":91,"updated":"2017-05-04 13:07:12.000000000","message":"Not sure what is the behavior today, but do we really want some tasks to continue running after the workflow execution failed?\n\nI would expect that if the workflow execution is in a final state, all sub workflows and tasks recursively, will be in a final state too.\n\nHow will the user even know if there is a running task? It can be in a sub-workflow of a sub-workflow of a sub-workflow etc, forcing him to do multiple queries in order to find out (or run a workflow doing it for him with tasks function).\n\nWhat if we add a feature (not sure if we have it) to suspend a workflow (in addition to the option to fail it etc). Is it OK if the workflow will be in suspended state while tasks are running?","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5058b55b42ef53958213bf915d4616b837e6c5c9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Explicitly wait for \u0027task2\u0027 completion since it may finish"},{"line_number":90,"context_line":"        # after the workflow state was set to \u0027ERROR\u0027."},{"line_number":91,"context_line":"        self.await_task_success(task2.id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_condition_transition_not_triggering(self):"},{"line_number":94,"context_line":"        wf_text \u003d \"\"\"---"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_589a5714","line":91,"in_reply_to":"3f044301_38b8c428","updated":"2017-05-05 04:46:31.000000000","message":"Well, a few things here:\n\n* This patch didn\u0027t change this aspect of behavior you\u0027re talking about. It changed the order in which \"on-complete\" is processed. It\u0027s now always processed after processing \"on-success\" and \"on-error\" so that they have higher priority. Previously we were just hiding a bug with a wrong test.\n\n* The engine commands (\"fail\", \"succeed\", \"pause\") were initially implemented in a way that we change the state of a workflow immediately regardless of what\u0027s going to happen next. Btw, it now happens in many cases even when we don\u0027t use engine commands. For example, we have two parallel branches and in one of them a task failed (and it doesn\u0027t have on-error handler), the workflow will fail (its state will be set to ERROR) then although in the second branch some task may be running. So, it\u0027s normal for the current architecture. We can have the workflow state ERROR but something may be running.\n\n* In case of using \"fail\" explicitly after a task name in a list the use case may be that we already know at some point that the workflow has failed logically (no chance to complete it successfully) but we still want to ru one or more tasks to do some clean up.\n\n* I believe that your concern is valid, some users may want to know exactly that there\u0027s no any activities on a certain workflow but I think that it should be addressed in a different way, not necessarily changing workflow state only after all tasks have finished. The best candidate to me is this spec: https://review.openstack.org/#/c/455083/ It\u0027s needed to cover the question of how we subscribe to events happening in Mistral with workflows, tasks etc. I think we could have a workflow event signaling that \"all workflow activities have finished\".\n\nI hope this is clearer now.","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4677c31cd3d2325cf36823e26c527790ac2dade9","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        # \u0027on-complete\u0027 of \u0027task1\u0027 we still expect that \u0027task2\u0027 will"},{"line_number":711,"context_line":"        # start only once."},{"line_number":712,"context_line":"        self._assert_single_item(t_execs, name\u003d\u0027task1\u0027, state\u003dstates.SUCCESS)"},{"line_number":713,"context_line":"        self._assert_single_item(t_execs, name\u003d\u0027task2\u0027, state\u003dstates.SUCCESS)"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def test_triggered_by(self):"},{"line_number":716,"context_line":"        wf_text \u003d \"\"\"---"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_985eb8e4","line":713,"updated":"2017-05-04 13:07:12.000000000","message":"What do we expect, if one of the tasks had a condition? if both have the same condition? if both have different conditions?","commit_id":"8e1773a4d2decfc38cf56caaa48b95e04d106176"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0a06537326613dce2fd85906c612d7be2477f545","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          tasks:"},{"line_number":49,"context_line":"            task1:"},{"line_number":50,"context_line":"              description: |"},{"line_number":51,"context_line":"                Explicit \u0027succeed\u0027 command should lead to workflow failure."},{"line_number":52,"context_line":"              action: std.echo output\u003d\"Echo\""},{"line_number":53,"context_line":"              on-success:"},{"line_number":54,"context_line":"                - task2"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_02909542","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":33},"updated":"2017-05-22 09:34:10.000000000","message":"I expect that the change of this test will still be controversial. But this time I\u0027m sure about it. I believe that more concrete clauses (on-success and on-error) should have higher priority over on-complete.","commit_id":"a2865e2cf0e3332ae53871c97e4abf34133dee7d"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"afaff7c9824e5617e576ee3725dfbb418810e645","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          tasks:"},{"line_number":49,"context_line":"            task1:"},{"line_number":50,"context_line":"              description: |"},{"line_number":51,"context_line":"                Explicit \u0027succeed\u0027 command should lead to workflow failure."},{"line_number":52,"context_line":"              action: std.echo output\u003d\"Echo\""},{"line_number":53,"context_line":"              on-success:"},{"line_number":54,"context_line":"                - task2"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_02f1b56b","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":74},"updated":"2017-05-22 09:45:17.000000000","message":"typo? the command is succeed should lead to success.","commit_id":"a2865e2cf0e3332ae53871c97e4abf34133dee7d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a369bc60abbb6f63a3be89ea7f4a88f321567726","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          tasks:"},{"line_number":49,"context_line":"            task1:"},{"line_number":50,"context_line":"              description: |"},{"line_number":51,"context_line":"                Explicit \u0027succeed\u0027 command should lead to workflow failure."},{"line_number":52,"context_line":"              action: std.echo output\u003d\"Echo\""},{"line_number":53,"context_line":"              on-success:"},{"line_number":54,"context_line":"                - task2"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_fd8ae618","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":74},"in_reply_to":"ff0f0b1f_02f1b56b","updated":"2017-05-22 10:02:07.000000000","message":"Yes! Thanks :)","commit_id":"a2865e2cf0e3332ae53871c97e4abf34133dee7d"}]}
