)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5e3d0f84ca41a1cc352ee48b01dda01afa66f24a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5ff73747_a76b8a1d","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"updated":"2017-05-03 09:50:22.000000000","message":"Why \"running_region\" and not just \"region\"?","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"328c7bd2a4afd8f3c9b38a4aa2ff91b2092c3c3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_9cac4c8d","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_1b75e995","updated":"2017-05-05 10:05:15.000000000","message":"The changes won\u0027t be affected after we switch to mistral-lib. Switching to mistral-extra is another topic maybe need more consideration besides this one.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"3d5821a8d9293dd1bf13aa494741e056cd132e87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_14ab9a1d","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_34d7b6c2","updated":"2017-05-04 09:51:30.000000000","message":"I like \"action_region\" too. I don\u0027t understand why would someone want to change it, is it a real use-case?","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a320e73dc5cb0ceca411c515434f6d37c10c84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_f77cb0b6","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_34d7b6c2","updated":"2017-05-04 10:13:59.000000000","message":"no, I mean, the configuration for project list","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20c2ca6d55a2282325a64390733a7efaaecbdab4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_34d7b6c2","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_54f802c3","updated":"2017-05-04 09:42:09.000000000","message":"Hm.. A config option for this parameter name? It may be a good idea. \"action_region\" could be its default value then.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"10ff5653c27ac67742ef6f68c6e1af4d9ea3bbea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_f776f73e","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_5c139267","updated":"2017-05-04 05:11:54.000000000","message":"Let me give an example. Given there is an action in keystone called delete_user_group, and it has an optional param called \u0027region\u0027, which means delete a user group in the region defined.\n\nIf we add another \u0027region\u0027 param with the expectation of performing \u0027delete_user_group\u0027 action in that region, and the user can see input list for delete_user_group action via CLI. So, should the user see two \u0027region\u0027 params or just one? Of course, two \u0027region\u0027 params will be an issue, but if one, how a user could define the following action: I want to delete user group in the region1 but the action should run in region2?\n\nHowever, I am not sure if that kind of actions exists already in OpenStack, hopefully not, I just want to express my thoughts clear to you.\n\nAgain, I\u0027m not insisting do not change the code, I am trying to let you know the potential possibilities that could mess up things.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6cad9877f06fe389a030468c80a084160272d6b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_5c139267","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_cb1a4116","updated":"2017-05-04 04:51:57.000000000","message":"I still don\u0027t understand why \"region\" is bad. Name clashing yes. At the implementation level. But the whole idea is that we users don\u0027t have to know anything about name clashing or other details of how it works and hence, for them there\u0027s just region where the action is running. What else should they know? We just declare in our docs: \"All OpenStack actions have the \u0027region\u0027 parameter regardless of what clients/methods used under the hood\". And it\u0027s our duty to make it work properly. Who said that users must necessarily be familiar with Python clients of all OpenStack services? Even more, I would say our goal is to let users of OpenStack not have to worry about it at all. If they can use Mistral workflows to call OpenStack services then it\u0027s good. But we need to make it easy and enjoyable. Some might not even know how to install clients (or consolidated openstack client, doesn\u0027t matter).\n\nSo, IMO, we don\u0027t need any other suggestions for what naturally should be called \"region\".","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"86446c293ea83fc476dd8b35032e2d6b93fa1d87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_54f802c3","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_e853b8e1","updated":"2017-05-04 09:23:29.000000000","message":"Yeah, we could handle keystone differently, maybe there will be other projects one day in future, do you still prefer we hard-code it in the code instead of adding a config item?\n\nI also like \u0027action_region\u0027 btw.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bdf49e8b93bb04dbd0e1db28df32ade87500453c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_e853b8e1","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_f776f73e","updated":"2017-05-04 07:37:49.000000000","message":"Thanks Lingxian, yes. The example you provided is valid, yes.\n\nOne thing I had in mind but forgot to write in the comment is that I think Keystone should be an exception. My suggestion would be to handle Keystone actions differently. For them we can really choose a different name for this parameter. May be \"target_region\" or \"action_region\"?\n\nOr, as an alternative (if nobody supports the idea with just \"region\"), I\u0027d suggest the name \"action_region\" instead of \"running_region\" because it will distinctly show that this is something brought by Mistral on top of regular Python client method arguments.\n\nLooking forward to seeing what other team members say.\n\nPlease let\u0027s keep the discussion alive, I\u0027d like to have it done asap.\n\nThanks","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"490a9e30b2e941f08066fcd840bc67865307e36a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_1b75e995","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3f044301_f77cb0b6","updated":"2017-05-05 05:07:26.000000000","message":"Well, I\u0027m probably ok with it if you think it\u0027s worth it but I\u0027m just asking to make it with a good default (most frequently used). \n\nAnother important consideration. Pretty soon we\u0027ll be moving all OpenStack actions to mistral-extra. The implementation of the actions will be based on the code from mistral-lib. And also we\u0027re planning to make tools that will allow to easily install/configure/uninstall needed actions. So if we have this option it will eventually has to be part of mistral-extra and probably not even part of the runtime configuration, only installation configuration.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"41fc0ee088d71ec6814f01e2f2327632b1b3a83e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lingxian Kong \u003canlin.kong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 15:14:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"running_region\" param for OpenStack actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint mistral-multi-region-support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f044301_cb1a4116","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"5ff73747_a76b8a1d","updated":"2017-05-03 23:32:15.000000000","message":"I am trying to avoid adding a param with potential name clashing with other openstack action inputs. \u0027region\u0027 is so heavily used for openstack projects.\n\nDo you have another suggestion?","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"}],"mistral/actions/openstack/action_generator/base.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"632615f7297fc4528a157b7411879344149a9c8b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base_action_class \u003d None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_action_inputs(cls, origin_inputs, added\u003d[], removed\u003d[]):"},{"line_number":72,"context_line":"        \"\"\"Modify action input string."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Examples::"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_9e23cbbd","line":71,"updated":"2017-04-27 11:00:49.000000000","message":"What is the use case for removed?","commit_id":"8bfdc36319f35d0e790088550751d3d7ce1b4113"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6b85f59692c03905213b1bdffecb4d9c63c56f0f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base_action_class \u003d None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_action_inputs(cls, origin_inputs, added\u003d[], removed\u003d[]):"},{"line_number":72,"context_line":"        \"\"\"Modify action input string."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Examples::"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_44d5721b","line":71,"in_reply_to":"5ff73747_9e23cbbd","updated":"2017-04-27 11:22:04.000000000","message":"It\u0027s not used for now, I keep it here just in case we need it in future (not harmful)","commit_id":"8bfdc36319f35d0e790088550751d3d7ce1b4113"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"1d30c079dfcbb587a48072baf8bbb2c52c063bbf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base_action_class \u003d None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_action_inputs(cls, origin_inputs, added\u003d[], removed\u003d[]):"},{"line_number":72,"context_line":"        \"\"\"Modify action input string."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Examples::"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_275f7ae6","line":71,"updated":"2017-05-03 09:40:10.000000000","message":"In a previous patchset you said that adding unused code wasn\u0027t harmful. I disagree, any unused code should be removed. It is adding technical debt. It would be easy to add if we need it.\n\nSo I would prefer that the \"removed\" functionality is, well, removed :)","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bd7eb99f9bd38cb5737c07a3caccdb2051c06fa5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base_action_class \u003d None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_action_inputs(cls, origin_inputs, added\u003d[], removed\u003d[]):"},{"line_number":72,"context_line":"        \"\"\"Modify action input string."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Examples::"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_d0b9aee9","line":71,"in_reply_to":"5ff73747_275f7ae6","updated":"2017-05-03 11:38:24.000000000","message":"100% agree","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"898c2535f57b7521bf84683cdbe5747a9995f282","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base_action_class \u003d None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_action_inputs(cls, origin_inputs, added\u003d[], removed\u003d[]):"},{"line_number":72,"context_line":"        \"\"\"Modify action input string."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Examples::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_b1b40237","line":71,"in_reply_to":"5ff73747_d0b9aee9","updated":"2017-05-03 23:39:06.000000000","message":"Removed.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"}],"mistral/actions/openstack/actions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"632615f7297fc4528a157b7411879344149a9c8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ff73747_c105f447","side":"PARENT","updated":"2017-04-27 11:00:49.000000000","message":"nice cleanup here!","commit_id":"a753759cad44e466de38e058aeaf1e4a439acbd1"}],"mistral/config.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"632615f7297fc4528a157b7411879344149a9c8b","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        \u0027modules-support-region\u0027,"},{"line_number":284,"context_line":"        default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027ceilometer\u0027, \u0027heat\u0027, \u0027neutron\u0027, \u0027cinder\u0027,"},{"line_number":285,"context_line":"                 \u0027trove\u0027, \u0027ironic\u0027, \u0027designate\u0027, \u0027murano\u0027, \u0027tacker\u0027, \u0027senlin\u0027,"},{"line_number":286,"context_line":"                 \u0027aodh\u0027, \u0027gnocchi\u0027],"},{"line_number":287,"context_line":"        help\u003d_(\u0027List of module names that support region in actions.\u0027)"},{"line_number":288,"context_line":"    )"},{"line_number":289,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_210db8a0","line":286,"updated":"2017-04-27 11:00:49.000000000","message":"What about this, do they not support regions? keystone? swift? zaqar? barbican? mistral? magnum?","commit_id":"8bfdc36319f35d0e790088550751d3d7ce1b4113"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6b85f59692c03905213b1bdffecb4d9c63c56f0f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        \u0027modules-support-region\u0027,"},{"line_number":284,"context_line":"        default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027ceilometer\u0027, \u0027heat\u0027, \u0027neutron\u0027, \u0027cinder\u0027,"},{"line_number":285,"context_line":"                 \u0027trove\u0027, \u0027ironic\u0027, \u0027designate\u0027, \u0027murano\u0027, \u0027tacker\u0027, \u0027senlin\u0027,"},{"line_number":286,"context_line":"                 \u0027aodh\u0027, \u0027gnocchi\u0027],"},{"line_number":287,"context_line":"        help\u003d_(\u0027List of module names that support region in actions.\u0027)"},{"line_number":288,"context_line":"    )"},{"line_number":289,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_04fe4a6a","line":286,"in_reply_to":"5ff73747_210db8a0","updated":"2017-04-27 11:22:04.000000000","message":"I didn\u0027t dig into each client to check if they support region or not, this list is being created from how mistral gets their client. From what I can see, at least \u0027keystone\u0027, \u0027swift\u0027 don\u0027t need \u0027region\u0027.","commit_id":"8bfdc36319f35d0e790088550751d3d7ce1b4113"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bd7eb99f9bd38cb5737c07a3caccdb2051c06fa5","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        help\u003d_(\u0027Type of endpoint in identity service catalog to use for\u0027"},{"line_number":290,"context_line":"               \u0027 communication with OpenStack services.\u0027)"},{"line_number":291,"context_line":"    ),"},{"line_number":292,"context_line":"    cfg.ListOpt("},{"line_number":293,"context_line":"        \u0027modules-support-region\u0027,"},{"line_number":294,"context_line":"        default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027ceilometer\u0027, \u0027heat\u0027, \u0027neutron\u0027, \u0027cinder\u0027,"},{"line_number":295,"context_line":"                 \u0027trove\u0027, \u0027ironic\u0027, \u0027designate\u0027, \u0027murano\u0027, \u0027tacker\u0027, \u0027senlin\u0027,"},{"line_number":296,"context_line":"                 \u0027aodh\u0027, \u0027gnocchi\u0027],"},{"line_number":297,"context_line":"        help\u003d_(\u0027List of module names that support region in actions.\u0027)"},{"line_number":298,"context_line":"    )"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"# note: this command line option is used only from sync_db and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_70589a55","line":298,"range":{"start_line":292,"start_character":4,"end_line":298,"end_character":5},"updated":"2017-05-03 11:38:24.000000000","message":"I know we\u0027ve discussed it before but it still doesn\u0027t seem right to me to have this option. It doesn\u0027t make sense to me because this option must never be changed by users, hence it could be a hard-coded list.\n\nI\u0027m not strongly opposed to it but if you could write a couple of sentences and remind why we need it so badly that would be helpful.","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6cad9877f06fe389a030468c80a084160272d6b4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        help\u003d_(\u0027Type of endpoint in identity service catalog to use for\u0027"},{"line_number":290,"context_line":"               \u0027 communication with OpenStack services.\u0027)"},{"line_number":291,"context_line":"    ),"},{"line_number":292,"context_line":"    cfg.ListOpt("},{"line_number":293,"context_line":"        \u0027modules-support-region\u0027,"},{"line_number":294,"context_line":"        default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027ceilometer\u0027, \u0027heat\u0027, \u0027neutron\u0027, \u0027cinder\u0027,"},{"line_number":295,"context_line":"                 \u0027trove\u0027, \u0027ironic\u0027, \u0027designate\u0027, \u0027murano\u0027, \u0027tacker\u0027, \u0027senlin\u0027,"},{"line_number":296,"context_line":"                 \u0027aodh\u0027, \u0027gnocchi\u0027],"},{"line_number":297,"context_line":"        help\u003d_(\u0027List of module names that support region in actions.\u0027)"},{"line_number":298,"context_line":"    )"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"# note: this command line option is used only from sync_db and"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_77566709","line":298,"range":{"start_line":292,"start_character":4,"end_line":298,"end_character":5},"in_reply_to":"3f044301_11129659","updated":"2017-05-04 04:51:57.000000000","message":"Operators, yes, ok. I wasn\u0027t precise enough.\n\nIMO, it\u0027d be just easier (from configuration perspective for understanding it) to add region to all actions. If some service is not deployed in a certain region and we\u0027ll call an action for it it\u0027ll return an error (it just needs to be informative).","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"41fc0ee088d71ec6814f01e2f2327632b1b3a83e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        help\u003d_(\u0027Type of endpoint in identity service catalog to use for\u0027"},{"line_number":290,"context_line":"               \u0027 communication with OpenStack services.\u0027)"},{"line_number":291,"context_line":"    ),"},{"line_number":292,"context_line":"    cfg.ListOpt("},{"line_number":293,"context_line":"        \u0027modules-support-region\u0027,"},{"line_number":294,"context_line":"        default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027ceilometer\u0027, \u0027heat\u0027, \u0027neutron\u0027, \u0027cinder\u0027,"},{"line_number":295,"context_line":"                 \u0027trove\u0027, \u0027ironic\u0027, \u0027designate\u0027, \u0027murano\u0027, \u0027tacker\u0027, \u0027senlin\u0027,"},{"line_number":296,"context_line":"                 \u0027aodh\u0027, \u0027gnocchi\u0027],"},{"line_number":297,"context_line":"        help\u003d_(\u0027List of module names that support region in actions.\u0027)"},{"line_number":298,"context_line":"    )"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"# note: this command line option is used only from sync_db and"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_11129659","line":298,"range":{"start_line":292,"start_character":4,"end_line":298,"end_character":5},"in_reply_to":"5ff73747_70589a55","updated":"2017-05-03 23:32:15.000000000","message":"Renat, this option is not supposed to be changed by **users** but **operators**. With this feature, the end user could specify \u0027running_region\u0027 in action to expect to operate openstack resources in different regions. But there are 2 problems I can see now:\n\n- Keystone is a little special, when it\u0027s shared between regions, we should not add \u0027running_region\u0027 to all Keystone actions.\n- Maybe there are other services only deployed in one region, the operator doesn\u0027t want to allow user could specify \u0027running_region\u0027 neither for those services.\n\nI am not sure why you both think it\u0027s a hardcoded list, the operator could modify the list anytime he needs, after modification, just need to re-populate actions and restart mistral service.\n\nOf course, I can easily remove the list, but we will add \u0027running_region\u0027 param to all OpenStack actions. Are you sure we are going in this direction?","commit_id":"5f0f7bcedaef6e5e21b4a20d030063eac81e78ed"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"bcd7108d7369a6dcac63aac9f8d815023edddea8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    ctx \u003d context.ctx()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    service_catalog \u003d obtain_service_catalog(ctx)"},{"line_number":81,"context_line":"    region \u003d region_name or ctx.region_name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_e0cd255d","line":81,"range":{"start_line":81,"start_character":28,"end_line":81,"end_character":43},"updated":"2017-05-02 06:22:59.000000000","message":"I have a question about this. What region will we see here if we have 2 mistrals in 2 regions and we request mistral using curl and providing token? \n\nE.g. curl http://mistral-region-1:8989/v2/executions -H \"X-Auth-Token: token\" -X POST -d \u003cdata\u003e\n\nI suppose ctx.region_name is appeared from X-Region-Name header. What do you think?","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ccfa1d621127d69b1d9ecbeee7e01071b7c0186f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    ctx \u003d context.ctx()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    service_catalog \u003d obtain_service_catalog(ctx)"},{"line_number":81,"context_line":"    region \u003d region_name or ctx.region_name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_ea75fc64","line":81,"range":{"start_line":81,"start_character":28,"end_line":81,"end_character":43},"in_reply_to":"5ff73747_e0cd255d","updated":"2017-05-02 09:55:26.000000000","message":"Hmm, good question. If you call mistral rest api directly, you have to specify X-Region-Name in the header explicitly, so as you suggested below, we need to provide a default region if the user doesn\u0027t specify anything.","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"bcd7108d7369a6dcac63aac9f8d815023edddea8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"},{"line_number":85,"context_line":"        service_type\u003dservice_type,"},{"line_number":86,"context_line":"        region_name\u003dregion"},{"line_number":87,"context_line":"    )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    endpoint \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_6036b505","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":26},"updated":"2017-05-02 06:22:59.000000000","message":"Also, I have one small suggestion here. Can you add an additional config option for specifying default region if none provided?","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"e806aa196fad42bfc186dad1457b17c78e9659e9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"},{"line_number":85,"context_line":"        service_type\u003dservice_type,"},{"line_number":86,"context_line":"        region_name\u003dregion"},{"line_number":87,"context_line":"    )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    endpoint \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_3db0cfdd","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":26},"in_reply_to":"5ff73747_2a97643c","updated":"2017-05-02 11:06:53.000000000","message":"yes, I absolutely agree. Right place to use it. Could you add use of this option here?","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9a7d7f5a5e33f7a52b2dbf0e47fbd2e3d7e7a9ea","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"},{"line_number":85,"context_line":"        service_type\u003dservice_type,"},{"line_number":86,"context_line":"        region_name\u003dregion"},{"line_number":87,"context_line":"    )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    endpoint \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_607c6ceb","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":26},"in_reply_to":"5ff73747_3db0cfdd","updated":"2017-05-02 11:45:18.000000000","message":"Yes, sure, just exchange idea with you to make sure we are talking about the same thing :-)","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ccfa1d621127d69b1d9ecbeee7e01071b7c0186f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    service_endpoints \u003d service_catalog.get_endpoints("},{"line_number":84,"context_line":"        service_name\u003dservice_name,"},{"line_number":85,"context_line":"        service_type\u003dservice_type,"},{"line_number":86,"context_line":"        region_name\u003dregion"},{"line_number":87,"context_line":"    )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    endpoint \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_2a97643c","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":26},"in_reply_to":"5ff73747_6036b505","updated":"2017-05-02 09:55:26.000000000","message":"Yeah, I think we could get default region from CONF.keystone_authtoken.region_name, thoughts?","commit_id":"1ba4fe41db78848ebd05708207a4835043305a00"}]}