)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"d5664480a7e73b11b74035499915796c65723ba6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     8d517530 (Merge \"Stop using abbreviation DSL in document\")"},{"line_number":2,"context_line":"Author:     Jeffrey Guan \u003cdouble12gzh@163.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2017-06-10 01:49:07 -0400"},{"line_number":4,"context_line":"Commit:     Jeffrey Guan \u003cdouble12gzh@163.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_2700b234","line":1,"updated":"2017-06-10 18:14:21.000000000","message":"This commit message doesn\u0027t meet the OpenStack standards[1].  \n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"4a0d1aeae45686396ec7e9178bbbdc15cbd15721"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"d5664480a7e73b11b74035499915796c65723ba6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeffrey Guan \u003cdouble12gzh@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-10 01:50:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unproper usage example for creating db and granting privileges"},{"line_number":8,"context_line":"in README.rst"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Please refer to https://bugs.launchpad.net/mistral/+bug/1697138"},{"line_number":11,"context_line":"for detailed explaination."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_879e6605","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":13},"updated":"2017-06-10 18:14:21.000000000","message":"\"The first commit line is the most important.\"  Would someone reading this in  email subject line, git annotate messages, gitk viewer annotations, merge commit messages, etc, read this as you\u0027re adding an unproper usage example?  \u003cMaybe a better summarizing first line would be \"Corrects usage example\"","commit_id":"4a0d1aeae45686396ec7e9178bbbdc15cbd15721"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"d5664480a7e73b11b74035499915796c65723ba6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unproper usage example for creating db and granting privileges"},{"line_number":8,"context_line":"in README.rst"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Please refer to https://bugs.launchpad.net/mistral/+bug/1697138"},{"line_number":11,"context_line":"for detailed explaination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1697138"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_07fdb639","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":26},"updated":"2017-06-10 18:14:21.000000000","message":"\"Do not assume the reviewer has access to external web services/site.\"  This commit message message should be totally self-contained.","commit_id":"4a0d1aeae45686396ec7e9178bbbdc15cbd15721"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"e4ccccc41952e2cbb9d307fe59ecd1e29f9a6e20","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Corrects usage example."},{"line_number":8,"context_line":"1. The usage example for \"auth_uri\" and \"identity_uri\" under"},{"line_number":9,"context_line":"\"[keystone_authtoken]\" is confused by \"identity_v2_admin\"."},{"line_number":10,"context_line":"It is advised to update to the follwoing:"},{"line_number":11,"context_line":"  [keystone_authtoken]"},{"line_number":12,"context_line":"  auth_uri \u003d http://keystone-host:port/v3"},{"line_number":13,"context_line":"  identity_uri \u003d http://keystone-host:port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_a1dfcad4","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":40},"updated":"2017-06-20 22:32:38.000000000","message":"s/follwoing/following/","commit_id":"66a4d91d148ae0bafbd20724e89b4b486ba652d2"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"e4ccccc41952e2cbb9d307fe59ecd1e29f9a6e20","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-06-11 21:42:50 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Corrects usage example."},{"line_number":8,"context_line":"1. The usage example for \"auth_uri\" and \"identity_uri\" under"},{"line_number":9,"context_line":"\"[keystone_authtoken]\" is confused by \"identity_v2_admin\"."},{"line_number":10,"context_line":"It is advised to update to the follwoing:"},{"line_number":11,"context_line":"  [keystone_authtoken]"},{"line_number":12,"context_line":"  auth_uri \u003d http://keystone-host:port/v3"},{"line_number":13,"context_line":"  identity_uri \u003d http://keystone-host:port"},{"line_number":14,"context_line":"  auth_version \u003d v3"},{"line_number":15,"context_line":"  admin_user \u003d \u003cuser\u003e"},{"line_number":16,"context_line":"  admin_password \u003d \u003cpassword\u003e"},{"line_number":17,"context_line":"  admin_tenant_name \u003d \u003ctenant\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"2. To keep align with openstack common services, it might be better to"},{"line_number":20,"context_line":"update the example for creating database and granting privileges from"},{"line_number":21,"context_line":" 69 * Create the database and grant privileges::"},{"line_number":22,"context_line":" 70"},{"line_number":23,"context_line":" 71 $ mysql -u root -p"},{"line_number":24,"context_line":" 72 mysql\u003e CREATE DATABASE mistral;"},{"line_number":25,"context_line":" 73 mysql\u003e USE mistral"},{"line_number":26,"context_line":" 74 mysql\u003e GRANT ALL ON mistral.* TO \u0027root\u0027@\u0027localhost\u0027;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"to"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" 69 * Create the database and grant privileges::"},{"line_number":31,"context_line":" 70"},{"line_number":32,"context_line":" 71 $ mysql -u root -p"},{"line_number":33,"context_line":" 72 mysql\u003e CREATE DATABASE mistral;"},{"line_number":34,"context_line":" 73 mysql\u003e USE mistral"},{"line_number":35,"context_line":" 74 mysql\u003e GRANT ALL PRIVILEGES ON mistral.* TO \u0027mistral\u0027@\u0027localhost\u0027 IDENTIFIED BY \u0027MISTRAL_DBPASS\u0027;"},{"line_number":36,"context_line":" 75 GRANT ALL PRIVILEGES ON mistral.* TO \u0027mistral\u0027@\u0027%\u0027 IDENTIFIED BY \u0027MISTRAL_DBPASS\u0027;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"in mistral/README.rst."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Closes-Bug: #1697138"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_9609b396","line":38,"range":{"start_line":8,"start_character":0,"end_line":38,"end_character":22},"updated":"2017-06-20 22:32:38.000000000","message":"Thanks for working on this.  I still think the commit message can be improved.  The point of a commit message is to summarize the need for the change, to provide additional context to the change that a reader might not get from reading the code alone, etc.  Your current commit message essentially duplicates the code changes.  \n\nA simple example of a commit message that explains what the change is and why is included below.\n\n\"\"\"\nCorrects Usage Examples\n\nThis patch updates the configuration example for auth_uri and identity_uri in keystone_authtoken section to appropriate values.  This patch also updates the example to create a MySQL database and grant privileges to a format commonly used within the OpenStack community.\n\nCloses-Bug: #1697138\n\"\"\"","commit_id":"66a4d91d148ae0bafbd20724e89b4b486ba652d2"}]}