)]}'
{"mistral/context.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"046f2994c347ec85e65a181522482d3c637cf41f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":210,"context_line":"        tenant_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":211,"context_line":"        # first try auth_uri, if it\u0027s not set use auth_url instead"},{"line_number":212,"context_line":"        auth_url\u003d(CONF.keystone_authtoken.auth_uri or"},{"line_number":213,"context_line":"                  CONF.keystone_authtoken.auth_url),"},{"line_number":214,"context_line":"        is_trust_scoped\u003dFalse,"},{"line_number":215,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_639cda69","line":212,"range":{"start_line":212,"start_character":17,"end_line":212,"end_character":18},"updated":"2017-06-15 02:02:11.000000000","message":"this is redundant","commit_id":"5265655611ec5fa51d0d7b9245f4e6300d88b9fc"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"046f2994c347ec85e65a181522482d3c637cf41f","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        tenant_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":211,"context_line":"        # first try auth_uri, if it\u0027s not set use auth_url instead"},{"line_number":212,"context_line":"        auth_url\u003d(CONF.keystone_authtoken.auth_uri or"},{"line_number":213,"context_line":"                  CONF.keystone_authtoken.auth_url),"},{"line_number":214,"context_line":"        is_trust_scoped\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_4399de76","line":213,"range":{"start_line":213,"start_character":50,"end_line":213,"end_character":51},"updated":"2017-06-15 02:02:11.000000000","message":"this too","commit_id":"5265655611ec5fa51d0d7b9245f4e6300d88b9fc"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import base64"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystoneauth1.loading import conf"},{"line_number":19,"context_line":"from keystoneauth1.loading import session"},{"line_number":20,"context_line":"from keystoneclient.v3 import client as ks_client"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"import oslo_messaging as messaging"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f9a5b3b6","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":41},"updated":"2017-06-21 10:46:51.000000000","message":"The preferred way is to use keystoneauth1.loading.load_auth_from_conf_options() and keystoneauth1.loading.load_session_from_conf_options()","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import base64"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystoneauth1.loading import conf"},{"line_number":19,"context_line":"from keystoneauth1.loading import session"},{"line_number":20,"context_line":"from keystoneclient.v3 import client as ks_client"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"import oslo_messaging as messaging"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f17c51ec","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":41},"in_reply_to":"5f201791_f9a5b3b6","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027insecure\u0027: CONF.keystone_authtoken.insecure,"},{"line_number":41,"context_line":"    \u0027cert\u0027: CONF.keystone_authtoken.certfile,"},{"line_number":42,"context_line":"    \u0027key\u0027: CONF.keystone_authtoken.keyfile,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class BaseContext(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_79c88354","line":43,"updated":"2017-06-21 10:46:51.000000000","message":"I think this is unnecessary, see my comments below.","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027insecure\u0027: CONF.keystone_authtoken.insecure,"},{"line_number":41,"context_line":"    \u0027cert\u0027: CONF.keystone_authtoken.certfile,"},{"line_number":42,"context_line":"    \u0027key\u0027: CONF.keystone_authtoken.keyfile,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class BaseContext(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f1f33172","line":43,"in_reply_to":"5f201791_79c88354","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def context_from_config():"},{"line_number":217,"context_line":"    admin_user_auth \u003d conf.load_from_conf_options("},{"line_number":218,"context_line":"        CONF, \u0027keystone_authtoken\u0027)"},{"line_number":219,"context_line":"    keystone \u003d load_client(admin_user_auth)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    keystone.authenticate()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_39c20b35","line":218,"range":{"start_line":218,"start_character":33,"end_line":218,"end_character":35},"updated":"2017-06-21 10:46:51.000000000","message":"Please use loading.load_auth_from_conf_options","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def context_from_config():"},{"line_number":217,"context_line":"    admin_user_auth \u003d conf.load_from_conf_options("},{"line_number":218,"context_line":"        CONF, \u0027keystone_authtoken\u0027)"},{"line_number":219,"context_line":"    keystone \u003d load_client(admin_user_auth)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    keystone.authenticate()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_31e08996","line":218,"range":{"start_line":218,"start_character":33,"end_line":218,"end_character":35},"in_reply_to":"5f201791_39c20b35","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        project_id\u003dkeystone.project_id,"},{"line_number":226,"context_line":"        auth_token\u003dkeystone.auth_token,"},{"line_number":227,"context_line":"        project_name\u003dkeystone.project_name,"},{"line_number":228,"context_line":"        user_name\u003dkeystone.username,"},{"line_number":229,"context_line":"        is_trust_scoped\u003dFalse,"},{"line_number":230,"context_line":"    )"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_99f91f82","line":228,"range":{"start_line":228,"start_character":35,"end_line":228,"end_character":36},"updated":"2017-06-21 10:46:51.000000000","message":"Are you sure it is properly Keystone v3 compliant? e.g. there are ids already there, why need names without domains? I think    \n\n- use only ids\n- or add the domains, too","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        project_id\u003dkeystone.project_id,"},{"line_number":226,"context_line":"        auth_token\u003dkeystone.auth_token,"},{"line_number":227,"context_line":"        project_name\u003dkeystone.project_name,"},{"line_number":228,"context_line":"        user_name\u003dkeystone.username,"},{"line_number":229,"context_line":"        is_trust_scoped\u003dFalse,"},{"line_number":230,"context_line":"    )"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f1669129","line":228,"range":{"start_line":228,"start_character":35,"end_line":228,"end_character":36},"in_reply_to":"5f201791_99f91f82","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":309,"context_line":"def load_client(plugin):"},{"line_number":310,"context_line":"    # load client from auth settings and user plugin"},{"line_number":311,"context_line":"    sess \u003d session.Session().load_from_options("},{"line_number":312,"context_line":"        auth\u003dplugin, **ssl_settings)"},{"line_number":313,"context_line":"    return ks_client.Client(session\u003dsess)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_f9bc93bc","line":312,"range":{"start_line":312,"start_character":35,"end_line":312,"end_character":36},"updated":"2017-06-21 10:46:51.000000000","message":"Why do you need ssl_settings? These are handled by the load_from_options, if you give it the config sections. Also use load_session_from_conf options.\n\nloading.load_session_from_conf_options(CONF, \u0027keystone_authtoken\u0027, auth\u003dplugin)","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":309,"context_line":"def load_client(plugin):"},{"line_number":310,"context_line":"    # load client from auth settings and user plugin"},{"line_number":311,"context_line":"    sess \u003d session.Session().load_from_options("},{"line_number":312,"context_line":"        auth\u003dplugin, **ssl_settings)"},{"line_number":313,"context_line":"    return ks_client.Client(session\u003dsess)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_31a76952","line":312,"range":{"start_line":312,"start_character":35,"end_line":312,"end_character":36},"in_reply_to":"5f201791_f9bc93bc","updated":"2017-06-23 23:03:14.000000000","message":"You know, it\u0027s a hard question... When I was implementing trust support for Glance, they recommended me to use ssl_settings: https://github.com/openstack/glance/blob/master/glance/common/trust_auth.py#L39-L44\n\nAnyway, I removed the ssl dict like you suggested, hope it will be okay :)","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"046f2994c347ec85e65a181522482d3c637cf41f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone, project_name\u003dNone):"},{"line_number":48,"context_line":"    # first try auth_uri, if it\u0027s not set use auth_url instead"},{"line_number":49,"context_line":"    auth_url \u003d (CONF.keystone_authtoken.auth_uri or"},{"line_number":50,"context_line":"                CONF.keystone_authtoken.auth_url),"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    cl \u003d ks_client.Client("},{"line_number":53,"context_line":"        username\u003dCONF.keystone_authtoken.admin_user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_e3810afd","line":50,"range":{"start_line":50,"start_character":49,"end_line":50,"end_character":50},"updated":"2017-06-15 02:02:11.000000000","message":"remove this","commit_id":"5265655611ec5fa51d0d7b9245f4e6300d88b9fc"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneauth1.loading import conf"},{"line_number":17,"context_line":"from keystoneauth1.loading import session"},{"line_number":18,"context_line":"from keystoneclient import service_catalog as ks_service_catalog"},{"line_number":19,"context_line":"from keystoneclient.v3 import client as ks_client"},{"line_number":20,"context_line":"from keystoneclient.v3 import endpoints as ks_endpoints"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_7924030e","line":17,"updated":"2017-06-21 10:46:51.000000000","message":"Just use loading","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneauth1.loading import conf"},{"line_number":17,"context_line":"from keystoneauth1.loading import session"},{"line_number":18,"context_line":"from keystoneclient import service_catalog as ks_service_catalog"},{"line_number":19,"context_line":"from keystoneclient.v3 import client as ks_client"},{"line_number":20,"context_line":"from keystoneclient.v3 import endpoints as ks_endpoints"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_ec3a3496","line":17,"in_reply_to":"5f201791_7924030e","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone):"},{"line_number":48,"context_line":"    admin_user_auth \u003d conf.load_from_conf_options("},{"line_number":49,"context_line":"        CONF, \u0027keystone_authtoken\u0027, trust_id\u003dtrust_id)"},{"line_number":50,"context_line":"    return context.load_client(admin_user_auth)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_996c7f37","line":49,"updated":"2017-06-21 10:46:51.000000000","message":"loading.load_auth_from_conf_options","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone):"},{"line_number":48,"context_line":"    admin_user_auth \u003d conf.load_from_conf_options("},{"line_number":49,"context_line":"        CONF, \u0027keystone_authtoken\u0027, trust_id\u003dtrust_id)"},{"line_number":50,"context_line":"    return context.load_client(admin_user_auth)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_8c4bc029","line":49,"in_reply_to":"5f201791_996c7f37","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"dc10d112df1b0701e50a9dd5e49cc84bf39cc8cc","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    auth \u003d conf.load_from_conf_options(CONF, \u0027keystone_authtoken\u0027)"},{"line_number":182,"context_line":"    return session.Session().load_from_options("},{"line_number":183,"context_line":"        auth\u003dauth, **context.ssl_settings)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def will_expire_soon(expires_at):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_b9605b34","line":183,"updated":"2017-06-21 10:46:51.000000000","message":"loading.load_session_from_conf_options(CONF, \u0027keystone_authtoken\u0027, auth\u003dauth)","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8db68c799c44a815b6b7f1f30af78ab88967ab02","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    auth \u003d conf.load_from_conf_options(CONF, \u0027keystone_authtoken\u0027)"},{"line_number":182,"context_line":"    return session.Session().load_from_options("},{"line_number":183,"context_line":"        auth\u003dauth, **context.ssl_settings)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def will_expire_soon(expires_at):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_6c462424","line":183,"in_reply_to":"5f201791_b9605b34","updated":"2017-06-23 23:03:14.000000000","message":"Done","commit_id":"0f6cc9f1c47982b99543eb505feee8159b82188a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"535f0f7d0888be99dd6495154c62b0c774324276","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone):"},{"line_number":48,"context_line":"    plugin \u003d loading.load_auth_from_conf_options("},{"line_number":49,"context_line":"        CONF, \u0027keystone_authtoken\u0027, trust_id\u003dtrust_id)"},{"line_number":50,"context_line":"    sess \u003d loading.load_session_from_conf_options("},{"line_number":51,"context_line":"        CONF, \u0027keystone_authtoken\u0027, auth\u003dplugin)"},{"line_number":52,"context_line":"    return ks_client.Client(session\u003dsess)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_747f0615","line":49,"range":{"start_line":49,"start_character":53,"end_line":49,"end_character":54},"updated":"2017-06-24 19:48:32.000000000","message":"Are you sure this works? Last time passing trust_id with project_name failed in keystone (since you can request a trust scoped token or project scoped one, but not both at the same time). There was a similar thing in Murano:\nhttps://review.openstack.org/#/c/331818/11/murano/common/auth_utils.py\nLine #50","commit_id":"cb56f95bfe842893cc617f9b22ef8b5fafbc8297"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"2460759d07d73c05e0f624157a428f2da24d6afc","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def get_admin_session():"},{"line_number":181,"context_line":"    \"\"\"Returns a keystone session from Mistral\u0027s service credentials.\"\"\""},{"line_number":182,"context_line":"    return loading.load_session_from_conf_options(CONF, \u0027keystone_authtoken\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def will_expire_soon(expires_at):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_74a4a6a6","line":182,"updated":"2017-06-24 19:53:03.000000000","message":"I think the auth is missing here. This function is mostly the same as _admin_client, except the last line, and trust_id\u003dNone.","commit_id":"cb56f95bfe842893cc617f9b22ef8b5fafbc8297"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2c51cb38dae890df926f4758261cd7b4cca7830c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone):"},{"line_number":48,"context_line":"    kwargs \u003d {}"},{"line_number":49,"context_line":"    if trust_id:"},{"line_number":50,"context_line":"        # Remove project_name and project_id, since we need a trust scoped"},{"line_number":51,"context_line":"        # auth object"},{"line_number":52,"context_line":"        kwargs[\u0027project_name\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_89dfce67","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":6},"updated":"2017-06-28 04:17:01.000000000","message":"Just some nit things (not critical for giving +2) that we usually follow:\n\n* All comments in the code should be compliant with regular English grammar (e.g. start with a capital and end with a period, exact names of abstractions in quotes and if they are mentioned in the free form then using their natural names)\n* Put a blank line before \"if\", \"try\", \"for\", \"return\" etc. to split control structure from the rest of the code\n* Put a blank line after the blocks generated by control structures listed above (except \"return\")\n* if we have to write a method call on multiple lines we usually use the form:\n   \n    my_method(\n      param1,\n      param2,\n      ...\n      paramN\n    )\n\nIt\u0027s not a strict requirement to follow these guidelines because these are rather informal conventions for now. But if you happen to send another patchset you can fix these things. Or start following these rules in your next patch.","commit_id":"8bf92bd2222484f11c0702e66a35428b1fefec12"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"6f48f2736bc85686e990b171a27471356814c773","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _admin_client(trust_id\u003dNone):"},{"line_number":48,"context_line":"    kwargs \u003d {}"},{"line_number":49,"context_line":"    if trust_id:"},{"line_number":50,"context_line":"        # Remove project_name and project_id, since we need a trust scoped"},{"line_number":51,"context_line":"        # auth object"},{"line_number":52,"context_line":"        kwargs[\u0027project_name\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_da910549","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":6},"in_reply_to":"5f201791_89dfce67","updated":"2017-06-28 06:49:16.000000000","message":"Done","commit_id":"8bf92bd2222484f11c0702e66a35428b1fefec12"}]}
