)]}'
{"mistral/serialization.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"60bc5bb3579adeb8679f51b7050201523ca24ddc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        raise NotImplementedError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class MistralSerializable(object):"},{"line_number":91,"context_line":"    \"\"\"A mixin to generate a serialization key for a custom object.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_4da536a1","side":"PARENT","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":25},"updated":"2017-06-19 08:20:41.000000000","message":"Why did you remove only MistralSerializable? The entire serialization.py module is already in mistral-lib, I thought we could use it from there.","commit_id":"3e1ffeeaaaeed5f076c0807f277ad2f9623be3d8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d698169f9e524a2278a5cbf72ba664d26e5e2d5d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        raise NotImplementedError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class MistralSerializable(object):"},{"line_number":91,"context_line":"    \"\"\"A mixin to generate a serialization key for a custom object.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_08e3aca5","side":"PARENT","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":25},"in_reply_to":"7f231b9d_283e68b7","updated":"2017-06-19 09:03:15.000000000","message":"Ok, I think I understood. We\u0027ll need to make sure to remove it completely when it\u0027s possible. How about leaving a comment for now at least?","commit_id":"3e1ffeeaaaeed5f076c0807f277ad2f9623be3d8"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"6f06f4a66cab2ff52a2408d5961146cfa3c41c80","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        raise NotImplementedError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class MistralSerializable(object):"},{"line_number":91,"context_line":"    \"\"\"A mixin to generate a serialization key for a custom object.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_283e68b7","side":"PARENT","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":25},"in_reply_to":"7f231b9d_4da536a1","updated":"2017-06-19 08:38:24.000000000","message":"That is the plan to remove this and use the mistral-lib one, but mistral-lib serializations is missing the unsubscribe funtionality.\n\nI\u0027m adding it there but this change is needed for similar changes (as in using mistral-lib results in tripleo-common for example) and getting this in as it is would allow to paralelize the work without it being blocked waiting for mistral-lib version bump and promotion","commit_id":"3e1ffeeaaaeed5f076c0807f277ad2f9623be3d8"}],"mistral/workflow/utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"60bc5bb3579adeb8679f51b7050201523ca24ddc","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from mistral import serialization"},{"line_number":18,"context_line":"from mistral_lib.actions.types import Result"},{"line_number":19,"context_line":"from mistral_lib.actions.types import ResultSerializer"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"serialization.register_serializer(Result, ResultSerializer())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_ad304a57","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"updated":"2017-06-19 08:20:41.000000000","message":"Do we now need this module at all?","commit_id":"717bebbeb8a133bd73ea930404425c4e4ab595dc"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"6f06f4a66cab2ff52a2408d5961146cfa3c41c80","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from mistral import serialization"},{"line_number":18,"context_line":"from mistral_lib.actions.types import Result"},{"line_number":19,"context_line":"from mistral_lib.actions.types import ResultSerializer"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"serialization.register_serializer(Result, ResultSerializer())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_cd1ca679","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"in_reply_to":"7f231b9d_ad304a57","updated":"2017-06-19 08:38:24.000000000","message":"The issue is registering the Result in the serializing infrastructure I thought it would be simpler to do it here and keep backwards compatibility since it didn\u0027t break (the backwards compatibility) as the mistral-lib actions that changed the signature","commit_id":"717bebbeb8a133bd73ea930404425c4e4ab595dc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d698169f9e524a2278a5cbf72ba664d26e5e2d5d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from mistral import serialization"},{"line_number":18,"context_line":"from mistral_lib.actions.types import Result"},{"line_number":19,"context_line":"from mistral_lib.actions.types import ResultSerializer"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"serialization.register_serializer(Result, ResultSerializer())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_c865b41f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"in_reply_to":"7f231b9d_cd1ca679","updated":"2017-06-19 09:03:15.000000000","message":"Well, ok, I think we really shouldn\u0027t register anything from within a library. So, that\u0027s ok for now.\n\nJust one more thing: according to OpenStack rules we should always import modules, not classes. Fix it please.","commit_id":"717bebbeb8a133bd73ea930404425c4e4ab595dc"}]}