)]}'
{"mistral/services/triggers.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"78da37ea2ba2e2ed66a6d7ffe42613287b6a21eb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"    if first_time:"},{"line_number":47,"context_line":"        sum_time \u003d datetime.datetime.utcnow() + datetime.timedelta(0, 60)"},{"line_number":48,"context_line":"        if sum_time \u003e first_time:"},{"line_number":49,"context_line":"            raise exc.InvalidModelException("},{"line_number":50,"context_line":"                \u0027first_execution_time must be at least 1 minute in the future.\u0027"},{"line_number":51,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_cc258fad","line":48,"range":{"start_line":48,"start_character":11,"end_line":48,"end_character":19},"updated":"2017-07-21 00:37:16.000000000","message":"Also, can you rename this var to something like \u0027valid_min_time\u0027 to be more clear.","commit_id":"5ea8964c39fda3d9e46eee4c51e1e35a9d7c7cd6"}],"mistral/tests/unit/engine/test_cron_trigger.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"48660859791c0e7b2efd03dd37268981490c8146","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_validate_cron_trigger_input_first_time(self):"},{"line_number":179,"context_line":"        cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":180,"context_line":"        first_time \u003d datetime.datetime.utcnow() + datetime.timedelta(0, 1)"},{"line_number":181,"context_line":"        self.assertRaises(exc.InvalidModelException,"},{"line_number":182,"context_line":"                          triggers.validate_cron_trigger_input,"},{"line_number":183,"context_line":"                          None,"},{"line_number":184,"context_line":"                          first_time,"},{"line_number":185,"context_line":"                          None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_25363de8","line":185,"range":{"start_line":179,"start_character":8,"end_line":185,"end_character":31},"updated":"2017-07-25 08:45:10.000000000","message":"This test checks that the method raises an exception if the time that we pass is not at least one minute in the future. But can we somehow validate you UTC conversion related changes?","commit_id":"ffd05113dd5d704f8b0109e3d99f8e319a062429"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"c1fc1c9d601197ac55727ff77065a5a88bcd4514","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_validate_cron_trigger_input_first_time(self):"},{"line_number":179,"context_line":"        cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":180,"context_line":"        first_time \u003d datetime.datetime.utcnow() + datetime.timedelta(0, 1)"},{"line_number":181,"context_line":"        self.assertRaises(exc.InvalidModelException,"},{"line_number":182,"context_line":"                          triggers.validate_cron_trigger_input,"},{"line_number":183,"context_line":"                          None,"},{"line_number":184,"context_line":"                          first_time,"},{"line_number":185,"context_line":"                          None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_c4fcbeb6","line":185,"range":{"start_line":179,"start_character":8,"end_line":185,"end_character":31},"in_reply_to":"ff346bd7_1b227c01","updated":"2017-07-27 07:56:56.000000000","message":"Ooh, ok. I misunderstood this in the first place.","commit_id":"ffd05113dd5d704f8b0109e3d99f8e319a062429"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"ffbc3022c9bdd74aba95ad38c837949593339c80","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_validate_cron_trigger_input_first_time(self):"},{"line_number":179,"context_line":"        cfg.CONF.set_default(\u0027auth_enable\u0027, False, group\u003d\u0027pecan\u0027)"},{"line_number":180,"context_line":"        first_time \u003d datetime.datetime.utcnow() + datetime.timedelta(0, 1)"},{"line_number":181,"context_line":"        self.assertRaises(exc.InvalidModelException,"},{"line_number":182,"context_line":"                          triggers.validate_cron_trigger_input,"},{"line_number":183,"context_line":"                          None,"},{"line_number":184,"context_line":"                          first_time,"},{"line_number":185,"context_line":"                          None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_1b227c01","line":185,"range":{"start_line":179,"start_character":8,"end_line":185,"end_character":31},"in_reply_to":"ff346bd7_25363de8","updated":"2017-07-25 09:39:32.000000000","message":"Do you want to say that \nThe first_time value is UTC or not ? \n\nIf first_time is UTC time then only we should call the function validate_cron_trigger_input.\n\nBut,\nThere is no change related to UTC time conversation in this patch, the first_time what we get in validate_cron_trigger_input is a UTC time from the REST API or from command line","commit_id":"ffd05113dd5d704f8b0109e3d99f8e319a062429"}]}