)]}'
{"mistral/db/v2/sqlalchemy/models.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"73ac3718e57577a582acfb1495387a8ca4da4dbf","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"# Many-to-one for \u0027WorkflowExecution\u0027 and \u0027WorkflowExecution\u0027"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"WorkflowExecution.root_execution_id \u003d sa.Column("},{"line_number":323,"context_line":"    sa.String(36),"},{"line_number":324,"context_line":"    sa.ForeignKey(WorkflowExecution.id, ondelete\u003d\u0027SET NULL\u0027),"},{"line_number":325,"context_line":"    nullable\u003dTrue"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_0c266b16","line":322,"range":{"start_line":322,"start_character":18,"end_line":322,"end_character":35},"updated":"2017-08-03 15:54:05.000000000","message":"What about naming it \"parent_execution_id\"?","commit_id":"565ef6eca08cbde4268ed1d56338b2dd80c5a886"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7124a8949596f83dc740bf0bda412bff46d663f7","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"# Many-to-one for \u0027WorkflowExecution\u0027 and \u0027WorkflowExecution\u0027"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"WorkflowExecution.root_execution_id \u003d sa.Column("},{"line_number":323,"context_line":"    sa.String(36),"},{"line_number":324,"context_line":"    sa.ForeignKey(WorkflowExecution.id, ondelete\u003d\u0027SET NULL\u0027),"},{"line_number":325,"context_line":"    nullable\u003dTrue"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_4c48f385","line":322,"range":{"start_line":322,"start_character":18,"end_line":322,"end_character":35},"in_reply_to":"df3967d1_0c266b16","updated":"2017-08-03 16:00:45.000000000","message":"I think parent could be confusing. Given A -\u003e B -\u003e C. The parent of C is B, but the root is A.","commit_id":"565ef6eca08cbde4268ed1d56338b2dd80c5a886"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"7df2425a2693c3373907fe59fd7f708b918d3927","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"# Many-to-one for \u0027WorkflowExecution\u0027 and \u0027WorkflowExecution\u0027"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"WorkflowExecution.root_execution_id \u003d sa.Column("},{"line_number":323,"context_line":"    sa.String(36),"},{"line_number":324,"context_line":"    sa.ForeignKey(WorkflowExecution.id, ondelete\u003d\u0027SET NULL\u0027),"},{"line_number":325,"context_line":"    nullable\u003dTrue"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_177c381d","line":322,"range":{"start_line":322,"start_character":18,"end_line":322,"end_character":35},"in_reply_to":"df3967d1_4c48f385","updated":"2017-08-03 16:14:27.000000000","message":"Aah, ok. I\u0027ve confused it with parent exactly. Sorry. Then root id is ok.","commit_id":"565ef6eca08cbde4268ed1d56338b2dd80c5a886"}],"mistral/engine/actions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"779c7f81f5044c7999f95b93130c4447dabb6f8d","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        )"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        wf_params \u003d {"},{"line_number":506,"context_line":"            \u0027root_execution\u0027: parent_wf_ex.root_execution_id or parent_wf_ex.id,"},{"line_number":507,"context_line":"            \u0027task_execution_id\u0027: self.task_ex.id,"},{"line_number":508,"context_line":"            \u0027index\u0027: index,"},{"line_number":509,"context_line":"            \u0027namespace\u0027: parent_wf_ex.params[\u0027namespace\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_7e000fac","line":506,"updated":"2017-08-03 08:08:20.000000000","message":"I probably need to explain this in a comment - if the parent doesn\u0027t have a root_execution, it is the root - so we use it\u0027s id instead.","commit_id":"515c70822decf7ffa8bd1b51d4e428551ee8ebec"}],"mistral/tests/unit/engine/test_subworkflows.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"dc86c971d8963165f5f8142fc25d473bb84f8d5b","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            wf3_ex \u003d db_api.get_workflow_execution(wf3_ex.id)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        self.assertEqual(wf1_ex.root_execution_id, None)"},{"line_number":311,"context_line":"        self.assertEqual(wf2_ex.root_execution_id, wf1_ex.id)"},{"line_number":312,"context_line":"        self.assertEqual(wf3_ex.root_execution_id, wf1_ex.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_43ec468e","line":311,"updated":"2017-08-03 14:56:20.000000000","message":"This test fails here, which is odd. I get something like:\n\n    testtools.matchers._impl.MismatchError: None !\u003d \u0027e3ced88d-d858-45e0-8a5c-102adc191ed5\u0027\n\nSo the root_execution_id is None for all executions - it isn\u0027t being set for some reason.","commit_id":"d43832b578d2087af6305c88df57d47034f2b2a1"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"e2dd02a6dd95c31c524d4eceeaf5dfddd07cbe8c","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"workflows:"},{"line_number":106,"context_line":"  wf1:"},{"line_number":107,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c d3aba12846a0338e3ca657b6405145db6eda2d8d"},{"line_number":108,"context_line":"    input:"},{"line_number":109,"context_line":"      - wf_name"},{"line_number":110,"context_line":"    output:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_e0bcd96d","line":107,"updated":"2017-08-18 08:15:23.000000000","message":"oops","commit_id":"fa2869f3c7ed2c8bd73b61c34b6250e14e2c3ac4"}]}
