)]}'
{"mistral/engine/workflows.py":[{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"a704649165d8c99533fac572d27d970e4e432140","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        total_output_length \u003d utils.get_number_of_chars_from_kilobytes("},{"line_number":391,"context_line":"            cfg.CONF.engine.execution_field_size_limit_kb)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if length_output_on_error \u003c total_output_length:"},{"line_number":394,"context_line":"            msg \u003d utils.cut_by_char("},{"line_number":395,"context_line":"                msg,"},{"line_number":396,"context_line":"                total_output_length - length_output_on_error"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_46de5dda","line":393,"updated":"2017-08-16 08:52:07.000000000","message":"len(str()) is going to give false values for unicode chars.\n\nIn [6]: len(str(\"ą\"))\nOut[6]: 1\n\nIn [7]: len(str(\"a\"))\nOut[7]: 1\n\nYou probably have to encode them for it to give reliable results \n\nIn [8]: len(str(\"a\").encode(\"utf-8\"))\nOut[8]: 1\n\nIn [9]: len(str(\"ą\").encode(\"utf-8\"))\nOut[9]: 2","commit_id":"b85c22e5c1ef72f922be2bc17ea51d92e6c7ee50"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"23c27fd7ed33ecd7d12f7e50c2be27f6c841893c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        total_output_length \u003d utils.get_number_of_chars_from_kilobytes("},{"line_number":391,"context_line":"            cfg.CONF.engine.execution_field_size_limit_kb)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if length_output_on_error \u003c total_output_length:"},{"line_number":394,"context_line":"            msg \u003d utils.cut_by_char("},{"line_number":395,"context_line":"                msg,"},{"line_number":396,"context_line":"                total_output_length - length_output_on_error"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_5cef4ae8","line":393,"in_reply_to":"9f436f4f_46de5dda","updated":"2017-08-16 09:48:50.000000000","message":"Done","commit_id":"b85c22e5c1ef72f922be2bc17ea51d92e6c7ee50"}],"mistral/tests/unit/engine/test_dataflow.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"962c36a51050719c175d7d7c3666366895b85eb9","unresolved":false,"context_lines":[{"line_number":680,"context_line":""},{"line_number":681,"context_line":"          tasks:"},{"line_number":682,"context_line":"            task1:"},{"line_number":683,"context_line":"              action: wrong.task"},{"line_number":684,"context_line":"        \"\"\""},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        cfg.CONF.set_default("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_316d4b98","line":683,"range":{"start_line":683,"start_character":28,"end_line":683,"end_character":32},"updated":"2018-02-06 09:37:51.000000000","message":"rather \"action\" but that\u0027s not so important.","commit_id":"ef780c8f6d3e4ead388e1e9d6f110d817d970b47"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"962c36a51050719c175d7d7c3666366895b85eb9","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        cfg.CONF.set_default("},{"line_number":687,"context_line":"            \u0027execution_field_size_limit_kb\u0027,"},{"line_number":688,"context_line":"            1121,"},{"line_number":689,"context_line":"            group\u003d\u0027engine\u0027"},{"line_number":690,"context_line":"        )"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_51ffb7a9","line":688,"range":{"start_line":688,"start_character":12,"end_line":688,"end_character":16},"updated":"2018-02-06 09:37:51.000000000","message":"Can you explain this number? How is it related to the length of you test error string \"The action in the task does not exists\"?\n\nIt\u0027s kilobytes, so in characters it should be a much bigger number than the length of this string.","commit_id":"ef780c8f6d3e4ead388e1e9d6f110d817d970b47"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2d8a128e2387ed48ff2ce24f8dd59a14954d04ef","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        cfg.CONF.set_default("},{"line_number":687,"context_line":"            \u0027execution_field_size_limit_kb\u0027,"},{"line_number":688,"context_line":"            1121,"},{"line_number":689,"context_line":"            group\u003d\u0027engine\u0027"},{"line_number":690,"context_line":"        )"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_c902290a","line":688,"range":{"start_line":688,"start_character":12,"end_line":688,"end_character":16},"in_reply_to":"3fa0c359_1822afa5","updated":"2018-02-07 06:33:24.000000000","message":"Ooh, ok.\n\nThe key is in the phrase \"the orignal error some string + custom error gets added in the workflow output error\"\n\nBut it\u0027s really not clear from the code of the test. Can you please at least leave the comment that explains why exactly this number is chosen?","commit_id":"ef780c8f6d3e4ead388e1e9d6f110d817d970b47"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"135d4388c1a7a48468120d81c8362174e969b37d","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        cfg.CONF.set_default("},{"line_number":687,"context_line":"            \u0027execution_field_size_limit_kb\u0027,"},{"line_number":688,"context_line":"            1121,"},{"line_number":689,"context_line":"            group\u003d\u0027engine\u0027"},{"line_number":690,"context_line":"        )"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_1822afa5","line":688,"range":{"start_line":688,"start_character":12,"end_line":688,"end_character":16},"in_reply_to":"3fa0c359_51ffb7a9","updated":"2018-02-06 13:35:29.000000000","message":"As far I remember, I wanted to take the number which is greater than 1024 bytes and random, but I guess that kilobytes will be converted into get a length of total characters , \n \nnow what we are testing is \nlen(custom error) \u003c total length of characters\n\nNow what happens is when you get an error , the orignal error some string + custom error gets added in the workflow output error\n\nat that time, when I test I think it crossed some total 1121 before this code change.","commit_id":"ef780c8f6d3e4ead388e1e9d6f110d817d970b47"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"97810240749bd25ff60ffc93e8f1f43014d84fd7","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        cfg.CONF.set_default("},{"line_number":687,"context_line":"            \u0027execution_field_size_limit_kb\u0027,"},{"line_number":688,"context_line":"            1121,"},{"line_number":689,"context_line":"            group\u003d\u0027engine\u0027"},{"line_number":690,"context_line":"        )"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_d48dd931","line":688,"range":{"start_line":688,"start_character":12,"end_line":688,"end_character":16},"in_reply_to":"3fa0c359_c902290a","updated":"2018-02-07 09:20:23.000000000","message":"Done","commit_id":"ef780c8f6d3e4ead388e1e9d6f110d817d970b47"}],"mistral/utils/__init__.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f91bb1042d6bf6c7f2ddccfb96640aaf0a88e52f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    if kilobytes \u003c\u003d 0:"},{"line_number":312,"context_line":"        return cut(data)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    length \u003d get_length_from_kilobytes(kilobytes)"},{"line_number":315,"context_line":"    return cut(data, length)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_b413a566","line":314,"range":{"start_line":314,"start_character":13,"end_line":314,"end_character":38},"updated":"2017-08-09 06:56:51.000000000","message":"Why did you decide to make a new method? Is it used somewhere else? Usually it makes sense to create a method for something simple like this that repeats more than one time.","commit_id":"cde9e8b3a789f90ed5ab83f941dd98cb73414d85"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"d6c879f92dc37b4a83841a4467c0774654fb87fb","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    if kilobytes \u003c\u003d 0:"},{"line_number":312,"context_line":"        return cut(data)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    length \u003d get_length_from_kilobytes(kilobytes)"},{"line_number":315,"context_line":"    return cut(data, length)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_89139f5c","line":314,"range":{"start_line":314,"start_character":13,"end_line":314,"end_character":38},"in_reply_to":"9f436f4f_b413a566","updated":"2017-08-11 10:45:54.000000000","message":"Because , I was using this method at two places and I don\u0027t wan\u0027t to duplicate this lines. \nIt was used in the other file workflows.py in the this patch.","commit_id":"cde9e8b3a789f90ed5ab83f941dd98cb73414d85"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f91bb1042d6bf6c7f2ddccfb96640aaf0a88e52f","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    return cut(data, length)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"def get_length_from_kilobytes(kilobytes):"},{"line_number":319,"context_line":"    bytes_per_char \u003d sys.getsizeof(\u0027s\u0027) - sys.getsizeof(\u0027\u0027)"},{"line_number":320,"context_line":"    length \u003d int(kilobytes * 1024 / bytes_per_char)"},{"line_number":321,"context_line":"    return length"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_944ae17d","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":29},"updated":"2017-08-09 06:56:51.000000000","message":"It\u0027s not the best for a public method. Just looking at it it\u0027s hard to guess what it is about. Length of what?\n\nBtw, I think other method names in this module could be better too (e.g. cut_by_kb) but it\u0027s a different task probably.","commit_id":"cde9e8b3a789f90ed5ab83f941dd98cb73414d85"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"d6c879f92dc37b4a83841a4467c0774654fb87fb","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    return cut(data, length)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"def get_length_from_kilobytes(kilobytes):"},{"line_number":319,"context_line":"    bytes_per_char \u003d sys.getsizeof(\u0027s\u0027) - sys.getsizeof(\u0027\u0027)"},{"line_number":320,"context_line":"    length \u003d int(kilobytes * 1024 / bytes_per_char)"},{"line_number":321,"context_line":"    return length"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_094e8f6e","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":29},"in_reply_to":"9f436f4f_944ae17d","updated":"2017-08-11 10:45:54.000000000","message":"The naming convention i have picked from this file only. there are many methods which has a prefix of `get_XXXX`.\nAnyway , I have renamed the method so that it will be more clear. Please check the patch set 3.","commit_id":"cde9e8b3a789f90ed5ab83f941dd98cb73414d85"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"cc8c9a355f759c5602fcf67e233bc58c894de755","unresolved":false,"context_lines":[{"line_number":376,"context_line":"def get_number_of_chars_from_kilobytes(kilobytes):"},{"line_number":377,"context_line":"    bytes_per_char \u003d sys.getsizeof(\u0027s\u0027) - sys.getsizeof(\u0027\u0027)"},{"line_number":378,"context_line":"    total_number_of_chars \u003d int(kilobytes * 1024 / bytes_per_char)"},{"line_number":379,"context_line":"    return total_number_of_chars"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"def get_dict_from_string(string, delimiter\u003d\u0027,\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_449fde5e","line":379,"updated":"2017-08-11 11:30:46.000000000","message":"This is function is duplicated from above?","commit_id":"f7e33ce3337bce6f93b03778fb1e7e244b9c0c58"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"6ff2e4cdd60f7bf8dae28844fc5ce30a9b4d4d15","unresolved":false,"context_lines":[{"line_number":376,"context_line":"def get_number_of_chars_from_kilobytes(kilobytes):"},{"line_number":377,"context_line":"    bytes_per_char \u003d sys.getsizeof(\u0027s\u0027) - sys.getsizeof(\u0027\u0027)"},{"line_number":378,"context_line":"    total_number_of_chars \u003d int(kilobytes * 1024 / bytes_per_char)"},{"line_number":379,"context_line":"    return total_number_of_chars"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"def get_dict_from_string(string, delimiter\u003d\u0027,\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_f9d8a77b","line":379,"in_reply_to":"9f436f4f_449fde5e","updated":"2017-08-11 20:28:25.000000000","message":"Thanks, It was my Mistake.","commit_id":"f7e33ce3337bce6f93b03778fb1e7e244b9c0c58"}]}