)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"ef7d8b289936758d866b5665948da2016987c248","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Hide env from logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This logging info is leaking sensitive content from the env"},{"line_number":10,"context_line":"That data makes sense to be logged only for debug level"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If1b71590c0904182bb8052c3e942131e57494825"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_92bdee03","line":10,"updated":"2017-08-28 07:32:51.000000000","message":"A second, and I think, more important reason is the potential size of the env too.","commit_id":"adaccc2dabe61c2bef06067dd431026efef919ff"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2197097203e60baf33062538eef0104bba7161d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This logging info is leaking sensitive content from the env"},{"line_number":10,"context_line":"That data makes sense to be logged only for debug level"},{"line_number":11,"context_line":"Envs can have up to 2GB so I added a cut to it"},{"line_number":12,"context_line":"I\u0027ve changed all calls to log.info on the RestControllers to debug"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If1b71590c0904182bb8052c3e942131e57494825"},{"line_number":15,"context_line":"Closes-Bug: #1714236"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df87a7cf_d01181ae","line":12,"updated":"2017-12-14 08:39:15.000000000","message":"Oh, I see you added this line at the end. I would re-write this commit message, this last line is really what the change is now.","commit_id":"49af48a1dccf902ffec31df4e5f51ce74d11be2b"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"8d413956f474c04d56b2ca723c2286f4d85b0e1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This logging info is leaking sensitive content from the env"},{"line_number":10,"context_line":"That data makes sense to be logged only for debug level"},{"line_number":11,"context_line":"Envs can have up to 2GB so I added a cut to it"},{"line_number":12,"context_line":"I\u0027ve changed all calls to log.info on the RestControllers to debug"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If1b71590c0904182bb8052c3e942131e57494825"},{"line_number":15,"context_line":"Closes-Bug: #1714236"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df87a7cf_cbb0ef8e","line":12,"in_reply_to":"df87a7cf_d01181ae","updated":"2017-12-14 10:19:20.000000000","message":"Done","commit_id":"49af48a1dccf902ffec31df4e5f51ce74d11be2b"}],"mistral/api/controllers/v2/action.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"b665e574dc79285d7e31c527e2efc16027cabe3d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        acl.enforce(\u0027actions:get\u0027, context.ctx())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        LOG.debug(\"Fetch action [identifier\u003d%s]\", identifier)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Use retries to prevent possible failures."},{"line_number":61,"context_line":"        r \u003d rest_utils.create_db_retry_object()"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_101849d1","line":58,"updated":"2017-12-14 08:37:53.000000000","message":"I\u0027m a bit confused, this doesn\u0027t relate to the commit message - what is the motivation for changing so many of these?","commit_id":"49af48a1dccf902ffec31df4e5f51ce74d11be2b"}],"mistral/api/controllers/v2/environment.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"acd7a14dcd91b8dbfae1b5b646f0b2eadb9bbee8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        acl.enforce(\u0027environments:create\u0027, context.ctx())"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        LOG.info(\"Create environment [env\u003d%s]\", env)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self._validate_environment("},{"line_number":133,"context_line":"            json.loads(wsme_pecan.pecan.request.body.decode()),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_98f9b3c9","side":"PARENT","line":130,"updated":"2017-08-25 13:05:13.000000000","message":"I would prefer changing this to LOG.debug and leaving the message as it is. Just logging \"Create environment\" isn\u0027t often useful, but at the same time, dumping the full environment to disk shouldn\u0027t happen at the INFO level imo.","commit_id":"1a8837b9d20ccfce59524abe6ccc8e8232a9810b"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a9ff420f095432cc3cfeee443eeec756cd5cc2b5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            scope\u003dscope"},{"line_number":84,"context_line":"        )"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        LOG.info(\"Fetch environments. marker\u003d%s, limit\u003d%s, sort_keys\u003d%s, \""},{"line_number":87,"context_line":"                 \"sort_dirs\u003d%s, filters\u003d%s\", marker, limit, sort_keys,"},{"line_number":88,"context_line":"                 sort_dirs, filters)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_1d6131aa","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":16},"updated":"2017-09-13 22:00:16.000000000","message":"Let\u0027s use \"debug\" here too.","commit_id":"afc868feee20879f659ea218a5fa82e0790f8921"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a9ff420f095432cc3cfeee443eeec756cd5cc2b5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        acl.enforce(\u0027environments:get\u0027, context.ctx())"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        LOG.info(\"Fetch environment [name\u003d%s]\", name)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        db_model \u003d db_api.get_environment(name)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_dd5a89f1","line":112,"range":{"start_line":112,"start_character":12,"end_line":112,"end_character":16},"updated":"2017-09-13 22:00:16.000000000","message":"And here.","commit_id":"afc868feee20879f659ea218a5fa82e0790f8921"}]}
