)]}'
{"mistral/lang/types.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"12785f7bce6c0d73a7bae784cd9665726a20035b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"minItems\": 1"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"TASKNAME \u003d {"},{"line_number":151,"context_line":"    \"type\": \"string\","},{"line_number":152,"context_line":"    \"pattern\": \"^\\w+$\""},{"line_number":153,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_3f296a9a","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":8},"updated":"2017-09-14 19:05:54.000000000","message":"Let\u0027s use underscores between words. So that it is TASK_NAME. Same thing about other new constants.","commit_id":"8d76f4c2e7e4f81a5159bc99840b47bedf2d7b97"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e6a7faa4954afb745799fb0b9c01dae8b3c66574","unresolved":false,"context_lines":[{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"TASK_NAME \u003d {"},{"line_number":152,"context_line":"    \"type\": \"string\","},{"line_number":153,"context_line":"    \"pattern\": \"^\\w+$\""},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"TASK_WITH_PARAMETER \u003d {"},{"line_number":157,"context_line":"    \"type\": \"string\","},{"line_number":158,"context_line":"    \"pattern\": \"^\\w+\\(.*\\)$\""},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"TASK_WITH_PARAMETER_LIST \u003d {"},{"line_number":162,"context_line":"    \"type\": \"array\","},{"line_number":163,"context_line":"    \"items\": TASK_WITH_PARAMETER"},{"line_number":164,"context_line":"}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"ONE_KEY_DICT_EXPRESSION \u003d {"},{"line_number":167,"context_line":"    \"type\": \"object\","},{"line_number":168,"context_line":"    \"minProperties\": 1,"},{"line_number":169,"context_line":"    \"maxProperties\": 1,"},{"line_number":170,"context_line":"    \"patternProperties\": {"},{"line_number":171,"context_line":"        \"^\\w+$\": EXPRESSION"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":"}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"TASK_NAME_OR_ONE_KEY_DICT_EXPRESSION \u003d {"},{"line_number":176,"context_line":"    \"oneOf\": ["},{"line_number":177,"context_line":"        TASK_NAME,"},{"line_number":178,"context_line":"        ONE_KEY_DICT_EXPRESSION"},{"line_number":179,"context_line":"    ]"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"UNIQUE_TASK_NAME_OR_ONE_KEY_DICT_EXPRESSION_LIST \u003d {"},{"line_number":183,"context_line":"    \"type\": \"array\","},{"line_number":184,"context_line":"    \"items\": TASK_NAME_OR_ONE_KEY_DICT_EXPRESSION,"},{"line_number":185,"context_line":"    \"uniqueItems\": True,"},{"line_number":186,"context_line":"    \"minItems\": 1"},{"line_number":187,"context_line":"}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"ADVANCED_PUBLISHING_DICT \u003d {"},{"line_number":190,"context_line":"    \"type\": \"object\","},{"line_number":191,"context_line":"    \"minProperties\": 1,"},{"line_number":192,"context_line":"    \"properties\": {"},{"line_number":193,"context_line":"        \"publish\": {\"type\": \"object\"},"},{"line_number":194,"context_line":"        \"next\": {"},{"line_number":195,"context_line":"            \"anyOf\": ["},{"line_number":196,"context_line":"                UNIQUE_TASK_NAME_OR_ONE_KEY_DICT_EXPRESSION_LIST,"},{"line_number":197,"context_line":"                TASK_NAME"},{"line_number":198,"context_line":"            ]"},{"line_number":199,"context_line":"        }"},{"line_number":200,"context_line":"    },"},{"line_number":201,"context_line":"    \"additionalProperties\": False"},{"line_number":202,"context_line":"}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"BRANCHING_OPTIONS \u003d {"},{"line_number":205,"context_line":"    \"anyOf\": ["},{"line_number":206,"context_line":"        ADVANCED_PUBLISHING_DICT,"},{"line_number":207,"context_line":"        TASK_NAME,"},{"line_number":208,"context_line":"        TASK_WITH_PARAMETER,"},{"line_number":209,"context_line":"        TASK_WITH_PARAMETER_LIST,"},{"line_number":210,"context_line":"        UNIQUE_TASK_NAME_OR_ONE_KEY_DICT_EXPRESSION_LIST"},{"line_number":211,"context_line":"    ]"},{"line_number":212,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_24d96056","line":212,"range":{"start_line":151,"start_character":0,"end_line":212,"end_character":1},"updated":"2017-10-09 02:41:46.000000000","message":"Sorry for not pointing this out during my first review but I think the last change we need to make in this patch is to move all things related to the task schema to task.py. Otherwise we slightly break encapsulation and scatter things related to one specific entity across the code. In our case we put it in a module called types.py which is supposed to be one of the base modules of the whole subsystem and shouldn\u0027t keep knowledge about specific entities, it should only provide commonly used building blocks.\n\nSo I think ONE_KEY_DICT_EXPRESSION can stay here.\n\nThe full schema for advanced publishing thing is already defined in OnClauseSpec. It would be nice to reuse it. Look at _schema property. All specs have the method get_spec() that you can use to get it.","commit_id":"ebfea525660fb9bd1fc15d341f8edb6c127a355d"}],"mistral/lang/v2/tasks.py":[{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"604459bf49047ddfa4c67f4b6baa5f8ec170f2ba","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            },"},{"line_number":75,"context_line":"            \"publish\": types.NONEMPTY_DICT,"},{"line_number":76,"context_line":"            \"publish-on-error\": types.NONEMPTY_DICT,"},{"line_number":77,"context_line":"            \"retry\": retry_policy.RetrySpec.get_schema(),"},{"line_number":78,"context_line":"            \"wait-before\": types.EXPRESSION_OR_POSITIVE_INTEGER,"},{"line_number":79,"context_line":"            \"wait-after\": types.EXPRESSION_OR_POSITIVE_INTEGER,"},{"line_number":80,"context_line":"            \"timeout\": types.EXPRESSION_OR_POSITIVE_INTEGER,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_803bdc9a","line":77,"updated":"2018-04-15 07:44:17.000000000","message":"We have all of these policies in the task-defaults section. I think you should fix these as well.","commit_id":"9889a1ee278eb00557c88b8ffafca721df8b3221"}],"mistral/tests/unit/lang/v2/test_tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e8f8f11dc942c1209faa156ca1848c77462b79af","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                             {\u0027email\u0027: \u0027\u003c% 1 %\u003e\u0027}]}, True),"},{"line_number":284,"context_line":"            ({\u0027on-success\u0027: [{\u0027email\u0027: \u0027\u003c% 1 %\u003e\u0027,"},{"line_number":285,"context_line":"                              \u0027more_email\u0027: \u0027\u003c% 2 %\u003e\u0027}]}, True),"},{"line_number":286,"context_line":"            ({\u0027on-success\u0027: [{\u0027email\u0027: \u0027\u003c% 1 %\u003e\u0027}, \u0027echo\u0027]}, False),"},{"line_number":287,"context_line":"            ({\u0027on-success\u0027: [{\u0027email\u0027: \u0027\u003c% $.v1 in $.v2 %\u003e\u0027}]}, False),"},{"line_number":288,"context_line":"            ({\u0027on-success\u0027: [{\u0027email\u0027: \u0027\u003c% * %\u003e\u0027}]}, True),"},{"line_number":289,"context_line":"            ({\u0027on-success\u0027: [{\u0027email\u0027: \u0027{{ 1 }}\u0027}]}, False),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d41707ee","line":286,"range":{"start_line":286,"start_character":12,"end_line":286,"end_character":15},"updated":"2018-07-02 10:03:12.000000000","message":"Not sure why you removed all these tests. Can you explain?","commit_id":"7882272d6a8d056f7db180940dd5465b0e61caef"}]}
