)]}'
{"mistral/cmd/launch.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"54e5b250521fcdab7154e857d2bcd3296e6ee0ed","unresolved":false,"context_lines":[{"line_number":55,"context_line":"SERVER_PROCESS_MANAGER \u003d None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def reset_server_managers():"},{"line_number":59,"context_line":"    global SERVER_THREAD_MANAGER"},{"line_number":60,"context_line":"    global SERVER_PROCESS_MANAGER"},{"line_number":61,"context_line":"    SERVER_THREAD_MANAGER \u003d None"},{"line_number":62,"context_line":"    SERVER_PROCESS_MANAGER \u003d None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_server_thread_manager():"},{"line_number":66,"context_line":"    global SERVER_THREAD_MANAGER"},{"line_number":67,"context_line":"    return SERVER_THREAD_MANAGER"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def get_server_process_manager():"},{"line_number":71,"context_line":"    global SERVER_PROCESS_MANAGER"},{"line_number":72,"context_line":"    return SERVER_PROCESS_MANAGER"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def launch_thread(server, workers\u003d1):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3f5d68e9","line":72,"range":{"start_line":58,"start_character":0,"end_line":72,"end_character":33},"updated":"2017-09-01 04:48:02.000000000","message":"Soft: I\u0027d suggest we move these methods to the end and leave a comment that they are used only by tests. Because they are not needed for normal program execution.","commit_id":"34ce1f24546731e918768d5631fd68a3dbb6a4d1"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"2dd850a74419ecfebe294a32d2ef0e24c1022a7c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def launch_thread(server, workers\u003d1):"},{"line_number":59,"context_line":"    try:"},{"line_number":60,"context_line":"        global SERVER_THREAD_MANAGER"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if not SERVER_THREAD_MANAGER:"},{"line_number":63,"context_line":"            SERVER_THREAD_MANAGER \u003d service.ServiceLauncher(CONF)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        SERVER_THREAD_MANAGER.launch_service(server, workers\u003dworkers)"},{"line_number":66,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_8ae8f1b2","line":63,"range":{"start_line":60,"start_character":8,"end_line":63,"end_character":65},"updated":"2017-09-08 08:25:25.000000000","message":"Late comment: IMHO it would be nicer if the get_* functions were used to retrieve the the managers and they were initialized there with correct locking.","commit_id":"8a4fe7f146446201d88237804e007c8987814622"}]}
