)]}'
{"mistral/tests/unit/actions/test_std_http_action.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"fe63e3b527226bbfe3c0ab61960b57b32ff231bd","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual(\u0027content\u0027, result[\u0027content\u0027])"},{"line_number":294,"context_line":"        self.assertEqual(200, result[\u0027status\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(result[\u0027encoding\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        mocked_method.assert_called_with("},{"line_number":298,"context_line":"            \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_89537c39","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":45},"updated":"2017-09-07 11:34:51.000000000","message":"I\u0027d rather we reduced the assertions to this single line. As I can see, other tests already cover the rest. This way the unit tests can be more focused.","commit_id":"7e12d918c9831d8c794ae0676ab282315a2e9480"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a193ce82f75c4e5d7db9b37d87a8ea90c2a81676","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual(\u0027content\u0027, result[\u0027content\u0027])"},{"line_number":294,"context_line":"        self.assertEqual(200, result[\u0027status\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(result[\u0027encoding\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        mocked_method.assert_called_with("},{"line_number":298,"context_line":"            \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_6a25c5c1","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":45},"in_reply_to":"7f287b81_5f0e4d3b","updated":"2017-09-08 08:49:05.000000000","message":"I guess, deleting lines is easy and makes the developer happy.  This change should make everyone happy. I did it locally, ran the tests and worked beautifully. But I obey the community desire if that makes everyone even happier. :)","commit_id":"7e12d918c9831d8c794ae0676ab282315a2e9480"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"68da3de1a1abe84fcca0d0bfd2e9d87717f9a076","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual(\u0027content\u0027, result[\u0027content\u0027])"},{"line_number":294,"context_line":"        self.assertEqual(200, result[\u0027status\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(result[\u0027encoding\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        mocked_method.assert_called_with("},{"line_number":298,"context_line":"            \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_5f0e4d3b","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":45},"in_reply_to":"7f287b81_89537c39","updated":"2017-09-08 07:56:32.000000000","message":"While I largely agree, and generally believe tests should be small and ideally test one thing without duplication of others,  this practice isn\u0027t common within the Mistral code base. There are many tests that duplicate and have many asserts. It would be a good to try and improve this at some point, but I don\u0027t think it should hold up this bug fix.","commit_id":"7e12d918c9831d8c794ae0676ab282315a2e9480"}]}
