)]}'
{"mistral/engine/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ee7aedac7d4a67e66f9bab3e1da33576201c67c7","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _prepare_execution_context(self):"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if not self.task_ex:"},{"line_number":329,"context_line":"            return {}"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_7a05af13","line":327,"updated":"2017-10-24 11:39:36.000000000","message":"Soft: unnecessary line","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"45dfd4f4e1d20fb4aaa018f3e0ac9ae97a384eba","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _prepare_execution_context(self):"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if not self.task_ex:"},{"line_number":329,"context_line":"            return {}"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_702dcbfc","line":327,"in_reply_to":"3f4b6375_7a05af13","updated":"2017-10-24 14:17:07.000000000","message":"Done","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ee7aedac7d4a67e66f9bab3e1da33576201c67c7","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _prepare_execution_context(self):"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if not self.task_ex:"},{"line_number":329,"context_line":"            return {}"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return dict("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_152fac8e","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":28},"updated":"2017-10-24 11:39:36.000000000","message":"I think even if we\u0027re running a standalone action it would be valuable to pass its id within a context. So maybe we just need to leave other fields blank and populate only \u0027action_execution_id\u0027 (if it exists) and \u0027callback_url\u0027?","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"45dfd4f4e1d20fb4aaa018f3e0ac9ae97a384eba","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _prepare_execution_context(self):"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if not self.task_ex:"},{"line_number":329,"context_line":"            return {}"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return dict("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_d03d9f2b","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":28},"in_reply_to":"3f4b6375_152fac8e","updated":"2017-10-24 14:17:07.000000000","message":"Done. I\u0027ve updated this to build the dict in steps - so it will be populated with the information we have.","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ee7aedac7d4a67e66f9bab3e1da33576201c67c7","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return dict("},{"line_number":332,"context_line":"            workflow_execution_id\u003dself.task_ex.workflow_execution.id,"},{"line_number":333,"context_line":"            task_id\u003dself.task_ex.id,"},{"line_number":334,"context_line":"            action_execution_id\u003dself.action_ex.id,"},{"line_number":335,"context_line":"            workflow_name\u003dself.task_ex.workflow_execution.name,"},{"line_number":336,"context_line":"            callback_url\u003d\u0027/v2/action_executions/%s\u0027 % self.action_ex.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_55452442","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":19},"updated":"2017-10-24 11:39:36.000000000","message":"Let\u0027s rename it to \u0027task_execution_id\u0027. \u0027task_id\u0027 is a legacy name and will change in the next version of API. Currently it\u0027s just a naming inconsistency that we have (action_execution_id, workflow_execution_id, but task_id w/o \u0027execution\u0027). Here we can safely call it \u0027task_execution_id\u0027 so that we don\u0027t need to rename it later and worry about compatibility.","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"45dfd4f4e1d20fb4aaa018f3e0ac9ae97a384eba","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return dict("},{"line_number":332,"context_line":"            workflow_execution_id\u003dself.task_ex.workflow_execution.id,"},{"line_number":333,"context_line":"            task_id\u003dself.task_ex.id,"},{"line_number":334,"context_line":"            action_execution_id\u003dself.action_ex.id,"},{"line_number":335,"context_line":"            workflow_name\u003dself.task_ex.workflow_execution.name,"},{"line_number":336,"context_line":"            callback_url\u003d\u0027/v2/action_executions/%s\u0027 % self.action_ex.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_50808fc0","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":19},"in_reply_to":"3f4b6375_55452442","updated":"2017-10-24 14:17:07.000000000","message":"This isn\u0027t quite as easy AFAICT, we have already set it to task_id in mistral-lib. I have created a follow up patch to change it in mistral-lib and then this patch to update it in mistral. https://review.openstack.org/514688","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"}],"mistral/executors/default_executor.py":[{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"369d161823ca70b40a736630715ac9b798e59395","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    region_name\u003dctx.region_name,"},{"line_number":114,"context_line":"                    is_trust_scoped\u003dctx.is_trust_scoped,"},{"line_number":115,"context_line":"                    redelivered\u003dctx.redelivered, expires_at\u003dctx.expires_at,"},{"line_number":116,"context_line":"                    trust_id\u003dctx.trust_id, is_target\u003dctx.is_target)"},{"line_number":117,"context_line":"                execution_ctx \u003d lib_ctx.ExecutionContext()"},{"line_number":118,"context_line":"                action_ctx \u003d lib_ctx.ActionContext(security_ctx, execution_ctx)"},{"line_number":119,"context_line":"                result \u003d action.run(action_ctx)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_59c32158","line":116,"updated":"2017-10-09 09:24:00.000000000","message":"Do we have to support auth_cacert, insecure they are going away on mistralclient https://review.openstack.org/#/c/505240/","commit_id":"4ef229d8dd367bcfe56d028af8541f7610c8d0c4"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ee7aedac7d4a67e66f9bab3e1da33576201c67c7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DefaultExecutor(base.Executor):"},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        self._engine_client \u003d rpc.get_engine_client()"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_153e8c8b","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":35},"updated":"2017-10-24 11:39:36.000000000","message":"Please make the same signature change in the base interface Executor.","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"45dfd4f4e1d20fb4aaa018f3e0ac9ae97a384eba","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DefaultExecutor(base.Executor):"},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        self._engine_client \u003d rpc.get_engine_client()"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_f06e5b2d","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":35},"in_reply_to":"3f4b6375_153e8c8b","updated":"2017-10-24 14:17:07.000000000","message":"Done","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ee7aedac7d4a67e66f9bab3e1da33576201c67c7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            # that it expects to be passed the context."},{"line_number":107,"context_line":"            if isinstance(action, mistral_lib.Action):"},{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":110,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":111,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":112,"context_line":"                    region_name\u003dctx.region_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_f5f090ff","line":109,"updated":"2017-10-24 11:39:36.000000000","message":"Soft: I\u0027d just suggest we add blank lines after 108, 116 and 117 just to split different units of logic.","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"45dfd4f4e1d20fb4aaa018f3e0ac9ae97a384eba","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            # that it expects to be passed the context."},{"line_number":107,"context_line":"            if isinstance(action, mistral_lib.Action):"},{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":110,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":111,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":112,"context_line":"                    region_name\u003dctx.region_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_b07463ff","line":109,"in_reply_to":"3f4b6375_f5f090ff","updated":"2017-10-24 14:17:07.000000000","message":"Done","commit_id":"3e718b7c53a76e45036d0b0b83cfeac9950809d7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"157c91271ed2f76e40cd490617ddc41e95698b02","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if isinstance(action, mistral_lib.Action):"},{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":111,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":112,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":113,"context_line":"                    region_name\u003dctx.region_name,"}],"source_content_type":"text/x-python","patch_set":22,"id":"df87a7cf_4e19f21f","line":110,"range":{"start_line":110,"start_character":16,"end_line":110,"end_character":55},"updated":"2017-12-07 12:04:21.000000000","message":"I would probably move creation of security context to some security specific module. It concerns me that this module has to know about specific fields of the security context. I\u0027d suggest we avoid it. It could be just a method in \"context.py\" module that we could call here.","commit_id":"9c1ef06472a7d12eeca5b8180c984465b75e6703"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3abb83a3e52ffa8895edff01ce1a628aef09b955","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if isinstance(action, mistral_lib.Action):"},{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":111,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":112,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":113,"context_line":"                    region_name\u003dctx.region_name,"}],"source_content_type":"text/x-python","patch_set":22,"id":"df87a7cf_6548905b","line":110,"range":{"start_line":110,"start_character":16,"end_line":110,"end_character":55},"in_reply_to":"df87a7cf_4e19f21f","updated":"2017-12-07 15:34:21.000000000","message":"Done","commit_id":"9c1ef06472a7d12eeca5b8180c984465b75e6703"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"157c91271ed2f76e40cd490617ddc41e95698b02","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":111,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":112,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":113,"context_line":"                    region_name\u003dctx.region_name,"},{"line_number":114,"context_line":"                    is_trust_scoped\u003dctx.is_trust_scoped,"},{"line_number":115,"context_line":"                    redelivered\u003dctx.redelivered, expires_at\u003dctx.expires_at,"},{"line_number":116,"context_line":"                    trust_id\u003dctx.trust_id, is_target\u003dctx.is_target,"},{"line_number":117,"context_line":"                    project_id\u003dctx.project_id, auth_token\u003dctx.auth_token)"},{"line_number":118,"context_line":"                execution_ctx \u003d lib_ctx.ExecutionContext(**execution_context)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"                action_ctx \u003d lib_ctx.ActionContext(security_ctx, execution_ctx)"}],"source_content_type":"text/x-python","patch_set":22,"id":"df87a7cf_aedbde79","line":117,"range":{"start_line":111,"start_character":20,"end_line":117,"end_character":72},"updated":"2017-12-07 12:04:21.000000000","message":"Soft: I\u0027d suggest we make it one param at a line. Otherwise, I can\u0027t clearly see all params.","commit_id":"9c1ef06472a7d12eeca5b8180c984465b75e6703"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3abb83a3e52ffa8895edff01ce1a628aef09b955","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                ctx \u003d context.ctx()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                security_ctx \u003d lib_ctx.SecurityContext("},{"line_number":111,"context_line":"                    auth_uri\u003dctx.auth_uri, auth_cacert\u003dctx.auth_cacert,"},{"line_number":112,"context_line":"                    insecure\u003dctx.insecure, service_catalog\u003dctx.service_catalog,"},{"line_number":113,"context_line":"                    region_name\u003dctx.region_name,"},{"line_number":114,"context_line":"                    is_trust_scoped\u003dctx.is_trust_scoped,"},{"line_number":115,"context_line":"                    redelivered\u003dctx.redelivered, expires_at\u003dctx.expires_at,"},{"line_number":116,"context_line":"                    trust_id\u003dctx.trust_id, is_target\u003dctx.is_target,"},{"line_number":117,"context_line":"                    project_id\u003dctx.project_id, auth_token\u003dctx.auth_token)"},{"line_number":118,"context_line":"                execution_ctx \u003d lib_ctx.ExecutionContext(**execution_context)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"                action_ctx \u003d lib_ctx.ActionContext(security_ctx, execution_ctx)"}],"source_content_type":"text/x-python","patch_set":22,"id":"df87a7cf_2578488e","line":117,"range":{"start_line":111,"start_character":20,"end_line":117,"end_character":72},"in_reply_to":"df87a7cf_aedbde79","updated":"2017-12-07 15:34:21.000000000","message":"Done","commit_id":"9c1ef06472a7d12eeca5b8180c984465b75e6703"}]}
