)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adriano Petrich \u003capetrich@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-29 12:52:11 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dynamic task name evaluation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Evaluate tasks names dynamically, so yaql or jinja expression can be"},{"line_number":10,"context_line":"used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_d6c310ec","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":12},"updated":"2017-10-02 05:07:24.000000000","message":"task -\u003e action\n\nTask names are always static. In your test it\u0027s \"task1\".","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dynamic task name evaluation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Evaluate tasks names dynamically, so yaql or jinja expression can be"},{"line_number":10,"context_line":"used"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I48761c215f0255976c330ffa34f27bb695c944a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_b6b65489","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":14},"updated":"2017-10-02 05:07:24.000000000","message":"Same\n\n-\u003e action names","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"}],"mistral/engine/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        action_name \u003d self.task_spec.get_action_name()"},{"line_number":458,"context_line":"        wf_name \u003d self.task_spec.get_workflow_name()"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        # for dynamic workflow evaluation"},{"line_number":461,"context_line":"        if wf_name:"},{"line_number":462,"context_line":"            return actions.WorkflowAction("},{"line_number":463,"context_line":"                wf_name\u003dself._evaluate_expression(wf_name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d6f55058","line":460,"range":{"start_line":460,"start_character":10,"end_line":460,"end_character":41},"updated":"2017-10-02 05:07:24.000000000","message":"Soft: we usually make all comments compliant with regular English grammar. I.e., start sentences with a capital and end with a period.","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                task_ex\u003dself.task_ex"},{"line_number":465,"context_line":"            )"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        # for dynamic action evaluation"},{"line_number":468,"context_line":"        if action_name:"},{"line_number":469,"context_line":"            action_name \u003d self._evaluate_expression(action_name)"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b6e8947b","line":467,"range":{"start_line":467,"start_character":10,"end_line":467,"end_character":39},"updated":"2017-10-02 05:07:24.000000000","message":"Soft: same here.","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"}],"mistral/tests/unit/engine/test_workflow_variables.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            wf_output"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_dynamic_workflow_variables(self):"},{"line_number":78,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":79,"context_line":"        version: \u00272.0\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_96a0f843","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":39},"updated":"2017-10-02 05:07:24.000000000","message":"I would also add a test where all \"input\" is fully dynamic (w/o specifying particular parameter names).","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"},{"author":{"_account_id":23271,"name":"Istvan Imre","email":"istvan.imre@nokia.com","username":"istvan.imre"},"change_message_id":"8027aa51682a4c99a4e2d177826b2716cbdda709","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            wf_output"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_dynamic_workflow_variables(self):"},{"line_number":78,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":79,"context_line":"        version: \u00272.0\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_3675c4fa","line":77,"updated":"2017-10-02 04:54:13.000000000","message":"Wrong test name, please use a relevant one.","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            wf_output"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_dynamic_workflow_variables(self):"},{"line_number":78,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":79,"context_line":"        version: \u00272.0\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_36fca43c","line":77,"in_reply_to":"7f515b1d_3675c4fa","updated":"2017-10-02 05:07:24.000000000","message":"Yep, I agree.","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"029eb9ebaa7197db084e7869634e754a0efacc36","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        wf_service.create_workflows(wf_text)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Start workflow."},{"line_number":97,"context_line":"        wf_ex \u003d self.engine.start_workflow(\u0027wf2\u0027,"},{"line_number":98,"context_line":"                                           \"\","},{"line_number":99,"context_line":"                                           {\"wf_action\": \"std.echo\","},{"line_number":100,"context_line":"                                            \"param1\": \"Hello\"}"},{"line_number":101,"context_line":"                                           )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d69af011","line":101,"range":{"start_line":97,"start_character":8,"end_line":101,"end_character":44},"updated":"2017-10-02 05:07:24.000000000","message":"Usually, we do it like this:\n\nwf_ex \u003d self.engine.start_workflow(\n    \u0027wf2\u0027,\n    \"\",\n    {\"wf_action\": \"std.echo\", \"param1\": \"Hello\"}\n)","commit_id":"c52af225f401ead9b6c06b8a019aaed40c625cb3"}]}
