)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e3ac90ce3996a24e9f7355fb8bd4125c52527c91","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Made scheduler delay configurable. It now consists of a fixed"},{"line_number":10,"context_line":"  part configured with the \u0027fixed_delay\u0027 property and a random"},{"line_number":11,"context_line":"  addition limited by the \u0027random_delay\u0027 config property."},{"line_number":12,"context_line":"  Because of this, using loopingcall from oslo was replaced with"},{"line_number":13,"context_line":"  a regular loop in a separate thread becase loopingcall"},{"line_number":14,"context_line":"  supports only fixed delays."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_7b3047e9","line":11,"updated":"2017-10-06 08:41:42.000000000","message":"What is the advantage of a random delay?","commit_id":"4078d87620ae512df53017fff2de9e3a938077d0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3e328fe3b0b8558c0d3f7320571223af6fa3762c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Made scheduler delay configurable. It now consists of a fixed"},{"line_number":10,"context_line":"  part configured with the \u0027fixed_delay\u0027 property and a random"},{"line_number":11,"context_line":"  addition limited by the \u0027random_delay\u0027 config property."},{"line_number":12,"context_line":"  Because of this, using loopingcall from oslo was replaced with"},{"line_number":13,"context_line":"  a regular loop in a separate thread becase loopingcall"},{"line_number":14,"context_line":"  supports only fixed delays."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_46bb6ec3","line":11,"in_reply_to":"7f515b1d_7b3047e9","updated":"2017-10-06 09:40:03.000000000","message":"Yes, let me describe it in the bug that I\u0027m going to reference.","commit_id":"4078d87620ae512df53017fff2de9e3a938077d0"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e3ac90ce3996a24e9f7355fb8bd4125c52527c91","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  a regular loop in a separate thread becase loopingcall"},{"line_number":14,"context_line":"  supports only fixed delays."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8f6a15be339e208755323afb18e4b58f886770c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_1b09532b","line":16,"updated":"2017-10-06 08:41:42.000000000","message":"It would be good to reference a bug if we want to backport this to Pike.","commit_id":"4078d87620ae512df53017fff2de9e3a938077d0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3e328fe3b0b8558c0d3f7320571223af6fa3762c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  a regular loop in a separate thread becase loopingcall"},{"line_number":14,"context_line":"  supports only fixed delays."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8f6a15be339e208755323afb18e4b58f886770c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_06b576cd","line":16,"in_reply_to":"7f515b1d_1b09532b","updated":"2017-10-06 09:40:03.000000000","message":"Ok, yes.","commit_id":"4078d87620ae512df53017fff2de9e3a938077d0"}],"mistral/config.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":195,"context_line":"]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"scheduler_opts \u003d ["},{"line_number":198,"context_line":"    cfg.FloatOpt("},{"line_number":199,"context_line":"        \u0027fixed_delay\u0027,"},{"line_number":200,"context_line":"        default\u003d1,"},{"line_number":201,"context_line":"        min\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_c7d7584f","line":198,"updated":"2017-10-06 11:38:24.000000000","message":"Should we use Range instead of these two options?\nhttps://docs.openstack.org/oslo.config/ocata/types.html#oslo_config.types.Range","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3624c92f19086c87812e3a2efe751f93da28a57d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"scheduler_opts \u003d ["},{"line_number":198,"context_line":"    cfg.FloatOpt("},{"line_number":199,"context_line":"        \u0027fixed_delay\u0027,"},{"line_number":200,"context_line":"        default\u003d1,"},{"line_number":201,"context_line":"        min\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_8f1f366f","line":198,"in_reply_to":"7f515b1d_c7d7584f","updated":"2017-10-06 14:00:33.000000000","message":"We can use it but we\u0027ll have to configure both bounds as integers. I\u0027d prefer to keep the possibility to define not only integer intervals. It\u0027s pretty important for fine tuning.","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        default\u003d1,"},{"line_number":201,"context_line":"        min\u003d0.1,"},{"line_number":202,"context_line":"        help\u003d("},{"line_number":203,"context_line":"            \u0027Fixed part of the delay between scheduler iterations, in seconds.\u0027"},{"line_number":204,"context_line":"            \u0027Full delay is defined as a sum of \"fixed_delay\" and a random \u0027"},{"line_number":205,"context_line":"            \u0027delay limited by \"random_delay\".\u0027"},{"line_number":206,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_2c35f346","line":203,"range":{"start_line":203,"start_character":77,"end_line":203,"end_character":79},"updated":"2017-10-06 11:38:24.000000000","message":"Here you need a space.","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        default\u003d0,"},{"line_number":211,"context_line":"        min\u003d0,"},{"line_number":212,"context_line":"        help\u003d("},{"line_number":213,"context_line":"            \u0027Max value of the random part of the delay between scheduler\u0027"},{"line_number":214,"context_line":"            \u0027iterations, in seconds.\u0027"},{"line_number":215,"context_line":"            \u0027Full delay is defined as a sum of \"fixed_delay\" and a random \u0027"},{"line_number":216,"context_line":"            \u0027delay limited by this property.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ac48c3cb","line":213,"range":{"start_line":213,"start_character":72,"end_line":213,"end_character":73},"updated":"2017-10-06 11:38:24.000000000","message":"Ditto","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        min\u003d0,"},{"line_number":212,"context_line":"        help\u003d("},{"line_number":213,"context_line":"            \u0027Max value of the random part of the delay between scheduler\u0027"},{"line_number":214,"context_line":"            \u0027iterations, in seconds.\u0027"},{"line_number":215,"context_line":"            \u0027Full delay is defined as a sum of \"fixed_delay\" and a random \u0027"},{"line_number":216,"context_line":"            \u0027delay limited by this property.\u0027"},{"line_number":217,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0c1117ad","line":214,"range":{"start_line":214,"start_character":35,"end_line":214,"end_character":37},"updated":"2017-10-06 11:38:24.000000000","message":"Ditto","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"}],"mistral/engine/default_engine.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e3ac90ce3996a24e9f7355fb8bd4125c52527c91","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @profiler.trace(\u0027engine-on-action-complete\u0027, hide_args\u003dTrue)"},{"line_number":109,"context_line":"    def on_action_complete(self, action_ex_id, result, wf_action\u003dFalse,"},{"line_number":110,"context_line":"                           async_\u003dFalse):"},{"line_number":111,"context_line":"        print(\"on_action_complete\")"},{"line_number":112,"context_line":"        with db_api.transaction():"},{"line_number":113,"context_line":"            if wf_action:"},{"line_number":114,"context_line":"                action_ex \u003d db_api.get_workflow_execution(action_ex_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_581a317d","line":111,"updated":"2017-10-06 08:41:42.000000000","message":"Left over from dev?","commit_id":"4078d87620ae512df53017fff2de9e3a938077d0"}],"mistral/services/scheduler.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    \" due to unexpected exception.\""},{"line_number":128,"context_line":"                )"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            fixed_delay \u003d CONF.scheduler.fixed_delay"},{"line_number":131,"context_line":"            random_delay \u003d CONF.scheduler.random_delay"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"            eventlet.sleep("},{"line_number":134,"context_line":"                fixed_delay +"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ec76bbd8","line":131,"range":{"start_line":130,"start_character":12,"end_line":131,"end_character":54},"updated":"2017-10-06 11:38:24.000000000","message":"Probably it\u0027s more beautiful to define this variables as object attributes outside of the loop:\n\n     def __init__(self):\n        self._stopped \u003d False\n        self._thread \u003d threading.Thread(target\u003dself._loop)\n        self._thread.daemon \u003d True\n        self.fixed_delay \u003d CONF.scheduler.fixed_delay\n        self.random_delay \u003d CONF.scheduler.random_delay","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3624c92f19086c87812e3a2efe751f93da28a57d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    \" due to unexpected exception.\""},{"line_number":128,"context_line":"                )"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            fixed_delay \u003d CONF.scheduler.fixed_delay"},{"line_number":131,"context_line":"            random_delay \u003d CONF.scheduler.random_delay"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"            eventlet.sleep("},{"line_number":134,"context_line":"                fixed_delay +"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_b2401937","line":131,"range":{"start_line":130,"start_character":12,"end_line":131,"end_character":54},"in_reply_to":"7f515b1d_ec76bbd8","updated":"2017-10-06 14:00:33.000000000","message":"Agree.","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8867c9f8214af398b5150408bbbf459ff776e7be","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        # Delete invoked calls from DB."},{"line_number":157,"context_line":"        self.delete_calls(db_calls)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        return None"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @staticmethod"},{"line_number":162,"context_line":"    @db_utils.retry_on_deadlock"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ecda3be7","line":159,"updated":"2017-10-06 11:38:24.000000000","message":"Not necessary","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3624c92f19086c87812e3a2efe751f93da28a57d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        # Delete invoked calls from DB."},{"line_number":157,"context_line":"        self.delete_calls(db_calls)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        return None"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @staticmethod"},{"line_number":162,"context_line":"    @db_utils.retry_on_deadlock"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_329b09ca","line":159,"in_reply_to":"7f515b1d_ecda3be7","updated":"2017-10-06 14:00:33.000000000","message":"Yes, sorry. It\u0027s a left over from one solution I tried (to explicitly mark that a return value is important).","commit_id":"73dce507dc3181e7ea865e9c0f199fdd929ab311"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"da41242eafb5362ba1ab2d9718af471d3ff44def","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # Delete invoked calls from DB."},{"line_number":156,"context_line":"        self.delete_calls(db_calls)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @staticmethod"},{"line_number":161,"context_line":"    @db_utils.retry_on_deadlock"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_6d72c24b","line":158,"updated":"2017-10-06 14:40:40.000000000","message":"I still think that it\u0027s not important here :)","commit_id":"781ebeb40f39ddbea327c04042a347cbbaabafaf"}]}
