)]}'
{"mistral/cmd/launch.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d897678bda125c009b17c1008fca7d3384fae2f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# If ../mistral/__init__.py exists, add ../ to Python search path, so that"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_e0c38256","line":21,"range":{"start_line":21,"start_character":7,"end_line":21,"end_character":9},"updated":"2017-10-31 08:40:18.000000000","message":"In the current version we monkeypatch \"os\" before importing it. Are you sure we can do it in the opposite order?","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3a076c08e9a9cf1dc7486a304ed6ef1d51b3b832","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from mistral.event_engine import event_engine_server"},{"line_number":40,"context_line":"from mistral.executors import executor_server"},{"line_number":41,"context_line":"from mistral.rpc import base as rpc"},{"line_number":42,"context_line":"from mistral import version"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_3b12eb59","line":42,"updated":"2017-10-31 09:12:40.000000000","message":"We also need to monkey_patch before all of these imports. If any of them import os/thread etc. then we are in for a bad time.","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"910cfc1ca3608633197b504109b4a083a5a26c3e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def launch_executor():"},{"line_number":77,"context_line":"    eventlet.monkey_patch("},{"line_number":78,"context_line":"        os\u003dFalse,"},{"line_number":79,"context_line":"        select\u003dFalse,"},{"line_number":80,"context_line":"        socket\u003dFalse,"},{"line_number":81,"context_line":"        thread\u003dFalse,"},{"line_number":82,"context_line":"        time\u003dFalse)"},{"line_number":83,"context_line":"    launch_thread(executor_server.get_oslo_service())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_800dee91","line":82,"range":{"start_line":77,"start_character":4,"end_line":82,"end_character":18},"updated":"2017-10-31 08:58:28.000000000","message":"Isn\u0027t this essentially a noop? can we remove this?","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d897678bda125c009b17c1008fca7d3384fae2f4","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def launch_engine():"},{"line_number":87,"context_line":"    eventlet.monkey_patch("},{"line_number":88,"context_line":"        os\u003dTrue,"},{"line_number":89,"context_line":"        select\u003dTrue,"},{"line_number":90,"context_line":"        socket\u003dTrue,"},{"line_number":91,"context_line":"        thread\u003dFalse if \u0027--use-debugger\u0027 in sys.argv else True,"},{"line_number":92,"context_line":"        time\u003dTrue)"},{"line_number":93,"context_line":"    launch_thread(engine_server.get_oslo_service())"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_e0ea62d6","line":92,"range":{"start_line":87,"start_character":4,"end_line":92,"end_character":18},"updated":"2017-10-31 08:40:18.000000000","message":"Can you please refactor it with a new method whose call would look more concise? You can just have one param that change a value for the \"thread\" parameter.","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d897678bda125c009b17c1008fca7d3384fae2f4","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def launch_event_engine():"},{"line_number":97,"context_line":"    eventlet.monkey_patch("},{"line_number":98,"context_line":"        os\u003dTrue,"},{"line_number":99,"context_line":"        select\u003dTrue,"},{"line_number":100,"context_line":"        socket\u003dTrue,"},{"line_number":101,"context_line":"        thread\u003dFalse if \u0027--use-debugger\u0027 in sys.argv else True,"},{"line_number":102,"context_line":"        time\u003dTrue)"},{"line_number":103,"context_line":"    launch_thread(event_engine_server.get_oslo_service())"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_80b5eef0","line":102,"range":{"start_line":97,"start_character":4,"end_line":102,"end_character":18},"updated":"2017-10-31 08:40:18.000000000","message":"Are you sure it\u0027s ok run monkey patching more than once?","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"686cbb1065d288ea990643e43429dcbe9ca6df2a","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def launch_event_engine():"},{"line_number":97,"context_line":"    eventlet.monkey_patch("},{"line_number":98,"context_line":"        os\u003dTrue,"},{"line_number":99,"context_line":"        select\u003dTrue,"},{"line_number":100,"context_line":"        socket\u003dTrue,"},{"line_number":101,"context_line":"        thread\u003dFalse if \u0027--use-debugger\u0027 in sys.argv else True,"},{"line_number":102,"context_line":"        time\u003dTrue)"},{"line_number":103,"context_line":"    launch_thread(event_engine_server.get_oslo_service())"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_2083daab","line":102,"range":{"start_line":97,"start_character":4,"end_line":102,"end_character":18},"in_reply_to":"3f4b6375_80b5eef0","updated":"2017-10-31 09:00:58.000000000","message":"\"It’s safe to call monkey_patch multiple times.\"\n\nhttp://eventlet.net/doc/patching.html","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"9a2556bfcb03d5e0f7189e6d100e0d9599f6d1b7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    print(MISTRAL_TITLE)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    comp_str \u003d (\"[%s]\" % \u0027,\u0027.join(LAUNCH_OPTIONS)"},{"line_number":156,"context_line":"                if cfg.CONF.server \u003d\u003d [\u0027all\u0027] else cfg.CONF.server)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    print(\u0027Launching server components %s...\u0027 % comp_str)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_402496c6","line":156,"updated":"2017-10-31 09:09:09.000000000","message":"The ability to run all or multiple services within the same process presents a problem. By changing which we monkey patch, we essentially remove that option. You can\u0027t run the executor with anything else.","commit_id":"f4156b2dc759d63c7934280c235c7bd77a186514"}]}
