)]}'
{"mistral/api/controllers/v2/cron_trigger.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20d146e50bbffe53c8754178fd0c6a5048c764ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        LOG.info(\u0027Fetch cron trigger [identifier\u003d%s]\u0027, identifier)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Use retries to prevent possible failures"},{"line_number":45,"context_line":"        r \u003d rest_utils.create_retrying_object()"},{"line_number":46,"context_line":"        db_model \u003d r.call(db_api.get_cron_trigger, identifier)"},{"line_number":47,"context_line":"        return resources.CronTrigger.from_db_model(db_model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_74233457","line":44,"updated":"2017-11-07 02:44:12.000000000","message":"Soft: we always try to make our comments comply with regular english grammar (Capitals, periods in the end etc.). Please fix it across the patch if you happen to send another patchset.","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e1d5603ce2e5019bc39877e4cd64f045135262ea","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        LOG.info(\u0027Fetch cron trigger [identifier\u003d%s]\u0027, identifier)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Use retries to prevent possible failures"},{"line_number":45,"context_line":"        r \u003d rest_utils.create_retrying_object()"},{"line_number":46,"context_line":"        db_model \u003d r.call(db_api.get_cron_trigger, identifier)"},{"line_number":47,"context_line":"        return resources.CronTrigger.from_db_model(db_model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7ddaf44a","line":44,"in_reply_to":"3f4b6375_74233457","updated":"2017-11-07 10:13:40.000000000","message":"Done","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20d146e50bbffe53c8754178fd0c6a5048c764ab","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Use retries to prevent possible failures"},{"line_number":45,"context_line":"        r \u003d rest_utils.create_retrying_object()"},{"line_number":46,"context_line":"        db_model \u003d r.call(db_api.get_cron_trigger, identifier)"},{"line_number":47,"context_line":"        return resources.CronTrigger.from_db_model(db_model)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":50,"context_line":"    @wsme_pecan.wsexpose("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_b4dacc47","line":47,"updated":"2017-11-07 02:44:12.000000000","message":"Soft: I\u0027d prefer to put blank lines before all flow controls like \"if\", \"return\" etc to see better individual logical units. Not insisting though, it\u0027s a matter of taste.","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e1d5603ce2e5019bc39877e4cd64f045135262ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Use retries to prevent possible failures"},{"line_number":45,"context_line":"        r \u003d rest_utils.create_retrying_object()"},{"line_number":46,"context_line":"        db_model \u003d r.call(db_api.get_cron_trigger, identifier)"},{"line_number":47,"context_line":"        return resources.CronTrigger.from_db_model(db_model)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":50,"context_line":"    @wsme_pecan.wsexpose("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5dddf83e","line":47,"in_reply_to":"3f4b6375_b4dacc47","updated":"2017-11-07 10:13:40.000000000","message":"Done","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"}],"mistral/utils/rest_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20d146e50bbffe53c8754178fd0c6a5048c764ab","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            **filters"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        for db_model in db_models:"},{"line_number":233,"context_line":"            if resource_function:"},{"line_number":234,"context_line":"                rest_resource \u003d resource_function(db_model)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                rest_resource \u003d cls.from_db_model(db_model)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            rest_resources.append(rest_resource)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    return list_cls.convert_with_links("},{"line_number":241,"context_line":"        rest_resources,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_74c7b497","line":238,"range":{"start_line":232,"start_character":8,"end_line":238,"end_character":48},"updated":"2017-11-07 02:44:12.000000000","message":"This snippet was in TX on purpose. Once the TX is committed, persistent objects associated with the DB session are no longer usable and lazy loading won\u0027t work. When we initialize some complex objects here we use lazing loading here implicitly in resoruce_function().\n\nSo we need to leave this code within the TX somehow.","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e1d5603ce2e5019bc39877e4cd64f045135262ea","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            **filters"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        for db_model in db_models:"},{"line_number":233,"context_line":"            if resource_function:"},{"line_number":234,"context_line":"                rest_resource \u003d resource_function(db_model)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                rest_resource \u003d cls.from_db_model(db_model)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            rest_resources.append(rest_resource)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    return list_cls.convert_with_links("},{"line_number":241,"context_line":"        rest_resources,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_bdbd0cd9","line":238,"range":{"start_line":232,"start_character":8,"end_line":238,"end_character":48},"in_reply_to":"3f4b6375_74c7b497","updated":"2017-11-07 10:13:40.000000000","message":"Oh, my bad! It\u0027s a terrible typo I made. Tests fail because of this.","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20d146e50bbffe53c8754178fd0c6a5048c764ab","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    )"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def create_retrying_object():"},{"line_number":252,"context_line":"    return tenacity.Retrying("},{"line_number":253,"context_line":"        retry\u003dtenacity.retry_if_exception_type(sa.exc.OperationalError),"},{"line_number":254,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_744c5441","line":251,"range":{"start_line":251,"start_character":4,"end_line":251,"end_character":26},"updated":"2017-11-07 02:44:12.000000000","message":"Maybe I\u0027d call a way so that we can understand that this is about retrying DB operations. Maybe something like create_db_retry or create_db_retry_object?","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e1d5603ce2e5019bc39877e4cd64f045135262ea","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    )"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def create_retrying_object():"},{"line_number":252,"context_line":"    return tenacity.Retrying("},{"line_number":253,"context_line":"        retry\u003dtenacity.retry_if_exception_type(sa.exc.OperationalError),"},{"line_number":254,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_fdc26433","line":251,"range":{"start_line":251,"start_character":4,"end_line":251,"end_character":26},"in_reply_to":"3f4b6375_744c5441","updated":"2017-11-07 10:13:40.000000000","message":"Done","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"20d146e50bbffe53c8754178fd0c6a5048c764ab","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    return tenacity.Retrying("},{"line_number":253,"context_line":"        retry\u003dtenacity.retry_if_exception_type(sa.exc.OperationalError),"},{"line_number":254,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"},{"line_number":255,"context_line":"        wait\u003dtenacity.wait_incrementing()"},{"line_number":256,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_54f5d8c9","line":255,"range":{"start_line":255,"start_character":22,"end_line":255,"end_character":39},"updated":"2017-11-07 02:44:12.000000000","message":"Will it increment 0.1 sec, right? May be we need to set it explicitly?","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e1d5603ce2e5019bc39877e4cd64f045135262ea","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    return tenacity.Retrying("},{"line_number":253,"context_line":"        retry\u003dtenacity.retry_if_exception_type(sa.exc.OperationalError),"},{"line_number":254,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"},{"line_number":255,"context_line":"        wait\u003dtenacity.wait_incrementing()"},{"line_number":256,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_ddbd68b1","line":255,"range":{"start_line":255,"start_character":22,"end_line":255,"end_character":39},"in_reply_to":"3f4b6375_54f5d8c9","updated":"2017-11-07 10:13:40.000000000","message":"Done","commit_id":"32b814b2985c3f8f3efff527fd6b16cbf38424db"}]}
