)]}'
{"mistral/engine/policies.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d67080fceacfd27ac93da287bf73763dd3927a24","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    wait_before \u003d policies_spec.get_wait_before()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if (isinstance(wait_before, six.string_types) or wait_before \u003e 0):"},{"line_number":84,"context_line":"        return WaitBeforePolicy(wait_before)"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_bb3ee426","side":"PARENT","line":83,"updated":"2017-11-13 11:24:06.000000000","message":"While I encourage changes like this, it would be better if they were in separate patches as it isn\u0027t clear which changes are simple formatting changes and which are changing the code.","commit_id":"bff3ebf30b46b0825c075531f8d997467e4b1c69"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d67080fceacfd27ac93da287bf73763dd3927a24","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            context_key"},{"line_number":488,"context_line":"        )"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        runtime_context[context_key] \u003d self.concurrency"},{"line_number":491,"context_line":"        task_ex.runtime_context \u003d runtime_context"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_dbee4087","line":490,"updated":"2017-11-13 11:24:06.000000000","message":"Isn\u0027t it better to still set the concurrency in the runtime context? Otherwise if we ever want to check it we need to check if it is set first.","commit_id":"89246c7dfb2abdc8f9b3be2d9473335180ea204a"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d39ee666c8ee09dac129ba6414668ed32e327b9e","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            context_key"},{"line_number":488,"context_line":"        )"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        runtime_context[context_key] \u003d self.concurrency"},{"line_number":491,"context_line":"        task_ex.runtime_context \u003d runtime_context"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_a7466bbf","line":490,"in_reply_to":"1f485f77_dbee4087","updated":"2017-11-16 07:38:49.000000000","message":"I don\u0027t really understand this comment. It is set in the runtime context, isn\u0027t it?","commit_id":"89246c7dfb2abdc8f9b3be2d9473335180ea204a"}],"mistral/tests/unit/engine/test_policies.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d67080fceacfd27ac93da287bf73763dd3927a24","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        mock.MagicMock(side_effect\u003dException())"},{"line_number":660,"context_line":"    )"},{"line_number":661,"context_line":"    def test_retry_policy(self):"},{"line_number":662,"context_line":"        wb_service.create_workbook_v2(RETRY_WB % {\u0027count\u0027: 3, \u0027delay\u0027: 1})"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        # Start workflow."},{"line_number":665,"context_line":"        wf_ex \u003d self.engine.start_workflow(\u0027wb.wf1\u0027, \u0027\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_bb6ca436","line":662,"updated":"2017-11-13 11:24:06.000000000","message":"I think .format() would be better than %.","commit_id":"89246c7dfb2abdc8f9b3be2d9473335180ea204a"}]}