)]}'
{"mistral/engine/actions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"eec6ecbe4252a3b7390d7084a63e2bd1ae43e268","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            base_action_def \u003d db_api.get_action_definition("},{"line_number":370,"context_line":"                self.action_spec.get_base()"},{"line_number":371,"context_line":"            )"},{"line_number":372,"context_line":"        except exc.DBEntityNotFoundError:"},{"line_number":373,"context_line":"            raise exc.InvalidActionException("},{"line_number":374,"context_line":"                \"Failed to find action [action_name\u003d%s]\" %"},{"line_number":375,"context_line":"                self.action_spec.get_base()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_cda783a7","side":"PARENT","line":372,"updated":"2017-12-05 15:11:35.000000000","message":"See my comment in lookup_utils. I think we need the try/except here, or in lookup_utils.","commit_id":"eb4d34fc0df46eaa97ba96a7cf9b0f16cb464b48"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ec4dfe415d2667d1a0582c6c2a4de1e8b72c4d11","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            base_action_def \u003d db_api.get_action_definition("},{"line_number":370,"context_line":"                self.action_spec.get_base()"},{"line_number":371,"context_line":"            )"},{"line_number":372,"context_line":"        except exc.DBEntityNotFoundError:"},{"line_number":373,"context_line":"            raise exc.InvalidActionException("},{"line_number":374,"context_line":"                \"Failed to find action [action_name\u003d%s]\" %"},{"line_number":375,"context_line":"                self.action_spec.get_base()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_e333b8f5","side":"PARENT","line":372,"in_reply_to":"df87a7cf_cda783a7","updated":"2017-12-13 11:25:53.000000000","message":"It\u0027s ok. Methods db_api.load_XXX don\u0027t raise this exception.","commit_id":"eb4d34fc0df46eaa97ba96a7cf9b0f16cb464b48"}],"mistral/services/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"7a3907175cdd1f91eed24a7546f3e734efd9b74e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    identifier \u003d identifier or values[\u0027name\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # Reset action definition in the cache to prevent future corruption."},{"line_number":91,"context_line":"    lookup_utils.invalidate_cached_action_definitions(identifier)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    return db_api.update_action_definition(identifier, values)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_d11d2ebe","line":91,"range":{"start_line":91,"start_character":52,"end_line":91,"end_character":53},"updated":"2017-11-20 08:11:44.000000000","message":"Why plural again?","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5a1ece0f187aaf4367794ec181247cb48f8eb4ed","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    identifier \u003d identifier or values[\u0027name\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # Reset action definition in the cache to prevent future corruption."},{"line_number":91,"context_line":"    lookup_utils.invalidate_cached_action_definitions(identifier)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    return db_api.update_action_definition(identifier, values)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_91d19fd0","line":91,"range":{"start_line":91,"start_character":52,"end_line":91,"end_character":53},"in_reply_to":"ff82abbf_d11d2ebe","updated":"2017-12-05 12:41:29.000000000","message":"Done","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"}],"mistral/workflow/lookup_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    missing\u003d_create_lru_cache_for_workflow_execution"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ACTION_DEFINITIONS_CACHE \u003d cachetools.LRUCache(maxsize\u003d100)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_67019305","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":25},"updated":"2017-11-16 07:17:01.000000000","message":"I\u0027d shorten it to _ACTION_DEF_CACHE.","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    missing\u003d_create_lru_cache_for_workflow_execution"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ACTION_DEFINITIONS_CACHE \u003d cachetools.LRUCache(maxsize\u003d100)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_84292d9c","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":59},"updated":"2017-11-16 07:17:01.000000000","message":"Let\u0027s make it bigger, say 1000. For task executions cache the size 100 has a different meaning.","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    missing\u003d_create_lru_cache_for_workflow_execution"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ACTION_DEFINITIONS_CACHE \u003d cachetools.LRUCache(maxsize\u003d100)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_777ffcdf","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":25},"in_reply_to":"1f485f77_67019305","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    missing\u003d_create_lru_cache_for_workflow_execution"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ACTION_DEFINITIONS_CACHE \u003d cachetools.LRUCache(maxsize\u003d100)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_977a78ee","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":59},"in_reply_to":"1f485f77_84292d9c","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_action_definitions_by_name(action_name):"},{"line_number":58,"context_line":"    \"\"\"Find action definitions name."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param action_name: Action name."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_847b6dbc","line":57,"range":{"start_line":57,"start_character":26,"end_line":57,"end_character":27},"updated":"2017-11-16 07:17:01.000000000","message":"Why plural? Actions are uniquely identified by their name. I guess this is a typo.","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_CACHE_LOCK \u003d threading.RLock()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_action_definitions_by_name(action_name):"},{"line_number":58,"context_line":"    \"\"\"Find action definitions name."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param action_name: Action name."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_d7735015","line":57,"range":{"start_line":57,"start_character":26,"end_line":57,"end_character":27},"in_reply_to":"1f485f77_847b6dbc","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_action_definitions_by_name(action_name):"},{"line_number":58,"context_line":"    \"\"\"Find action definitions name."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param action_name: Action name."},{"line_number":61,"context_line":"    :return: Action definition (possibly a cached value)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_c45e0543","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":35},"updated":"2017-11-16 07:17:01.000000000","message":"-\u003e \"definition by name\"?","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_action_definitions_by_name(action_name):"},{"line_number":58,"context_line":"    \"\"\"Find action definitions name."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param action_name: Action name."},{"line_number":61,"context_line":"    :return: Action definition (possibly a cached value)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_b770d409","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":35},"in_reply_to":"1f485f77_c45e0543","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    :param action_name: Action name."},{"line_number":61,"context_line":"    :return: Action definition (possibly a cached value)."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    with _CACHE_LOCK:"},{"line_number":64,"context_line":"        action_definition \u003d _ACTION_DEFINITIONS_CACHE.get(action_name)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if action_definition:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_c40cc542","line":63,"range":{"start_line":63,"start_character":9,"end_line":63,"end_character":20},"updated":"2017-11-16 07:17:01.000000000","message":"The lock for this new cache must be different.","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    :param action_name: Action name."},{"line_number":61,"context_line":"    :return: Action definition (possibly a cached value)."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    with _CACHE_LOCK:"},{"line_number":64,"context_line":"        action_definition \u003d _ACTION_DEFINITIONS_CACHE.get(action_name)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if action_definition:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_37d3c4d7","line":63,"range":{"start_line":63,"start_character":9,"end_line":63,"end_character":20},"in_reply_to":"1f485f77_c40cc542","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1d3cf64ca5f841fe156eafde7246342317455279","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    return len(_TASK_EX_CACHE)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"def invalidate_cached_task_executions(wf_ex_id):"},{"line_number":150,"context_line":"    with _CACHE_LOCK:"},{"line_number":151,"context_line":"        if wf_ex_id in _TASK_EX_CACHE:"},{"line_number":152,"context_line":"            del _TASK_EX_CACHE[wf_ex_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_6778738f","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":37},"updated":"2017-11-16 07:17:01.000000000","message":"Similar to this method you should create an invalidation method for action definitions and call it where needed, i.e. when we update an action definition we need to make sure to invalidate a corresponding cache value. For built-in actions it\u0027s not needed because they are immutable during the system lifespan but we also have ad-hoc actions which can be updated via API.\n\nSo please address this, otherwise even if we update an ad-hoc action the system will be seeing the outdated cached value. Please also write a test for this.","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1c3c844c5129fb2d232f309a8212bde6e7466b4f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    return len(_TASK_EX_CACHE)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"def invalidate_cached_task_executions(wf_ex_id):"},{"line_number":150,"context_line":"    with _CACHE_LOCK:"},{"line_number":151,"context_line":"        if wf_ex_id in _TASK_EX_CACHE:"},{"line_number":152,"context_line":"            del _TASK_EX_CACHE[wf_ex_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_7606d5d0","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":37},"in_reply_to":"1f485f77_6778738f","updated":"2017-11-16 15:31:17.000000000","message":"Done","commit_id":"af0168aae12c28bfc48ce9644059950926d079a0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"7a3907175cdd1f91eed24a7546f3e734efd9b74e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            del _TASK_EX_CACHE[wf_ex_id]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def invalidate_cached_action_definitions(action_name):"},{"line_number":161,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":162,"context_line":"        if action_name in _ACTION_DEF_CACHE:"},{"line_number":163,"context_line":"            del _ACTION_DEF_CACHE[action_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_315b3a88","line":160,"range":{"start_line":160,"start_character":39,"end_line":160,"end_character":40},"updated":"2017-11-20 08:11:44.000000000","message":"One action definition for one action name. It should be singular.","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5a1ece0f187aaf4367794ec181247cb48f8eb4ed","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            del _TASK_EX_CACHE[wf_ex_id]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def invalidate_cached_action_definitions(action_name):"},{"line_number":161,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":162,"context_line":"        if action_name in _ACTION_DEF_CACHE:"},{"line_number":163,"context_line":"            del _ACTION_DEF_CACHE[action_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_51db17ec","line":160,"range":{"start_line":160,"start_character":39,"end_line":160,"end_character":40},"in_reply_to":"ff82abbf_315b3a88","updated":"2017-12-05 12:41:29.000000000","message":"Done","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"7a3907175cdd1f91eed24a7546f3e734efd9b74e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        _TASK_EX_CACHE.clear()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def clear_action_definition_caches():"},{"line_number":172,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":173,"context_line":"        _ACTION_DEF_CACHE.clear()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_31d01aca","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":34},"updated":"2017-11-20 08:11:44.000000000","message":"In case of task executions plural is OK because we really have multiple caches (for each workflow execution). Here we have just one cache so let\u0027s make it singular. Also, it\u0027s inconsistent with \"get_action_definition_cache_size\" where you use singular.","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5a1ece0f187aaf4367794ec181247cb48f8eb4ed","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        _TASK_EX_CACHE.clear()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def clear_action_definition_caches():"},{"line_number":172,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":173,"context_line":"        _ACTION_DEF_CACHE.clear()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_71d65bc6","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":34},"in_reply_to":"ff82abbf_31d01aca","updated":"2017-12-05 12:41:29.000000000","message":"Done","commit_id":"6a8be201d656b1819b82d8407a0a0f7ef5a3cab5"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"eec6ecbe4252a3b7390d7084a63e2bd1ae43e268","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if action_definition:"},{"line_number":68,"context_line":"        return action_definition"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    action_definition \u003d db_api.load_action_definition(action_name)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":73,"context_line":"        _ACTION_DEF_CACHE[action_name] \u003d action_definition"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_cdc0e32d","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":66},"updated":"2017-12-05 15:11:35.000000000","message":"In actions.py we previously caught DBEntityNotFoudError which can be raised by this function call. Now we just check for a false-y value being returned form this function, but if an exception is raised on this line it will go uncaught.","commit_id":"d1ae67a0e0a013b82959c73a2e441cb38091c10f"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ec4dfe415d2667d1a0582c6c2a4de1e8b72c4d11","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if action_definition:"},{"line_number":68,"context_line":"        return action_definition"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    action_definition \u003d db_api.load_action_definition(action_name)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    with _ACTION_DEF_CACHE_LOCK:"},{"line_number":73,"context_line":"        _ACTION_DEF_CACHE[action_name] \u003d action_definition"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_6320089d","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":66},"in_reply_to":"df87a7cf_cdc0e32d","updated":"2017-12-13 11:25:53.000000000","message":"This is fine because all methods db_api.load_XXX just return None if the object doesn\u0027t exist in DB. Unlike methods db_api.get_XXX.","commit_id":"d1ae67a0e0a013b82959c73a2e441cb38091c10f"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"04a149ee3f208c5483092936fe80fff080c20cdc","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"_ACTION_DEF_CACHE \u003d cachetools.TTLCache("},{"line_number":58,"context_line":"    maxsize\u003d1000,"},{"line_number":59,"context_line":"    ttl\u003dCONF.engine.action_definition_cache_time  # 60 seconds by default"},{"line_number":60,"context_line":")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"_TASK_EX_CACHE_LOCK \u003d threading.RLock()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_42cb8471","line":59,"range":{"start_line":59,"start_character":50,"end_line":59,"end_character":73},"updated":"2018-02-15 07:40:43.000000000","message":"Soft: I would remove this comment because we\u0027ll have to change it every time when the default of the option changes.\n\nNot critical though, that\u0027s why it\u0027s \"Soft\"..","commit_id":"1ae082794a94cb0746fbbdde757c605816ce2c1d"}]}
