)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d5c7fcbe1bd9206373bec3822708efa649ff0d0c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-12-06 07:43:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP add extra yaql thinguies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d41c662d8659375750b52f7510e9a35f8b42f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_4f64b522","line":8,"updated":"2017-12-06 08:37:44.000000000","message":"blueprint reference would be good.","commit_id":"750331ce6b9408afa24af2b8802c869ec85f1747"}],"mistral/tests/unit/expressions/test_jinja_expression.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a5da8a54a198449d71b6ca0b0b31937d22428c03","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            result \u003d self._evaluator.evaluate(\u0027_|executions()\u0027, ctx)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            self.assertEqual([created0, created1], result)"},{"line_number":365,"context_line":"            db_api.rollback_tx()"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def test_executions_id_filter(self):"},{"line_number":368,"context_line":"        with db_api.transaction():"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_1c11d604","line":365,"range":{"start_line":365,"start_character":11,"end_line":365,"end_character":32},"updated":"2017-12-19 06:44:32.000000000","message":"Hm... This is interesting. I think we can use this approach in many other places too. We really don\u0027t need to commit a DB transaction in many case.\n\nI would just suggest an improvement here: we can add the parameter \"read_only\" to the method db_api.transaction() and if it\u0027s True (False by default) then the transaction will always rollback.\n\nNot necessary to do this in this commit. We\u0027ll improve that later. I filed a blueprint to track this: https://blueprints.launchpad.net/mistral/+spec/mistral-readonly-db-transactions","commit_id":"d5552c8d6243f28b5b3f1aa8169aad9c67637a1d"}],"mistral/utils/expression_utils.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d5c7fcbe1bd9206373bec3822708efa649ff0d0c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                id\u003dNone,"},{"line_number":107,"context_line":"                root_execution_id\u003dNone,"},{"line_number":108,"context_line":"                state\u003dNone):"},{"line_number":109,"context_line":"    from mistral.utils import filter_utils"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    _filter \u003d {}"},{"line_number":112,"context_line":"    if id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_af2a218d","line":109,"updated":"2017-12-06 08:37:44.000000000","message":"Any reason to import here?","commit_id":"750331ce6b9408afa24af2b8802c869ec85f1747"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"b0a461801433bfdaa49420413a70c6dc44dff2f3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                id\u003dNone,"},{"line_number":107,"context_line":"                root_execution_id\u003dNone,"},{"line_number":108,"context_line":"                state\u003dNone):"},{"line_number":109,"context_line":"    from mistral.utils import filter_utils"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    _filter \u003d {}"},{"line_number":112,"context_line":"    if id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_299fe3b4","line":109,"in_reply_to":"df87a7cf_af2a218d","updated":"2017-12-06 15:19:30.000000000","message":"yes there is: laziness on a WIP :)","commit_id":"750331ce6b9408afa24af2b8802c869ec85f1747"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d5c7fcbe1bd9206373bec3822708efa649ff0d0c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                state\u003dNone):"},{"line_number":109,"context_line":"    from mistral.utils import filter_utils"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    _filter \u003d {}"},{"line_number":112,"context_line":"    if id is not None:"},{"line_number":113,"context_line":"        _filter \u003d filter_utils.create_or_update_filter("},{"line_number":114,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_aae20f2e","line":111,"range":{"start_line":111,"start_character":4,"end_line":111,"end_character":11},"updated":"2017-12-06 08:37:44.000000000","message":"filter_ is generally the form to avoid builtin conflicts (but you didn\u0027t do it with \"id\") so maybe just \"filter\" is fine.","commit_id":"750331ce6b9408afa24af2b8802c869ec85f1747"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"b0a461801433bfdaa49420413a70c6dc44dff2f3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                state\u003dNone):"},{"line_number":109,"context_line":"    from mistral.utils import filter_utils"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    _filter \u003d {}"},{"line_number":112,"context_line":"    if id is not None:"},{"line_number":113,"context_line":"        _filter \u003d filter_utils.create_or_update_filter("},{"line_number":114,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_69e2cb31","line":111,"range":{"start_line":111,"start_character":4,"end_line":111,"end_character":11},"in_reply_to":"df87a7cf_aae20f2e","updated":"2017-12-06 15:19:30.000000000","message":"Done","commit_id":"750331ce6b9408afa24af2b8802c869ec85f1747"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a5da8a54a198449d71b6ca0b0b31937d22428c03","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            id,"},{"line_number":120,"context_line":"            \"eq\","},{"line_number":121,"context_line":"            filter"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":"    if root_execution_id is not None:"},{"line_number":124,"context_line":"        filter \u003d utils.filter_utils.create_or_update_filter("},{"line_number":125,"context_line":"            \u0027root_execution_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_dc7b6e25","line":122,"updated":"2017-12-19 06:44:32.000000000","message":"Soft: Usually we insert a blank line before \"if\", \"return\" etc. if it is not the first line of the method.","commit_id":"d5552c8d6243f28b5b3f1aa8169aad9c67637a1d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a5da8a54a198449d71b6ca0b0b31937d22428c03","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            filter"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    wf_executions \u003d db_api.get_workflow_executions(**filter)"},{"line_number":156,"context_line":"    return wf_executions"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_bc954a42","line":155,"range":{"start_line":155,"start_character":4,"end_line":155,"end_character":17},"updated":"2017-12-19 06:44:32.000000000","message":"Soft: we can inline this var.","commit_id":"d5552c8d6243f28b5b3f1aa8169aad9c67637a1d"}]}
