)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"73eb96b23620949725641f3854af42136ea7a88c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Renat Akhmerov \u003crenat.akhmerov@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-12 04:37:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the \u0027error_data\u0027 parameter to the FailAction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I679b8338dade284817000670e96ab108481372ae"},{"line_number":10,"context_line":"Signed-off-by: Vitalii Solodilov \u003cmcdkr@yandex.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa0c359_fd716a45","line":7,"updated":"2018-02-12 11:09:59.000000000","message":"Please expand on this commit message. This tells me what you changed but not why. In a previous patch set I asked why you need this, providing a motivation and use case in the commit message is useful.","commit_id":"adb011768beec565445985073ad52b802eb679eb"}],"doc/source/user/dsl_v2.rst":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b92b5dbbb10dc72b68e02cec2e2280f3bab44ef","unresolved":false,"context_lines":[{"line_number":839,"context_line":"std.fail"},{"line_number":840,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"Fail the current task. This action can be used to manually set the task"},{"line_number":843,"context_line":"state to error."},{"line_number":844,"context_line":""},{"line_number":845,"context_line":".. code-block:: mistral"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f93b717_045e3375","line":843,"range":{"start_line":842,"start_character":0,"end_line":843,"end_character":14},"updated":"2018-02-01 09:15:54.000000000","message":"Neither of these two definitions is correct. The left one has nothing to do with truth at all.\n\nWhat really happens is that the action fails and it\u0027s state becomes ERROR. Not the state of the task. And then depending on how the task is configured (whether it has \"on-error\" or not) Mistral changes the task state.","commit_id":"7fc4edadbc304d9b5ad43f82dd36e79e23d0b074"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b92b5dbbb10dc72b68e02cec2e2280f3bab44ef","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":".. code-block:: mistral"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"  version: \u00272\u0027"},{"line_number":848,"context_line":"  wf:"},{"line_number":849,"context_line":"    tasks:"},{"line_number":850,"context_line":"      manual_fail:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f93b717_841563e7","line":847,"range":{"start_line":847,"start_character":2,"end_line":847,"end_character":14},"updated":"2018-02-01 09:15:54.000000000","message":"I would omit this clause. It\u0027s not important in this context.","commit_id":"7fc4edadbc304d9b5ad43f82dd36e79e23d0b074"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b92b5dbbb10dc72b68e02cec2e2280f3bab44ef","unresolved":false,"context_lines":[{"line_number":856,"context_line":""},{"line_number":857,"context_line":".. code-block:: mistral"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"  version: \u00272\u0027"},{"line_number":860,"context_line":"  wf:"},{"line_number":861,"context_line":"    tasks:"},{"line_number":862,"context_line":"      manual_fail:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f93b717_44d99b54","line":859,"range":{"start_line":859,"start_character":2,"end_line":859,"end_character":14},"updated":"2018-02-01 09:15:54.000000000","message":"Same.","commit_id":"7fc4edadbc304d9b5ad43f82dd36e79e23d0b074"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b92b5dbbb10dc72b68e02cec2e2280f3bab44ef","unresolved":false,"context_lines":[{"line_number":860,"context_line":"  wf:"},{"line_number":861,"context_line":"    tasks:"},{"line_number":862,"context_line":"      manual_fail:"},{"line_number":863,"context_line":"        action: std.fail"},{"line_number":864,"context_line":"        input:"},{"line_number":865,"context_line":"          error_data:"},{"line_number":866,"context_line":"            x: 1"},{"line_number":867,"context_line":"            y: 2"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"std.http"},{"line_number":870,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f93b717_4452fb3c","line":867,"range":{"start_line":863,"start_character":8,"end_line":867,"end_character":16},"updated":"2018-02-01 09:15:54.000000000","message":"I would use more elegant way:\n\naction: std.fail error_data\u003d{x:1,y:2}\n\nIt should work.","commit_id":"7fc4edadbc304d9b5ad43f82dd36e79e23d0b074"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"0380b87b0a265e634b12eac2cd9a49c6078b46df","unresolved":false,"context_lines":[{"line_number":839,"context_line":"std.fail"},{"line_number":840,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"This action is always failed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":".. code-block:: mistral"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f93b717_fda95a8f","line":842,"updated":"2018-02-01 10:39:50.000000000","message":"The previous version of this read better IMO","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"636382dd4fa351d56554f1d8aa8f801f1dd2f0a5","unresolved":false,"context_lines":[{"line_number":839,"context_line":"std.fail"},{"line_number":840,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"This action is always failed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":".. code-block:: mistral"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa0c359_e6d66ff2","line":842,"in_reply_to":"5f93b717_fda95a8f","updated":"2018-02-05 07:28:15.000000000","message":"Yes, but it was wrong.\n\nPlease make it \"This action always fails\".","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"0380b87b0a265e634b12eac2cd9a49c6078b46df","unresolved":false,"context_lines":[{"line_number":848,"context_line":"      manual_fail:"},{"line_number":849,"context_line":"        action: std.fail"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"Moreover, you can pass the `error_data` parameter, and this action will be"},{"line_number":852,"context_line":"failed and returns this data as error data."},{"line_number":853,"context_line":""},{"line_number":854,"context_line":".. code-block:: mistral"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f93b717_dd7b3e25","line":852,"range":{"start_line":851,"start_character":0,"end_line":852,"end_character":43},"updated":"2018-02-01 10:39:50.000000000","message":"Re-wording suggestion.\n\nThe action can be passed the `error_data` parameter. This data will be used as the action return value.","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"636382dd4fa351d56554f1d8aa8f801f1dd2f0a5","unresolved":false,"context_lines":[{"line_number":848,"context_line":"      manual_fail:"},{"line_number":849,"context_line":"        action: std.fail"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"Moreover, you can pass the `error_data` parameter, and this action will be"},{"line_number":852,"context_line":"failed and returns this data as error data."},{"line_number":853,"context_line":""},{"line_number":854,"context_line":".. code-block:: mistral"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa0c359_86052b7d","line":852,"range":{"start_line":851,"start_character":0,"end_line":852,"end_character":43},"in_reply_to":"5f93b717_dd7b3e25","updated":"2018-02-05 07:28:15.000000000","message":"Agree with Dougal.","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"0380b87b0a265e634b12eac2cd9a49c6078b46df","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    tasks:"},{"line_number":858,"context_line":"      manual_fail:"},{"line_number":859,"context_line":"        action: std.fail"},{"line_number":860,"context_line":"        input: error_data\u003d{x:1,y:2}"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"std.http"},{"line_number":863,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f93b717_1db446d0","line":860,"updated":"2018-02-01 10:39:50.000000000","message":"What is the use-case for this feature? I feel like it would be the same as doing this...\n\n\nmanual_fail:\n  action: std.fail\n  publish-on-error:\n    error_data: \u003c% {x\u003d\u003e1, y\u003d\u003e2} %\u003e","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"636382dd4fa351d56554f1d8aa8f801f1dd2f0a5","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    tasks:"},{"line_number":858,"context_line":"      manual_fail:"},{"line_number":859,"context_line":"        action: std.fail"},{"line_number":860,"context_line":"        input: error_data\u003d{x:1,y:2}"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"std.http"},{"line_number":863,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa0c359_6639ff3f","line":860,"in_reply_to":"5f93b717_1db446d0","updated":"2018-02-05 07:28:15.000000000","message":"Technically there\u0027s a difference. Any publishing touches workflow context, whereas action result itself doesn\u0027t.\n\nBut as far as the use case, I really would like to know. I had the same question in mind when I was reviewing the patch for the first time. Regardless of a use case though I feel that there will be no harm in this parameter. It seems consistent to me with the semantics of the action.","commit_id":"992a3c8a6df381a7bcd27832ade4d85800e317cc"}],"doc/source/user/wf_lang_v2.rst":[{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"bde7fabb1b931484ca24ee1cd6bafff8275ff1f4","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_1dde966c","line":858,"updated":"2018-02-12 10:47:41.000000000","message":"I think keeping the phrase \"This action can be used to manually set the workflow state to error\" is important for the new user","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"73eb96b23620949725641f3854af42136ea7a88c","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_3d6b521e","line":858,"in_reply_to":"3fa0c359_1dde966c","updated":"2018-02-12 11:09:59.000000000","message":"Maybe something like this:\n\nThis action always fails. It can be used to manually set the workflow to an error state.","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7d08c576c52d1ea185a0519693647b89ade1b7c5","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_f094ef8c","line":858,"in_reply_to":"3fa0c359_2eca05a0","updated":"2018-02-14 14:08:32.000000000","message":"FWIW, the documentation is only a minor thing for me. I still think we need to understand the purpose of this feature before we add it. Hopefully Vitalii can help with that.","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5982511f27ce841a78a1cc8201769989454dc4d","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_b36e95c6","line":858,"in_reply_to":"3fa0c359_3d6b521e","updated":"2018-02-13 09:41:09.000000000","message":"No-no, I directly pointed before that this previous phrasing is wrong. An action itself *does not set the workflow to an error state*. To do that, we have the \"fail\" command that does exactly that. But if an action fails it still can be handled on the task level with \"on-error\" clause.\n\nSo I think this new description is mathematically more strict (precise).","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7e1fe8d5d814652f9e86d725adb8bb363869c74e","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_94624dad","line":858,"in_reply_to":"3fa0c359_51714943","updated":"2018-02-13 23:33:41.000000000","message":"“This action always fails. It can be used to manually fail a workflow task.”","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"57d50308ef9db50880039eb53e38e1d76ee424f1","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_2eca05a0","line":858,"in_reply_to":"3fa0c359_94624dad","updated":"2018-02-14 07:14:30.000000000","message":"Yes! )","commit_id":"adb011768beec565445985073ad52b802eb679eb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"29469131808711f95f914002bae3ac25be81a2c4","unresolved":false,"context_lines":[{"line_number":855,"context_line":"std.fail"},{"line_number":856,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"This action always fails."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":".. code-block:: mistral"},{"line_number":861,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa0c359_51714943","line":858,"in_reply_to":"3fa0c359_b36e95c6","updated":"2018-02-13 11:18:09.000000000","message":"Yes, I understand this. However, I consider the new documentation to be incomplete and not very useful. From the point of view of a workflow author you can use the action to fail a workflow. I am trying to convey that message.\n\nI think the documentation needs to state what it can do and why you would want to do it. Can you suggest a different way to explain that?","commit_id":"adb011768beec565445985073ad52b802eb679eb"}],"mistral/actions/std_actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8b92b5dbbb10dc72b68e02cec2e2280f3bab44ef","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class FailAction(actions.Action):"},{"line_number":81,"context_line":"    \"\"\"\u0027Always fail\u0027 action."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    If you pass the `error_data` parameter, this Action will be failed and"},{"line_number":84,"context_line":"    return this data as error data. Otherwise, the action just throws an"},{"line_number":85,"context_line":"    instance of ActionException."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_a73e61be","line":83,"range":{"start_line":83,"start_character":49,"end_line":83,"end_character":55},"updated":"2018-02-01 09:15:54.000000000","message":"-\u003e action\n\nNo need to use camel case in a regular sentence.","commit_id":"7fc4edadbc304d9b5ad43f82dd36e79e23d0b074"}]}
