)]}'
{"mistral/lang/v2/workflows.py":[{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"08b46b9ad7bb795ca1c66db1434d7ef3f9233db4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"Workflow name cannot be in the format of UUID.\""},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._verify_task_names()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _verify_task_names(self):"},{"line_number":95,"context_line":"        for task in self.get_tasks():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_56260d6a","line":92,"updated":"2018-01-18 18:42:14.000000000","message":"Maybe we can check a task name the same way https://review.openstack.org/#/c/528494/3/mistral/lang/v2/tasks.py in TaskSpec?","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6a565fe530cc1fa386e518967fe49fb809bbaccf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"Workflow name cannot be in the format of UUID.\""},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._verify_task_names()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _verify_task_names(self):"},{"line_number":95,"context_line":"        for task in self.get_tasks():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_cefa76bb","line":92,"in_reply_to":"7f96bb07_56260d6a","updated":"2018-01-19 04:47:21.000000000","message":"Yes, agree. The idea of having a separate specification class for every workflow language entity is to make them responsible for everything related to these entities. All logic related to tasks (validation, additional calculations) should be encapsulated within TaskSpec.","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"},{"author":{"_account_id":27349,"name":"Hardik Jasani","email":"hardik.jasani@nokia.com","username":"hardikj"},"change_message_id":"f17d89bdaef07372ae1698d72c4c2cc3e88bda6c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"Workflow name cannot be in the format of UUID.\""},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._verify_task_names()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _verify_task_names(self):"},{"line_number":95,"context_line":"        for task in self.get_tasks():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_4725e4aa","line":92,"in_reply_to":"7f96bb07_56260d6a","updated":"2018-01-19 09:38:43.000000000","message":"You are right, should be done in TaskSpec.","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"},{"author":{"_account_id":27349,"name":"Hardik Jasani","email":"hardik.jasani@nokia.com","username":"hardikj"},"change_message_id":"f17d89bdaef07372ae1698d72c4c2cc3e88bda6c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \"Workflow name cannot be in the format of UUID.\""},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._verify_task_names()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _verify_task_names(self):"},{"line_number":95,"context_line":"        for task in self.get_tasks():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_275538fb","line":92,"in_reply_to":"7f96bb07_cefa76bb","updated":"2018-01-19 09:38:43.000000000","message":"Right, moving to proper place.","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"}],"mistral/tests/unit/workflow/test_workflow_base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6a565fe530cc1fa386e518967fe49fb809bbaccf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            reverse_wf.ReverseWorkflowController"},{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_duplicate_task_name(self):"},{"line_number":82,"context_line":"        self.assertRaises("},{"line_number":83,"context_line":"            exc.InvalidModelException,"},{"line_number":84,"context_line":"            spec_parser.get_workflow_list_spec_from_yaml,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_ae14cae9","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":32},"updated":"2018-01-19 04:47:21.000000000","message":"Why \"duplicate\" in the naming?\n\nPlease also add more tests. We need to make sure to test every reserved word as a task name.","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"},{"author":{"_account_id":27349,"name":"Hardik Jasani","email":"hardik.jasani@nokia.com","username":"hardikj"},"change_message_id":"f17d89bdaef07372ae1698d72c4c2cc3e88bda6c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            reverse_wf.ReverseWorkflowController"},{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_duplicate_task_name(self):"},{"line_number":82,"context_line":"        self.assertRaises("},{"line_number":83,"context_line":"            exc.InvalidModelException,"},{"line_number":84,"context_line":"            spec_parser.get_workflow_list_spec_from_yaml,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_6774a09d","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":32},"in_reply_to":"7f96bb07_ae14cae9","updated":"2018-01-19 09:38:43.000000000","message":"Oops. Will add tests for all reserved words and and move this to test_workflow_service.py","commit_id":"5e9a9449930b426f658d715cf02bd94f8bc05a26"}]}
