)]}'
{"mistral/engine/action_queue.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6d366ef3c4d604b5fbe5878258069fcaa603c9fd","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for operation, args in queue:"},{"line_number":59,"context_line":"        if operation \u003d\u003d _RUN_ACTION:"},{"line_number":60,"context_line":"            action_ex, action_def, target, execution_context, \\"},{"line_number":61,"context_line":"                timeout \u003d args"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            executor.run_action("}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_588a771b","line":60,"range":{"start_line":60,"start_character":62,"end_line":60,"end_character":63},"updated":"2018-02-06 13:52:04.000000000","message":"Not if this is critical now but it was previously not allowed according to ghe OpenStack guidelines.","commit_id":"b79f91e9ec5be543f857ad97c991739750caee6d"}],"mistral/engine/policies.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6d366ef3c4d604b5fbe5878258069fcaa603c9fd","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_CONTINUE_TASK_PATH \u003d \u0027mistral.engine.policies._continue_task\u0027"},{"line_number":30,"context_line":"_COMPLETE_TASK_PATH \u003d \u0027mistral.engine.policies._complete_task\u0027"},{"line_number":31,"context_line":"_FAIL_IF_INCOMPLETE_TASK_PATH \u003d \\"},{"line_number":32,"context_line":"    \u0027mistral.engine.policies._fail_task_if_incomplete\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_588fd722","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":33},"updated":"2018-02-06 13:52:04.000000000","message":"I\u0027d better use parenthesis instead of a backslash to wrap a string value.","commit_id":"b79f91e9ec5be543f857ad97c991739750caee6d"}],"mistral/engine/tasks.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"026dd037b71b2824e0af3bb762d634fcf6a5bad4","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    def _get_timeout(self):"},{"line_number":511,"context_line":"        timeout \u003d self.task_spec.get_policies().get_timeout()"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        if type(timeout) !\u003d int and type(timeout) !\u003d float:"},{"line_number":514,"context_line":"            wf_ex \u003d self.task_ex.workflow_execution"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"            ctx_view \u003d data_flow.ContextView("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_8cd94af4","line":513,"updated":"2018-01-30 10:23:33.000000000","message":"I think this check might be better...\n\nisinstance(timeout, (int, float))","commit_id":"9bd44ab2ee7f53d733ff27fd1f9a824721e89e02"}],"mistral/executors/default_executor.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"026dd037b71b2824e0af3bb762d634fcf6a5bad4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            if not isinstance(result, mistral_lib.Result):"},{"line_number":122,"context_line":"                result \u003d mistral_lib.Result(data\u003dresult)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        except BaseException as e:"},{"line_number":125,"context_line":"            msg \u003d ("},{"line_number":126,"context_line":"                \"Failed to run action [action_ex_id\u003d%s, action_cls\u003d\u0027%s\u0027, \""},{"line_number":127,"context_line":"                \"attributes\u003d\u0027%s\u0027, params\u003d\u0027%s\u0027]\\n %s\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_cc167256","line":124,"updated":"2018-01-30 10:23:33.000000000","message":"What exception does eventlet raise? I would suggest that we catch that exception and provide a different msg on a timeout.","commit_id":"9bd44ab2ee7f53d733ff27fd1f9a824721e89e02"}],"mistral/tests/unit/engine/test_policies.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6d366ef3c4d604b5fbe5878258069fcaa603c9fd","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        self.await_workflow_error(wf_ex.id)"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"    def test_action_timeout(self):"},{"line_number":1440,"context_line":"        wb \u003d \"\"\"---"},{"line_number":1441,"context_line":"        version: \u00272.0\u0027"},{"line_number":1442,"context_line":"        wf1:"},{"line_number":1443,"context_line":"          tasks:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_18006f67","line":1440,"range":{"start_line":1440,"start_character":8,"end_line":1440,"end_character":10},"updated":"2018-02-06 13:52:04.000000000","message":"Usually we use \"wb\" as a shortcut of \"workbook\". But this is indeed not a workbook. I would call it \"wf_text\" rather that precisely reflects the semantics.","commit_id":"b79f91e9ec5be543f857ad97c991739750caee6d"}]}
