)]}'
{"tools/docker/Dockerfile":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      libuv1 \\"},{"line_number":23,"context_line":"      swig \\"},{"line_number":24,"context_line":"      mc \\"},{"line_number":25,"context_line":"      python-pip \\"},{"line_number":26,"context_line":"      python-setuptools \\"},{"line_number":27,"context_line":"      libuv1-dev \u0026\u0026 \\"},{"line_number":28,"context_line":"      pip install -U pip \u0026\u0026 \\"},{"line_number":29,"context_line":"        pip install mysql-python psycopg2 python-mistralclient"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ARG BUILD_V8EVAL\u003d\"true\""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_c0429d3e","line":28,"range":{"start_line":25,"start_character":5,"end_line":28,"end_character":26},"updated":"2018-03-14 06:34:37.000000000","message":"The apt python-pip and the pip install mess with the same files. I understand that this is a chicken-and-egg problem. We could solve it by restructuring like this:\n\nRUN curl -f -o /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py \u0026\u0026 python /tmp/get-pip.py \u0026\u0026 rm /tmp/get-pip.py \u0026\u0026\\\n      pip install pymysql psycopg2","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      python-setuptools \\"},{"line_number":27,"context_line":"      libuv1-dev \u0026\u0026 \\"},{"line_number":28,"context_line":"      pip install -U pip \u0026\u0026 \\"},{"line_number":29,"context_line":"        pip install mysql-python psycopg2 python-mistralclient"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ARG BUILD_V8EVAL\u003d\"true\""},{"line_number":32,"context_line":"RUN (${BUILD_V8EVAL} \u0026\u0026 pip install -v v8eval \u0026\u0026 python -c \u0027import v8eval\u0027) || true"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_28e26ea1","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":62},"updated":"2018-03-14 06:34:37.000000000","message":"- I\u0027d move this line below line 33 for better layering\n- Instead of mysql-python we should start promoting pymysql. A comment in this thread revealed this to me: https://bitbucket.org/zzzeek/sqlalchemy/issues/3497/connectionrec-recycle-can-create-situation\n- installing the mistral client here can conflict with the mistral install as mistral itself depends on the client but there the install is version constrained.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"a000209ed0deb7ba6a83c10954427fb569e7e93b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      python-setuptools \\"},{"line_number":27,"context_line":"      libuv1-dev \u0026\u0026 \\"},{"line_number":28,"context_line":"      pip install -U pip \u0026\u0026 \\"},{"line_number":29,"context_line":"        pip install mysql-python psycopg2 python-mistralclient"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ARG BUILD_V8EVAL\u003d\"true\""},{"line_number":32,"context_line":"RUN (${BUILD_V8EVAL} \u0026\u0026 pip install -v v8eval \u0026\u0026 python -c \u0027import v8eval\u0027) || true"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_82977c3a","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":62},"in_reply_to":"df7087c5_28e26ea1","updated":"2018-03-17 20:50:35.000000000","message":"\u003e - I\u0027d move this line below line 33 for better layering\n\nI moved to separate line but higher because we must cache a layer as possible.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        pip install mysql-python psycopg2 python-mistralclient"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ARG BUILD_V8EVAL\u003d\"true\""},{"line_number":32,"context_line":"RUN (${BUILD_V8EVAL} \u0026\u0026 pip install -v v8eval \u0026\u0026 python -c \u0027import v8eval\u0027) || true"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"ENV MISTRAL_DIR\u003d\"/opt/stack/mistral\" \\"},{"line_number":35,"context_line":"    TMP_CONSTRAINTS\u003d\"/tmp/upper-constraints.txt\" \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_688aa6bf","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":83},"updated":"2018-03-14 06:34:37.000000000","message":"The `true` can hide errors in the build process. It would be more appropriate to use an `if` here.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"a000209ed0deb7ba6a83c10954427fb569e7e93b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"COPY requirements.txt \"${MISTRAL_DIR}/\""},{"line_number":48,"context_line":"RUN curl -o \"${TMP_CONSTRAINTS}\" \\"},{"line_number":49,"context_line":"    http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt \u0026\u0026 \\"},{"line_number":50,"context_line":"    sed -i \"/^mistral.*/d\" \"${TMP_CONSTRAINTS}\" \u0026\u0026 \\"},{"line_number":51,"context_line":"    pip install -r \"${MISTRAL_DIR}/requirements.txt\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ARG BUILD_TEST_DEPENDENCIES\u003d\"false\""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_0a15bee4","line":50,"updated":"2018-03-17 20:50:35.000000000","message":"Please, explain me what these commands must do. I think they doesn\u0027t work.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"718e3110b92cdd3e68c744370f2f8a734e318ac4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"COPY requirements.txt \"${MISTRAL_DIR}/\""},{"line_number":48,"context_line":"RUN curl -o \"${TMP_CONSTRAINTS}\" \\"},{"line_number":49,"context_line":"    http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt \u0026\u0026 \\"},{"line_number":50,"context_line":"    sed -i \"/^mistral.*/d\" \"${TMP_CONSTRAINTS}\" \u0026\u0026 \\"},{"line_number":51,"context_line":"    pip install -r \"${MISTRAL_DIR}/requirements.txt\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ARG BUILD_TEST_DEPENDENCIES\u003d\"false\""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_d600acae","line":50,"in_reply_to":"df7087c5_0a15bee4","updated":"2018-03-19 05:53:33.000000000","message":"The `pip install` must be constrained to install a given version of the dependencies, instead of the newest one. This is a prerequisite to reproducible builds. The constraints file contains lines referring to mistral as well, and these must be removed, otherwise the install will fail.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"ARG BUILD_TEST_DEPENDENCIES\u003d\"false\""},{"line_number":54,"context_line":"COPY test-requirements.txt \"${MISTRAL_DIR}/\""},{"line_number":55,"context_line":"RUN (${BUILD_TEST_DEPENDENCIES} \u0026\u0026 \\"},{"line_number":56,"context_line":"    pip install -r \"${MISTRAL_DIR}/test-requirements.txt\") || true"},{"line_number":57,"context_line":"COPY . ${MISTRAL_DIR}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN pip install -e \"${MISTRAL_DIR}\" \u0026\u0026 \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"df7087c5_27a7dd0d","line":56,"range":{"start_line":56,"start_character":3,"end_line":56,"end_character":66},"updated":"2018-03-14 06:34:37.000000000","message":"same as above","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"}],"tools/docker/docker-compose/mistral-single-node.yaml":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"services:"},{"line_number":3,"context_line":"  mistral:"},{"line_number":4,"context_line":"    build:"},{"line_number":5,"context_line":"      context: ../../.."},{"line_number":6,"context_line":"      dockerfile: \"tools/docker/Dockerfile\""},{"line_number":7,"context_line":"    restart: always"},{"line_number":8,"context_line":"    ports:"},{"line_number":9,"context_line":"      - \"8989:8989\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_e6801e49","line":6,"range":{"start_line":5,"start_character":6,"end_line":6,"end_character":43},"updated":"2018-03-14 06:34:37.000000000","message":"The image is not automatically rebuilt even if the Dockerfile changed. This should be mentioned in the docs but I would rather set up the system to a prebuilt image and not build it this way. It was painful to figure out how I could pass build args for `docker-compose up` and I actually failed to do so. (Not sure if it\u0027s possible) This may be a triviality for docker-compose magicians but should be documented or not used.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"a000209ed0deb7ba6a83c10954427fb569e7e93b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"services:"},{"line_number":3,"context_line":"  mistral:"},{"line_number":4,"context_line":"    build:"},{"line_number":5,"context_line":"      context: ../../.."},{"line_number":6,"context_line":"      dockerfile: \"tools/docker/Dockerfile\""},{"line_number":7,"context_line":"    restart: always"},{"line_number":8,"context_line":"    ports:"},{"line_number":9,"context_line":"      - \"8989:8989\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_fbda8277","line":6,"range":{"start_line":5,"start_character":6,"end_line":6,"end_character":43},"in_reply_to":"df7087c5_e6801e49","updated":"2018-03-17 20:50:35.000000000","message":"Do we push the Mistral image to some artifactory? Otherwise I don\u0027t understand how we set a pre-build image.\nI added build arg to all of mistral services. Also I don\u0027t build the v8eval by default. It takes too much time. I thought that it is broken when i built first time :)","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"718e3110b92cdd3e68c744370f2f8a734e318ac4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"services:"},{"line_number":3,"context_line":"  mistral:"},{"line_number":4,"context_line":"    build:"},{"line_number":5,"context_line":"      context: ../../.."},{"line_number":6,"context_line":"      dockerfile: \"tools/docker/Dockerfile\""},{"line_number":7,"context_line":"    restart: always"},{"line_number":8,"context_line":"    ports:"},{"line_number":9,"context_line":"      - \"8989:8989\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_560d7ce6","line":6,"range":{"start_line":5,"start_character":6,"end_line":6,"end_character":43},"in_reply_to":"df7087c5_fbda8277","updated":"2018-03-19 05:53:33.000000000","message":"We don\u0027t have to push. Just build the image before with `docker build`. How do you give the build-args to docker-`compose up`?","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"}],"tools/docker/mistral.env":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"MESSAGE_BROKER_URL\u003drabbit://mistral:mistral@rabbitmq:5672/mistral"},{"line_number":2,"context_line":"#DATABASE_URL\u003dpostgresql://mistral:mistral@postgresql:5432/mistral"},{"line_number":3,"context_line":"DATABASE_URL\u003dmysql://mistral:mistral@mysql:3306/mistral"}],"source_content_type":"application/x-envoy","patch_set":5,"id":"df7087c5_8bfb6b77","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":18},"updated":"2018-03-14 06:34:37.000000000","message":"To avoid a warning at startup, let\u0027s fully specify protocol part: mysql+pymysql\n\nURL mysql://mistral:***@mysql:3306/mistral does not contain a \u0027+drivername\u0027 portion, and will make use of a default driver.  A full dbname+drivername:// protocol is recommended. For MySQL, it is strongly recommended that mysql+pymysql:// be specified for maximum service compatibility","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"9636c26094a0221161bb02c76be04b1f6a73c97b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df7087c5_8bcdab67","line":4,"updated":"2018-03-14 06:34:37.000000000","message":"This file is used by docker-compose so I guess it would be better put in that folder.","commit_id":"73fc2268141eb7b1d47e060cf0b5d21bfb702960"}]}
