)]}'
{"mistral/db/v2/sqlalchemy/models.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8eff1797a997eda983e262b670219c35c5387503","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        size_kb \u003d int(sys.getsizeof(str(value)) / 1024)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if size_kb \u003e size_limit_kb:"},{"line_number":68,"context_line":"            LOG.error("},{"line_number":69,"context_line":"                \"Size limit %dKB exceed for class [%s], \""},{"line_number":70,"context_line":"                \"field %s of size %dKB.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_d7036572","line":67,"updated":"2018-03-12 18:16:49.000000000","message":"Why we can\u0027t just:\n\nmsg \u003d \"Size limit %dKB exceed for class [%s], field %s of size %dKB.\" % (size_limit_kb, str(cls), field_name, size_kb)\n\nLOG.error(msg)\n\nraise exc.SizeLimitExceededException(msg)","commit_id":"b7ee97a87721d7b1149ee35e445bd972d2a31f59"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"8c97d312945fdc604b482ae9a162e8f825e448cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                size_limit_kb"},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            LOG.error(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            raise exc.SizeLimitExceededException(msg)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_02540752","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":26},"updated":"2018-03-14 07:30:20.000000000","message":"Is it necessary to log this message here? The exception should contain the exact traceback and the same message.","commit_id":"3e042238886e9a3640469423bbdf241832233b7e"}],"mistral/exceptions.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8eff1797a997eda983e262b670219c35c5387503","unresolved":false,"context_lines":[{"line_number":185,"context_line":"class SizeLimitExceededException(MistralException):"},{"line_number":186,"context_line":"    http_code \u003d 400"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @staticmethod"},{"line_number":189,"context_line":"    def create(field_name, size_kb, size_limit_kb):"},{"line_number":190,"context_line":"        return SizeLimitExceededException("},{"line_number":191,"context_line":"            \"Size of \u0027%s\u0027 is %dKB which exceeds the limit of %dKB\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_17e1ddd0","line":188,"updated":"2018-03-12 18:16:49.000000000","message":"Is not it easier to remove this method altogether and pass a string at the exception raise?","commit_id":"b7ee97a87721d7b1149ee35e445bd972d2a31f59"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0e915bc7213d7e88bc0484be3d98b8c74e724483","unresolved":false,"context_lines":[{"line_number":185,"context_line":"class SizeLimitExceededException(MistralException):"},{"line_number":186,"context_line":"    http_code \u003d 400"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @staticmethod"},{"line_number":189,"context_line":"    def create(field_name, size_kb, size_limit_kb):"},{"line_number":190,"context_line":"        return SizeLimitExceededException("},{"line_number":191,"context_line":"            \"Size of \u0027%s\u0027 is %dKB which exceeds the limit of %dKB\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_03a2f2fd","line":188,"in_reply_to":"df7087c5_17e1ddd0","updated":"2018-03-13 04:54:29.000000000","message":"Ok, I think I agree. I didn\u0027t notice that we call this method only from one place. You\u0027re right. Thanks.","commit_id":"b7ee97a87721d7b1149ee35e445bd972d2a31f59"}],"mistral/rpc/base.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"c997ea42d37e3e9ea5cbf41fec4969ab99aa0174","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        except exc.MistralException:"},{"line_number":101,"context_line":"            raise"},{"line_number":102,"context_line":"        except (client.RemoteError, exc.KombuException, Exception) as e:"},{"line_number":103,"context_line":"            # Since we\u0027re going to transform the original exception"},{"line_number":104,"context_line":"            # we need to log it as is."},{"line_number":105,"context_line":"            LOG.exception("},{"line_number":106,"context_line":"                \"Caught a messaging remote error.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_6798106a","line":103,"updated":"2018-03-07 14:03:22.000000000","message":"Where are we logging the original exception?","commit_id":"6eb00b15476003ef0ab270ec26f6d54c6ca302f7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b0be62e23500e81437b89fcc3ad527702fe16ca1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        except exc.MistralException:"},{"line_number":101,"context_line":"            raise"},{"line_number":102,"context_line":"        except (client.RemoteError, exc.KombuException, Exception) as e:"},{"line_number":103,"context_line":"            # Since we\u0027re going to transform the original exception"},{"line_number":104,"context_line":"            # we need to log it as is."},{"line_number":105,"context_line":"            LOG.exception("},{"line_number":106,"context_line":"                \"Caught a messaging remote error.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_f2cc8a62","line":103,"in_reply_to":"df7087c5_098fd523","updated":"2018-03-12 05:17:35.000000000","message":"yes","commit_id":"6eb00b15476003ef0ab270ec26f6d54c6ca302f7"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"bb9a4e0e4185b961d7eb5313d817214ca4c59d17","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        except exc.MistralException:"},{"line_number":101,"context_line":"            raise"},{"line_number":102,"context_line":"        except (client.RemoteError, exc.KombuException, Exception) as e:"},{"line_number":103,"context_line":"            # Since we\u0027re going to transform the original exception"},{"line_number":104,"context_line":"            # we need to log it as is."},{"line_number":105,"context_line":"            LOG.exception("},{"line_number":106,"context_line":"                \"Caught a messaging remote error.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_098fd523","line":103,"in_reply_to":"df7087c5_6798106a","updated":"2018-03-08 07:48:21.000000000","message":"This is fine. The log.exception logs the original exception","commit_id":"6eb00b15476003ef0ab270ec26f6d54c6ca302f7"}]}
