)]}'
{"mistral/api/controllers/v2/action_execution.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Use retries to prevent possible failures."},{"line_number":53,"context_line":"@rest_utils.rest_retry_on_db_error"},{"line_number":54,"context_line":"def _get_action_execution(action_ex_id):"},{"line_number":55,"context_line":"    with db_api.transaction():"},{"line_number":56,"context_line":"        return _get_action_execution_resource("},{"line_number":57,"context_line":"            db_api.get_action_execution(action_ex_id))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_45d3ed60","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":38},"updated":"2018-04-23 08:15:53.000000000","message":"Do you think it\u0027s a serious problem that we shadow id() here? We very very rarely even use it. I\u0027d prefer to keep just \u0027id\u0027 here as in many other places really. Naming IMO is very important and \u0027action_ex_\u0027 here is absolutely redundant, it duplicates the semantics that is already expressed in the name of the method.","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/api/controllers/v2/event_trigger.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class EventTriggersController(rest.RestController):"},{"line_number":36,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":37,"context_line":"    @wsme_pecan.wsexpose(resources.EventTrigger, types.uuid)"},{"line_number":38,"context_line":"    def get(self, event_trigger_id):"},{"line_number":39,"context_line":"        \"\"\"Returns the specified event_trigger.\"\"\""},{"line_number":40,"context_line":"        acl.enforce(\u0027event_triggers:get\u0027, auth_ctx.ctx())"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_e5c32188","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":32},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/api/controllers/v2/execution.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Use retries to prevent possible failures."},{"line_number":68,"context_line":"@rest_utils.rest_retry_on_db_error"},{"line_number":69,"context_line":"def _get_workflow_execution(wf_ex_id, must_exist\u003dTrue):"},{"line_number":70,"context_line":"    with db_api.transaction():"},{"line_number":71,"context_line":"        if must_exist:"},{"line_number":72,"context_line":"            wf_ex \u003d db_api.get_workflow_execution(wf_ex_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_a5b9a915","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":34},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/api/controllers/v2/task.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Use retries to prevent possible failures."},{"line_number":135,"context_line":"@rest_utils.rest_retry_on_db_error"},{"line_number":136,"context_line":"def _get_task_execution(task_ex_id):"},{"line_number":137,"context_line":"    with db_api.transaction():"},{"line_number":138,"context_line":"        task_ex \u003d db_api.get_task_execution(task_ex_id)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_653dd18d","line":136,"range":{"start_line":136,"start_character":24,"end_line":136,"end_character":32},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/db/v2/api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# Locking."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def acquire_lock(model, model_id):"},{"line_number":69,"context_line":"    return IMPL.acquire_lock(model, model_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_e548012e","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":30},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    return IMPL.get_workflow_definition(identifier, namespace\u003dnamespace)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"def get_workflow_definition_by_id(wf_def_id):"},{"line_number":122,"context_line":"    return IMPL.get_workflow_definition_by_id(wf_def_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_855105dc","line":121,"range":{"start_line":121,"start_character":34,"end_line":121,"end_character":41},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# Action definitions."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def get_action_definition_by_id(action_def_id):"},{"line_number":165,"context_line":"    return IMPL.get_action_definition_by_id(action_def_id)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_4561ada8","line":164,"range":{"start_line":164,"start_character":32,"end_line":164,"end_character":43},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Action executions."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"def get_action_execution(action_ex_id):"},{"line_number":211,"context_line":"    return IMPL.get_action_execution(action_ex_id)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_255cb9eb","line":210,"range":{"start_line":210,"start_character":25,"end_line":210,"end_character":35},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    return IMPL.create_action_execution(values)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"def update_action_execution(action_ex_id, values):"},{"line_number":228,"context_line":"    return IMPL.update_action_execution(action_ex_id, values)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_c574dd6a","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":40},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    return IMPL.create_workflow_execution(values)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"def update_workflow_execution(wf_ex_id, values):"},{"line_number":270,"context_line":"    return IMPL.update_workflow_execution(wf_ex_id, values)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_856a657e","line":269,"range":{"start_line":269,"start_character":30,"end_line":269,"end_character":38},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    return IMPL.create_task_execution(values)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"def update_task_execution(task_ex_id, values):"},{"line_number":332,"context_line":"    return IMPL.update_task_execution(task_ex_id, values)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_a56769b7","line":331,"range":{"start_line":331,"start_character":26,"end_line":331,"end_character":36},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    return IMPL.create_delayed_call(values)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"def delete_delayed_call(delayed_call_id):"},{"line_number":362,"context_line":"    return IMPL.delete_delayed_call(delayed_call_id)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_650b91d5","line":361,"range":{"start_line":361,"start_character":24,"end_line":361,"end_character":39},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    return IMPL.create_event_trigger(values)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def update_event_trigger(event_trigger_id, values):"},{"line_number":546,"context_line":"    return IMPL.update_event_trigger(event_trigger_id, values)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_050c15ea","line":545,"range":{"start_line":545,"start_character":25,"end_line":545,"end_character":41},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"@b.session_aware()"},{"line_number":129,"context_line":"def acquire_lock(model, model_id, session\u003dNone):"},{"line_number":130,"context_line":"    # Expire all so all objects queried after lock is acquired"},{"line_number":131,"context_line":"    # will be up-to-date from the DB and not from cache."},{"line_number":132,"context_line":"    session.expire_all()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_25111905","line":129,"range":{"start_line":129,"start_character":24,"end_line":129,"end_character":32},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/engine/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        return count \u003d\u003d len(execs) and full_capacity"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def _get_final_state(self):"},{"line_number":772,"context_line":"        def find_cancelled(execution):"},{"line_number":773,"context_line":"            return execution.accepted and execution.state \u003d\u003d states.CANCELLED"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        def find_error(execution):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_45d44d20","line":772,"range":{"start_line":772,"start_character":27,"end_line":772,"end_character":36},"updated":"2018-04-23 08:15:53.000000000","message":"Why such a long name? It\u0027s an internal method with a very limited visibility scope. Let\u0027s keep such things concise. You can call it \u0027t_ex\u0027, for example, or just \u0027t\u0027 to reflect the word \u0027task\u0027. But \u0027execution\u0027 is even not precise enough because it\u0027s not clear what kind of execution.","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        )"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _get_next_start_index(self):"},{"line_number":802,"context_line":"        def is_running(execution):"},{"line_number":803,"context_line":"            return (execution.accepted or states.is_running(execution.state) or"},{"line_number":804,"context_line":"                    states.is_idle(execution.state))"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_65d95155","line":802,"range":{"start_line":802,"start_character":23,"end_line":802,"end_character":32},"updated":"2018-04-23 08:15:53.000000000","message":"Same","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}],"mistral/tests/unit/db/v2/test_sqlalchemy_db_api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"            self.assertIsNotNone(fetched.updated_at)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"    def test_create_or_update_action_execution(self):"},{"line_number":1369,"context_line":"        action_ex_id \u003d \u0027not-existing-id\u0027"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"        self.assertIsNone(db_api.load_action_execution(action_ex_id))"},{"line_number":1372,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_a5ea09d5","line":1369,"range":{"start_line":1369,"start_character":8,"end_line":1369,"end_character":20},"updated":"2018-04-23 08:15:53.000000000","message":"See my comment in action_execution.py","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"            )"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"    def test_create_or_update_workflow_execution(self):"},{"line_number":1568,"context_line":"        wf_ex_id \u003d \u0027not-existing-id\u0027"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        self.assertIsNone(db_api.load_workflow_execution(wf_ex_id))"},{"line_number":1571,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_65c2b15b","line":1568,"range":{"start_line":1568,"start_character":8,"end_line":1568,"end_character":16},"updated":"2018-04-23 08:15:53.000000000","message":"same","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9dcafe5df4621d5cc4aa01d170619fc94550b7be","unresolved":false,"context_lines":[{"line_number":1977,"context_line":"        self.assertIsNotNone(fetched.updated_at)"},{"line_number":1978,"context_line":""},{"line_number":1979,"context_line":"    def test_create_or_update_task_execution(self):"},{"line_number":1980,"context_line":"        task_ex_id \u003d \u0027not-existing-id\u0027"},{"line_number":1981,"context_line":""},{"line_number":1982,"context_line":"        self.assertIsNone(db_api.load_task_execution(task_ex_id))"},{"line_number":1983,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_05b3b50b","line":1980,"range":{"start_line":1980,"start_character":8,"end_line":1980,"end_character":18},"updated":"2018-04-23 08:15:53.000000000","message":"same","commit_id":"8a0e181249905ace4ffb1afe5abb5216b8253876"}]}
